Re: [Intel-gfx] [PATCH v2 04/12] drm/i915/dp: s/intel_dp_hdmi_ycbcr420/intel_dp_is_ycbcr420/

["Shankar, Uma" <uma.shankar@intel.com>]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjala
> Sent: Tuesday, March 22, 2022 5:30 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH v2 04/12] drm/i915/dp:
> s/intel_dp_hdmi_ycbcr420/intel_dp_is_ycbcr420/
> 
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> intel_dp_hdmi_ycbcr420() does account for native DP 4:2:0 output as well, so lets
> rename it a bit.

Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>

> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index fc50802c9997..9720571438e9 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1157,8 +1157,8 @@ static bool intel_dp_supports_dsc(struct intel_dp
> *intel_dp,
>  		drm_dp_sink_supports_dsc(intel_dp->dsc_dpcd);
>  }
> 
> -static bool intel_dp_hdmi_ycbcr420(struct intel_dp *intel_dp,
> -				   const struct intel_crtc_state *crtc_state)
> +static bool intel_dp_is_ycbcr420(struct intel_dp *intel_dp,
> +				 const struct intel_crtc_state *crtc_state)
>  {
>  	return crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420
> ||
>  		(crtc_state->output_format ==
> INTEL_OUTPUT_FORMAT_YCBCR444 && @@ -1169,7 +1169,7 @@ static bool
> intel_dp_hdmi_bpc_possible(struct intel_dp *intel_dp,
>  				       const struct intel_crtc_state *crtc_state,
>  				       int bpc)
>  {
> -	bool ycbcr420_output = intel_dp_hdmi_ycbcr420(intel_dp, crtc_state);
> +	bool ycbcr420_output = intel_dp_is_ycbcr420(intel_dp, crtc_state);
>  	int clock = crtc_state->hw.adjusted_mode.crtc_clock;
> 
>  	return intel_hdmi_bpc_possible(crtc_state, bpc,
> --
> 2.34.1