From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915/lrc: Remove superfluous WARN_ON Date: Fri, 26 Jan 2018 12:21:51 +0000 Message-ID: <79c8ea5c-936e-eb45-e4bc-27e15e56c35e@linux.intel.com> References: <20180126121846.12007-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id A45AF6E670 for ; Fri, 26 Jan 2018 12:21:53 +0000 (UTC) In-Reply-To: <20180126121846.12007-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI2LzAxLzIwMTggMTI6MTgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBSZW1vdmUgdGhlIFdB Uk5fT04oY2UtPnN0YXRlKSBpbnNpZGUgdGhlIHN0YXRpYyBmdW5jdGlvbiBvbmx5IGNhbGxlZAo+ IHdoZW4gY2UtPnN0YXRlID09IE5VTEwgYW5kIGRvd25ncmFkZSB0aGUgdy9hIGJhdGNoIHNldHVw IHdhcm5pbmcgaW50byBhCj4gZGV2ZWxvcGVyIG9ubHkgbW9kZSAoR0VNX1dBUk5fT04pLgo+IAo+ IHYyOiBNb3ZlIHRoZSBkZWZlcnJlZCBhbGxvYyBndWFyZCBpbnRvIHRoZSBjYWxsZWUsIGVsaW1p bmF0aW5nIHRoZSBuZWVkCj4gZm9yIHRoZSBXQVJOX09OOgo+IGFkZC9yZW1vdmU6IDAvMCBncm93 L3NocmluazogMC8xIHVwL2Rvd246IDAvLTEgKC0xKQo+IEZ1bmN0aW9uICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG9sZCAgICAgbmV3ICAgZGVsdGEKPiBleGVjbGlzdHNfY29u dGV4dF9waW4gICAgICAgICAgICAgICAgICAgICAgIDE4MTkgICAgMTgxOCAgICAgIC0xCj4gCj4g U2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4g Q2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gLS0tCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyB8IDE0ICsrKysrKystLS0tLS0tCj4gICAx IGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggMWEzMTc0MzcxYzhlLi5jOGExMTMxNWIzNTcgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC0xMDkxLDExICsxMDkxLDkgQEAgZXhl Y2xpc3RzX2NvbnRleHRfcGluKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwKPiAgIAkJ Z290byBvdXQ7Cj4gICAJR0VNX0JVR19PTighY2UtPnBpbl9jb3VudCk7IC8qIG5vIG92ZXJmbG93 IHBsZWFzZSEgKi8KPiAgIAo+IC0JaWYgKCFjZS0+c3RhdGUpIHsKPiAtCQlyZXQgPSBleGVjbGlz dHNfY29udGV4dF9kZWZlcnJlZF9hbGxvYyhjdHgsIGVuZ2luZSk7Cj4gLQkJaWYgKHJldCkKPiAt CQkJZ290byBlcnI7Cj4gLQl9Cj4gKwlyZXQgPSBleGVjbGlzdHNfY29udGV4dF9kZWZlcnJlZF9h bGxvYyhjdHgsIGVuZ2luZSk7Cj4gKwlpZiAocmV0KQo+ICsJCWdvdG8gZXJyOwo+ICAgCUdFTV9C VUdfT04oIWNlLT5zdGF0ZSk7Cj4gICAKPiAgIAlyZXQgPSBfX2NvbnRleHRfcGluKGN0eCwgY2Ut PnN0YXRlKTsKPiBAQCAtMTQxOSw3ICsxNDE3LDggQEAgc3RhdGljIGludCBpbnRlbF9pbml0X3dv cmthcm91bmRfYmIoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCSAqLwo+ICAg CWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHdhX2JiX2ZuKTsgaSsrKSB7Cj4gICAJCXdhX2Ji W2ldLT5vZmZzZXQgPSBiYXRjaF9wdHIgLSBiYXRjaDsKPiAtCQlpZiAoV0FSTl9PTighSVNfQUxJ R05FRCh3YV9iYltpXS0+b2Zmc2V0LCBDQUNIRUxJTkVfQllURVMpKSkgewo+ICsJCWlmIChHRU1f V0FSTl9PTighSVNfQUxJR05FRCh3YV9iYltpXS0+b2Zmc2V0LAo+ICsJCQkJCSAgICBDQUNIRUxJ TkVfQllURVMpKSkgewo+ICAgCQkJcmV0ID0gLUVJTlZBTDsKPiAgIAkJCWJyZWFrOwo+ICAgCQl9 Cj4gQEAgLTIyNzEsNyArMjI3MCw4IEBAIHN0YXRpYyBpbnQgZXhlY2xpc3RzX2NvbnRleHRfZGVm ZXJyZWRfYWxsb2Moc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCwKPiAgIAlzdHJ1Y3QgaW50 ZWxfcmluZyAqcmluZzsKPiAgIAlpbnQgcmV0Owo+ICAgCj4gLQlXQVJOX09OKGNlLT5zdGF0ZSk7 Cj4gKwlpZiAoY2UtPnN0YXRlKQo+ICsJCXJldHVybiAwOwo+ICAgCj4gICAJY29udGV4dF9zaXpl ID0gcm91bmRfdXAoZW5naW5lLT5jb250ZXh0X3NpemUsIEk5MTVfR1RUX1BBR0VfU0laRSk7Cj4g ICAKPiAKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwu Y29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK