From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6 Date: Tue, 10 Apr 2018 11:22:55 +0100 Message-ID: <7a7a4c0b-1270-982b-6e69-96ffd2257a73@linux.intel.com> References: <20180410092328.20645-1-tvrtko.ursulin@linux.intel.com> <152335422737.3167.17662821212205420318@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 714E289E0C for ; Tue, 10 Apr 2018 10:22:58 +0000 (UTC) In-Reply-To: <152335422737.3167.17662821212205420318@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEwLzA0LzIwMTggMTA6NTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA0LTEwIDEwOjIzOjI4KQo+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pgo+PiBXaGlsZSB0aGlua2luZyBhYm91dCBzcG9y YWRpYyBmYWlsdXJlcyBvZiBwZXJmX3BtdS9yYzYtcnVudGltZS1wbSogdGVzdHMKPj4gb24gc29t ZSBDSSBtYWNoaW5lcyBJIGhhdmUgY29uY2x1ZGVkIHRoYXQ6IGEpIHRoZSBQTVUgcmVhZG91dCBv ZiBSQzYgY2FuCj4+IHJhY2UgYWdhaW5zdCBydW50aW1lIFBNIHRyYW5zaXRpb25zLCBhbmQgYikg dGhlcmUgYXJlIG90aGVyIHJlYXNvbnMgdGhhbgo+PiBiZWluZyBydW50aW1lIHN1c3BlbmRlZCB3 aGljaCBjYW4gY2F1c2UgaW50ZWxfcnVudGltZV9wbV9nZXRfaWZfaW5fdXNlIHRvCj4+IGZhaWwu Cj4+Cj4+IFRoZXJlZm9yZSB3aGVuIGVzdGltYXRpbmcgUkM2IHRoZSBjb2RlIG5lZWRzIHRvIGFz c2VydCB3ZSBhcmUgaW5kZWVkIGluCj4+IHN1c3BlbmRlZCBzdGF0ZSBhbmQgaWYgbm90IHRoZSBi ZXN0IHdlIGNhbiBkbyBpcyByZXR1cm4gdGhlIGxhc3Qga25vd24gUkM2Cj4+IHZhbHVlLgo+Pgo+ PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29t Pgo+PiBGaXhlczogMWZlNjk5ZTMwMTEzICgiZHJtL2k5MTUvcG11OiBGaXggc2xlZXAgdW5kZXIg YXRvbWljIGluIFJDNiByZWFkb3V0IikKPj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVz a3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTAxMAo+PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2 cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMt d2lsc29uLmNvLnVrPgo+PiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+PiAt LS0KPj4gSSB3YXMgYWJsZSB0byB0cmlnZ2VyIHN0YXRlICE9IFJQTV9TVVNQRU5ERUQgb24gdGhl IHNoYXJkcywgYnV0IG5vdCB5ZXQKPj4gdGhlIGFjdHVhbCBlc3RpbWF0aW9uIG92ZXJhY2NvdW50 aW5nLiBBcyBzdWNoIHRoaXMgZml4IGlzIGJhc2VkIHBhcnRpYWxseQo+PiBvbiBzcGVjdWxhdGlv biB0aGF0IGl0IHdpbGwgZml4IHRoZSBzcG9yYWRpYyBwZXJmX3BtdS9yYzYqIGZhaWx1cmVzLgo+ PiBOZXZlcnRoZWxlc3MgSSB0aGluayBpdCBpcyBjb3JyZWN0IHRvIGFkZCB0aGlzIGNoZWNrIHJl Z2FyZGxlc3MuCj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMgfCAy NCArKysrKysrKysrKysrKysrKysrKysrKysKPj4gICAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0 aW9ucygrKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcG11LmMKPj4gaW5kZXggYmQ3ZTY5NWZjNjYz Li5lOTJhOTU3MWRiNzcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cG11LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYwo+PiBAQCAtNDcz LDYgKzQ3MywzMCBAQCBzdGF0aWMgdTY0IGdldF9yYzYoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg Kmk5MTUpCj4+ICAgICAgICAgICAgICAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJmk5MTUtPnBtdS5s b2NrLCBmbGFncyk7Cj4+ICAgICAgICAgICAgICAgICAgc3Bpbl9sb2NrKCZrZGV2LT5wb3dlci5s b2NrKTsKPj4gICAKPj4gKyAgICAgICAgICAgICAgIC8qCj4+ICsgICAgICAgICAgICAgICAgKiBB ZnRlciB0aGUgYWJvdmUgYnJhbmNoIGludGVsX3J1bnRpbWVfcG1fZ2V0X2lmX2luX3VzZSBmYWls ZWQKPj4gKyAgICAgICAgICAgICAgICAqIHRvIGdldCB0aGUgcnVudGltZSBQTSByZWZlcmVuY2Ug d2UgY2Fubm90IGFzc3VtZSB3ZSBhcmUgaW4KPj4gKyAgICAgICAgICAgICAgICAqIHJ1bnRpbWUg c3VzcGVuZCBzaW5jZSB3ZSBjYW4gZWl0aGVyOiBhKSByYWNlIHdpdGggY29taW5nIG91dAo+PiAr ICAgICAgICAgICAgICAgICogb2YgaXQgYmVmb3JlIHdlIHRvb2sgdGhlIHBvd2VyLmxvY2ssIG9y IGIpIHRoZXJlIGFyZSBvdGhlcgo+PiArICAgICAgICAgICAgICAgICogc3RhdGVzIHRoYW4gc3Vz cGVuZGVkIHdoaWNoIGNhbiBicmluZyB1cyBoZXJlLgo+PiArICAgICAgICAgICAgICAgICoKPj4g KyAgICAgICAgICAgICAgICAqIFdlIG5lZWQgdG8gZG91YmxlLWNoZWNrIHRoYXQgd2UgYXJlIGlu ZGVlZCBjdXJyZW50bHkgcnVudGltZQo+PiArICAgICAgICAgICAgICAgICogc3VzcGVuZGVkIGFu ZCBpZiBub3Qgd2UgY2Fubm90IGRvIGJldHRlciB0aGFuIHJlcG9ydCB0aGUgbGFzdAo+PiArICAg ICAgICAgICAgICAgICoga25vd24gUkM2IHZhbHVlLgo+PiArICAgICAgICAgICAgICAgICovCj4+ ICsgICAgICAgICAgICAgICBpZiAoa2Rldi0+cG93ZXIucnVudGltZV9zdGF0dXMgIT0gUlBNX1NV U1BFTkRFRCkgewo+PiArICAgICAgICAgICAgICAgICAgICAgICBzcGluX3VubG9jaygma2Rldi0+ cG93ZXIubG9jayk7Cj4+ICsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgaWYgKGk5MTUtPnBt dS5zYW1wbGVbX19JOTE1X1NBTVBMRV9SQzZfRVNUSU1BVEVEXS5jdXIpCj4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdmFsID0gaTkxNS0+cG11LnNhbXBsZVtfX0k5MTVfU0FNUExF X1JDNl9FU1RJTUFURURdLmN1cjsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgZWxzZQo+PiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZhbCA9IGk5MTUtPnBtdS5zYW1wbGVbX19J OTE1X1NBTVBMRV9SQzZdLmN1cjsKPiAKPiBJZiBycG0gYXdha2UsIGJ1dCBoYXZpbmcgbG9zdCB0 aGUgcmFjZSB0byByZWFkIHRoZSByZWdzLCByZXBvcnQgdGhlIGxhc3QKPiBrbm93biB2YWx1ZS4K PiAKPiBUaGlzIGlzIGJlY2F1c2Ugd2UgZG9uJ3Qga25vdyBpZiBhbm90aGVyIHRocmVhZCBpcyBp biB0aGUgb3RoZXIgYnJhbmNoLAo+IGFuZCBzbyB3ZSB3aWxsIGhhdmUgb25lIHVwZGF0aW5nIHRo ZSBlc3RpbWF0ZSB3aGlsZSBpdCBiZWluZyBjb21wYXJlZAo+IGFnYWluc3QuCgpObywgdGhlIHJh Y2UgaXMgaW50ZWxfcnVudGltZV9wbV9nZXRfaWZfaW5fdXNlIHRlbGxpbmcgdXMgdGhlIGRldmlj ZSBpcyAKbm90IGFjdGl2ZSwgYnV0IGEpIHRoYXQgZG9lc24ndCBtZWFuIGl0IGlzIHN1c3BlbmRl ZCwgYW5kIGIpIGl0IGRvZXNuJ3QgCm1lYW4gaXQgaXMgc3RpbGwgc3VzcGVuZGVkIGFmdGVyIHRo ZSBjaGVjay4KCkFsc28gUE1VIGludGVybmFsIHN0YXRlIGlzIHNlcmlhbGl6ZWQgYnkgdGhlIHNw aW5sb2NrIHNvIHRoZXJlIGlzIG5vIAppbmNvbnNpc3RlbmN5IHRoZXJlLgo+IEJ1dCBJJ20gbm90 IHVuZGVyc3RhbmRpbmcgdGhlIGZhaWx1cmUgLS0gd2h5IGlzIHRoZSBlc3RpbWF0ZSBiYWQ/IEF0 IHRoZQo+IHZlcnkgbGVhc3Qgd2Ugc3RpbGwgZW5zdXJlIHRoYXQgaXQgaXMgbW9ub3RvbmljPyBJ cyBpdCBqdXN0IHRoZSBqaXR0ZXIKPiB5b3UgYXJlIHdvcnJ5aW5nIGFib3V0PyAoSWYgdGhlIGVz dGltYXRlIGlzIGJhZCBoZXJlLCBpc24ndCBpdCBhbHdheXMKPiBiYWQ/KQoKQXMgZmFyIGFzIEkg aGF2ZSBzZWVuIGZhaWx1cmVzIGZyb20gQ0kgYXJlIGFsbCBlc3RpbWF0ZSBiZWluZyB0b28gbGFy Z2UuIAoobm8gaml0dGVyIGFuZCBubyBnb2luZyBiYWNrd2FyZHMpCgpXaGF0IEkgc3VzcGVjdCBp cyBnb2luZyBiYWQgaW4gZWl0aGVyIGNhc2UsIGlzIHRoYXQgd2UgbXVzdCBub3QgYWRkIHRoZSAK ZGVsdGEgZnJvbSBjdXJyZW50IGppZmZpZXMgdG8gaW50ZXJuYWwgcnVudGltZSBwbSBjb3VudGVy cyBpZiBzdGF0ZSBpcyAKbm90IHN1c3BlbmRlZC4gSWYgd2UgZG8gdGhhdCB3ZSBhcmUgYWNjb3Vu dGluZyBhbiB1bmtub3duIHBlcmlvZCBvZiB0aW1lIAphcyBzdXNwZW5kZWQgdGltZSBhbmQgdGhh dCB3b3VsZCBleHBsYWluIHRoZSBvdmVyLWVzdGltYXRpb24uCgpJbiBvdGhlciB3b3JkcyB3ZSBh cmUgb25seSBhbGxvd2VkIHRvIGVzdGltYXRlIGlmIHRoZSBjdXJyZW50IHN0YXRlIGlzIApkZWZp bml0ZWx5IHN1c3BlbmRlZC4gSWYgaXQgaXMgYW55dGhpbmcgZWxzZSB3ZSBuZWVkIHRvIHJlcG9y dCBlaXRoZXIgCnRoZSBsYXN0IGVzdGltYXRlZCB2YWx1ZSwgb3IgdGhlIGxhc3QgcmVhbCB2YWx1 ZSwgZGVwZW5kaW5nIHdoYXQgaXMgbW9yZSAKcmVjZW50LgoKSSd2ZSBkb25lIGEgQ0kgcnVuIHdo aWNoIGRlZmluaXRlbHkgc2hvd3Mgd2UgY2FuIGVuZCB1cCBpbiB0aGlzIHBhdGggCndoZW4gc3Rh dGUgaXMgbm90IHN1c3BlbmRlZC4KCj4+ICsKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgc3Bp bl91bmxvY2tfaXJxcmVzdG9yZSgmaTkxNS0+cG11LmxvY2ssIGZsYWdzKTsKPj4gKwo+PiArICAg ICAgICAgICAgICAgICAgICAgICByZXR1cm4gdmFsOwo+PiArICAgICAgICAgICAgICAgfQo+IAo+ IEknZCBwcmVmZXIgbW92aW5nIHRoZSBSUE1fU1VTUEVOREVEIGNvZGUgaW50byBhbiBlbHNlIGJy YW5jaCB0byBhdm9pZAo+IGFub3RoZXIgdW5sb2NrL2Vhcmx5IHJldHVybiBoZXJlLiAoSXQganVz dCBmaXRzIGludG8gODBjb2xzLCBzbyBubwo+IGV4Y3VzZXMgOykKCk9rYXkgbWFrZXMgc2Vuc2Uu CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=