From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 0/4] Haswell GPU hang fixes
Date: Fri, 17 Aug 2012 15:39:05 -0700
Message-ID: <7a88f53ae1de002fedf2a631b439adb1@bwidawsk.net>
References: <1345239344-9968-1-git-send-email-przanoni@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id A36AB9F753
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 17 Aug 2012 15:39:04 -0700 (PDT)
In-Reply-To: <1345239344-9968-1-git-send-email-przanoni@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On 2012-08-17 14:35, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Hi
>
> Since we stopped running the gen6 workarounds on gen > 6 I started
> seeing a lot
> of GPU hangs on my gen 7.5 machine. These patches add gen7+ 
> workarounds which
> prevent the GPU hangs I'm seeing.
>
> These patches were tested mostly on HSW and briefly on IVB, but the
> workarounds
> implemented are documented for both. This is also the first time I 
> touch this
> kind of code, so extra careful reviewing might be needed.
>
> Thanks,
> Paulo
>
>
> Paulo Zanoni (4):
>   drm/i915: add gen7_render_ring_flush
>   drm/i915: add workarounds directly to gen6_render_ring_flush
>   drm/i915: add workaround to gen7_render_ring_flush
>   drm/i915: add one more workaround to gen7_render_ring_flush
>
>  drivers/gpu/drm/i915/intel_ringbuffer.c | 81
> ++++++++++++++++++++++++++++++---
>  1 file changed, 74 insertions(+), 7 deletions(-)

I don't think this makes for ideal bisection. I'd rather you implement 
the ring flush + workarounds before you set the pointer. If you want to 
keep the patches split out like this, just add a 5 patch to do the 
pointer change that's in the first patch. Or else collapse patch 1, 3, 4 
into 1.

I didn't really review anything yet though.

-- 
Ben Widawsky, Intel Open Source Technology Center