From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D8BCC43334 for ; Wed, 8 Jun 2022 08:06:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B3D8A10E5CD; Wed, 8 Jun 2022 08:06:51 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC9C810E5CD for ; Wed, 8 Jun 2022 08:06:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654675610; x=1686211610; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=mW1PPccn0lIPbDVAWwkeOj1XnJlvD8tnVWRMur2wTTQ=; b=JZkmX9FxsK88mwlxo2Ok4Jl3LHnC7CQnN0o3M3HHV+mxfNZt2a9G1lqE Mm9Gs/iYiSIE0YER2N/IbJEDiaNuV0XpLSRd9NK0O3w0L+coaWyhxYy8f Kb5Zr1GBHvc+BiHnnGnFpnn76SP9hyamjYAsOjKtiDb9g2d1ZQeo4mjJs /tjUuHJ5UKTK0e7OSwn2v8Lv6doxLpI+7bxaMPe0K+Nlny+MGhkLl/UDm +l7goBc7BwgG4qfg3vcoGrAu0UByXuqjsrFwguPUmFvky1Lfy9tI3/zia klq55lnfH22csqMzwts740Ys0OEEb/OBoTUrpKNF+f2fn1SKQEFCv3tpY Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="274337396" X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="274337396" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 01:06:50 -0700 X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="907536590" Received: from jking17-mobl.ger.corp.intel.com (HELO [10.213.193.156]) ([10.213.193.156]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 01:06:49 -0700 Message-ID: <7b62505a-95a0-25ab-9299-e349453e49f5@linux.intel.com> Date: Wed, 8 Jun 2022 09:06:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Jani Nikula , intel-gfx@lists.freedesktop.org References: <20220506120405.2582372-1-jani.nikula@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <20220506120405.2582372-1-jani.nikula@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 06/05/2022 13:04, Jani Nikula wrote: > Fix: > > drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:61:6: warning: symbol > 'intel_pxp_debugfs_register' was not declared. Should it be static? > > Sort and remove the redundant pxp prefixes from the includes while at > it. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c > index c9da1015eb42..e888b5124a07 100644 > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c > @@ -9,9 +9,10 @@ > #include > > #include "gt/intel_gt_debugfs.h" > -#include "pxp/intel_pxp.h" > -#include "pxp/intel_pxp_irq.h" > #include "i915_drv.h" > +#include "intel_pxp.h" > +#include "intel_pxp_debugfs.h" > +#include "intel_pxp_irq.h" > > static int pxp_info_show(struct seq_file *m, void *data) > { Reviewed-by: Tvrtko Ursulin Lets try to copy domain owners when doing cleanups to lessen the maintainer load, since it appears people are not really scanning the upstream mailing list these days. :( Regards, Tvrtko