From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3 1/2] drm/i915: Move engine->submit_request selection to a vfunc Date: Wed, 15 Mar 2017 08:14:04 +0000 Message-ID: <7cee577b-8e48-d4bd-0b92-adc01a74fed7@linux.intel.com> References: <20170314093441.7397-1-chris@chris-wilson.co.uk> <20170314213342.GO2118@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60C236E091 for ; Wed, 15 Mar 2017 08:14:11 +0000 (UTC) In-Reply-To: <20170314213342.GO2118@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE0LzAzLzIwMTcgMjE6MzMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBUdWUsIE1hciAx NCwgMjAxNyBhdCAwNDozMTo1OFBNICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4KPj4g T24gMTQvMDMvMjAxNyAwOTozNCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+Pj4gSXQgdHVybnMgb3V0 IHRoYXQgd2UgbWF5IHdhbnQgdG8gcmVzdG9yZSB0aGUgb3JpZ2luYWwKPj4+IGVuZ2luZS0+c3Vi bWl0X3JlcXVlc3QgKGFuZCBlbmdpbmUtPnNjaGVkdWxlKSBjYWxsYmFja3MgZnJvbSBtb3JlIHRo YW4KPj4+IGp1c3QgdGhlIGd1YyA8LT4gZXhlY2xpc3RzIHRyYW5zaXRpb24uIE1vdmUgdGhpcyB0 byBhIHZmdW5jIHNvIHdlIGNhbgo+Pj4gaGF2ZSBhIGNvbW1vbiBpbnRlcmZhY2UuCj4+Pgo+Pj4g U2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+ PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPj4+IENjOiBN aWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGludGVsLmNvbT4KPj4+IC0tLQo+Pj4gZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jIHwgIDIgKy0KPj4+IGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jICAgICB8IDEwICsrKysrKysrKysKPj4+IGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICAgICB8IDE1ICsrKysrLS0tLS0t LS0tLQo+Pj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmggICAgICAgICAgIHwgIDEg LQo+Pj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jICAgIHwgMTUgKysr KysrKysrKysrKy0tCj4+PiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgg ICAgfCAgNCArKysrCj4+PiA2IGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDE0IGRl bGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNz aW9uLmMKPj4+IGluZGV4IGI0ZDI0Y2Q3NjM5YS4uMTE5YjVjMDczODMzIDEwMDY0NAo+Pj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4+IEBAIC0xMDUxLDcg KzEwNTEsNyBAQCB2b2lkIGk5MTVfZ3VjX3N1Ym1pc3Npb25fZGlzYWJsZShzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+PiAJCXJldHVybjsKPj4+Cj4+PiAJLyogUmV2ZXJ0IGJh Y2sgdG8gbWFudWFsIEVMU1Agc3VibWlzc2lvbiAqLwo+Pj4gLQlpbnRlbF9leGVjbGlzdHNfZW5h YmxlX3N1Ym1pc3Npb24oZGV2X3ByaXYpOwo+Pj4gKwlpbnRlbF9lbmdpbmVzX2VuYWJsZV9zdWJt aXNzaW9uKGRldl9wcml2KTsKPj4KPj4gaW50ZWxfZW5naW5lc19kZWZhdWx0X3N1Ym1pc3Npb24g Y2FtZSB0byBteSBtaW5kIGJ1dCB0aGF0IHdpbGwgYWxzbwo+PiBiZSBtaXNsZWFkaW5nIG9uY2Ug dGhlIGd1YyBzd2l0Y2ggaXMgdG9nZ2xlZC4gQnV0IEkgdGhpbmsgbGVzcwo+PiBtaXNsZWFkaW5n IHRoYW4gZW5hYmxlX3N1Ym1pc3Npb24uIEFuZCB2ZnVuYyBuYW1lIG1heWJlIGFzCj4+IGFzc2ln bl9kZWZhdWx0X3N1Ym1pc3Npb24/Cj4KPiBpbnRlbF9lbmdpbmVzX3Jlc2V0X2RlZmF1bHRfc3Vi bWlzc2lvbgo+IGVuZ2luZS0+c2V0X2RlZmF1bHRfc3VibWlzc2lvbgo+Cj4gTm90IG92ZXJseSBl bmFtb3VyZWQsIGJ1dCB0aGUgYWJvdmUgc2VlbXMgbGlrZSB0aGUgYmVzdCBjb21wcm9taXNlIHNv Cj4gZmFyLgoKU291bmRzIGdvb2QuCgo+Pj4gfQo+Pj4KPj4+IHZvaWQgaTkxNV9ndWNfc3VibWlz c2lvbl9maW5pKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4+PiBpbmRleCA3M2ZlNzE4NTE2YTUuLjU2NjNl YmFiODUxZiAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2lu ZV9jcy5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+ Pj4gQEAgLTE5MSw2ICsxOTEsNyBAQCBpbnQgaW50ZWxfZW5naW5lc19pbml0KHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4+IAkJCWdvdG8gY2xlYW51cDsKPj4+IAkJfQo+Pj4K Pj4+ICsJCWVuZ2luZS0+ZW5hYmxlX3N1Ym1pc3Npb24oZW5naW5lKTsKPj4KPj4gQ291bGQgYmUg bW92ZWQgdG8gaW50ZWxfZW5naW5lc19zZXR1cF9jb21tb24gaWYgdGhlCj4+IGxvZ2ljYWxfcmlu Z19zZXR1cCB3YXMgcmUtYXJyYW5nZWQgYSBiaXQgc28gdGhhdCB0aGUgZGVmYXVsdF92ZnVuY3MK Pj4gYXJlIGFzc2lnbmVkIGJlZm9yZSBpdC4gTGVnYWN5IGxvb2tzIGxpa2UgaXQgd291bGQgYmUg YWxyaWdodCB3aXRoCj4+IHRoYXQgYXBwcm9hY2ggYWxyZWFkeS4KPj4KPj4gTXkgdGhpbmtpbmcg aGVyZSBpcyBub3QgdG8gZXhwb3NlIHRoaXMgdmZ1bmMgc28gcHJvbWluZW50bHkgaW4gdGhlCj4+ IGNvZGUgc2luY2UgaXQgaXMgYSBiaXQgb2YgYSBsb3cgbGV2ZWwgaW50ZXJuYWwgaW1wbGVtZW50 YXRpb24gdGhpbmcuCj4KPiBUaGUgY29uY2VybiBpcyByZWFzb25hYmxlLCBidXQgZXF1YWxseSBt b3ZpbmcgaXQgdG8KPiBpbnRlbF9lbmdpbmVfc2V0dXBfY29tbW9uKCkgaXMgaGFpcnkuIE90b2gs IEkgdGhpbmsgaXQgaXMgc3VpdGFibGUgZm9yCj4gaW50ZWxfZW5naW5lX2luaXRfY29tbW9uKCku IEhhcHB5PwoKV2h5IGRvIHlvdSB0aGluayBpdCBpcyBoYWlyeSBmb3IgaW50ZWxfZW5naW5lX3Nl dHVwX2NvbW1vbj8gSXQga2VlcHMgdGhlIApzZXR1cC9pbml0IHNwbGl0IGZvciBscmMsIHdoZXJl IGFsbCB2ZnVuY3MgYXJlIGluaXRpYWxpemVkIGluIHRoZSBzZXR1cCAKcGhhc2Ugd2hpY2ggd2Fz IHRoZSBpbnRlbnRpb24uCgpMZWdhY3kgaXMgYSBiaXQgbW9yZSB1bmNsZWFubHkgc3BsaXQgbm93 IHRoYXQgSSBsb29rIGF0IGl0LCBidXQgcHV0dGluZyAKaXQgYXQgaW50ZWxfZW5naW5lX2luaXRf Y29tbW9uIHdvdWxkIGJlIGp1c3QgbW9yZSBvZiB0aGUgc2FtZS4KClJlZ2FyZHMsCgpUdnJ0a28K CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==