From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sujaritha Subject: Re: [PATCH v2] drm/i915/guc: Fixing error code for WOPCM initialization Date: Wed, 6 Mar 2019 10:44:03 -0800 Message-ID: <7cfb409b-2cf6-891f-5628-88af458f8edd@intel.com> References: <20190305005556.25073-1-sujaritha.sundaresan@intel.com> <20190306003011.12724-1-sujaritha.sundaresan@intel.com> <155186191765.27405.6403232879970167597@skylake-alporthouse-com> <155186330557.27405.944800209177609752@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0724769125==" Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id CCC236E181 for ; Wed, 6 Mar 2019 19:01:57 +0000 (UTC) In-Reply-To: <155186330557.27405.944800209177609752@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============0724769125== Content-Type: multipart/alternative; boundary="------------6C42E731ABE39C1F21FF43B8" Content-Language: en-US This is a multi-part message in MIME format. --------------6C42E731ABE39C1F21FF43B8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 3/6/19 1:08 AM, Chris Wilson wrote: > Quoting Michal Wajdeczko (2019-03-06 09:01:09) >> On Wed, 06 Mar 2019 09:45:17 +0100, Chris Wilson >>> Now doing an if (i915_error_injected() && !err) err = -EINVAL; makes >>> sense to catch places where we've eaten that error and so breaking the >>> test. >> This will not work today, as at least in one place - i915_gem_init - we >> inject -EIO which later we try to replace with success. And for that case >> we may rather want to add > I think we may want to move that particular test to one side, something > along the lines of i915.disable_gpu=1 ? > -Chris Just to clarify on how to proceed with the fix. I'm not sure if the suggestion is to go back to the previous version of the fix or to go for a different approach. Also Arek has said in the internal mailing list that there are some changes being made to the -piglit-style-dmesg, so looks like this issue will be flagging up in the public CI as well. -Sujaritha --------------6C42E731ABE39C1F21FF43B8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit


On 3/6/19 1:08 AM, Chris Wilson wrote:
Quoting Michal Wajdeczko (2019-03-06 09:01:09)

On Wed, 06 Mar 2019 09:45:17 +0100, Chris Wilson  

Now doing an if (i915_error_injected() && !err) err = -EINVAL; makes
sense to catch places where we've eaten that error and so breaking the
test.

This will not work today, as at least in one place - i915_gem_init - we
inject -EIO which later we try to replace with success. And for that case
we may rather want to add

I think we may want to move that particular test to one side, something
along the lines of i915.disable_gpu=1 ?
-Chris

Just to clarify on how to proceed with the fix. I'm not sure if the

suggestion is to go back to the previous version of the fix or to

go for a different approach. Also Arek has said in the internal

mailing list that there are some changes being made to the

-piglit-style-dmesg, so looks like this issue will be flagging up in

the public CI as well.

-Sujaritha

--------------6C42E731ABE39C1F21FF43B8-- --===============0724769125== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============0724769125==--