From mboxrd@z Thu Jan 1 00:00:00 1970 From: Animesh Manna Subject: Re: [PATCH v3 03/11] drm/i915/dsb: single register write function for DSB. Date: Thu, 29 Aug 2019 18:39:53 +0530 Message-ID: <7f3385a8-32c1-1e24-ba11-c08f71a5d8b1@intel.com> References: <20190827191026.26175-1-animesh.manna@intel.com> <20190827191026.26175-4-animesh.manna@intel.com> <2ceaa20f-a18d-cf7a-cde6-b534900f5949@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 564CB6E02E for ; Thu, 29 Aug 2019 13:09:55 +0000 (UTC) In-Reply-To: <2ceaa20f-a18d-cf7a-cde6-b534900f5949@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Sharma, Shashank" , intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org SGksCgoKT24gOC8yOC8yMDE5IDg6NDYgUE0sIFNoYXJtYSwgU2hhc2hhbmsgd3JvdGU6Cj4KPiBP biA4LzI4LzIwMTkgMTI6NDAgQU0sIEFuaW1lc2ggTWFubmEgd3JvdGU6Cj4+IERTQiBzdXBwb3J0 IHNpbmdsZSByZWdpc3RlciB3cml0ZSB0aHJvdWdoIG9wY29kZSAweDEuIEdlbmVyaWMKPj4gYXBp IGNyZWF0ZWQgd2hpY2ggYWNjdW11bGF0ZSBhbGwgc2luZ2xlIHJlZ2lzdGVyIHdyaXRlIGluIGEg YmF0Y2gKPj4gYnVmZmVyIGFuZCBvbmNlIERTQiBpcyB0cmlnZ2VyZWQsIGl0IHdpbGwgcHJvZ3Jh bSBhbGwgdGhlIHJlZ2lzdGVycwo+PiBhdCB0aGUgc2FtZSB0aW1lLgo+Pgo+PiBDYzogSmFuaSBO aWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmln by52aXZpQGludGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogQW5pbWVzaCBNYW5uYSA8YW5pbWVz aC5tYW5uYUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3Bs YXkvaW50ZWxfZHNiLmMgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysKPj4gICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5oIHwgIDkgKysrKysrCj4+ICAgMiBmaWxl cyBjaGFuZ2VkLCA0NSBpbnNlcnRpb25zKCspCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5jIAo+PiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2Rpc3BsYXkvaW50ZWxfZHNiLmMKPj4gaW5kZXggYTI4NDVkZjkwNTczLi5kZjI4ODQ0NmNhZWIg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmMK Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuYwo+PiBAQCAt OSw2ICs5LDIwIEBACj4+ICAgICAjZGVmaW5lIERTQl9CVUZfU0laRSAgICAoMiAqIFBBR0VfU0la RSkKPj4gICArLyogRFNCIG9wY29kZXMuICovCj4+ICsjZGVmaW5lIERTQl9PUENPREVfU0hJRlQg ICAgICAgIDI0Cj4+ICsjZGVmaW5lIERTQl9PUENPREVfTk9PUCAgICAgICAgICAgIDB4MAo+PiAr I2RlZmluZSBEU0JfT1BDT0RFX01NSU9fV1JJVEUgICAgICAgIDB4MQo+PiArI2RlZmluZSBEU0Jf T1BDT0RFX1dBSVRfRk9SX1VTICAgICAgICAweDIKPj4gKyNkZWZpbmUgRFNCX09QQ09ERV9XQUlU X0ZPUl9MSU5FUyAgICAweDMKPj4gKyNkZWZpbmUgRFNCX09QQ09ERV9XQUlUX0ZPUl9WQkxBTksg ICAgMHg0Cj4+ICsjZGVmaW5lIERTQl9PUENPREVfV0FJVF9GT1JfU0xfSU4gICAgMHg1Cj4gTWF5 IGJlIFNMX0lSICh0byBpbmRpY2F0ZSBpbiByYW5nZSkKPj4gKyNkZWZpbmUgRFNCX09QQ09ERV9X QUlUX0ZPUl9TTF9PVVQgICAgMHg2Cj4gTWF5IGJlIFNMX09PUiAob3V0IG9mIHJhbmdlKSBvciBf T1IKPj4gKyNkZWZpbmUgRFNCX09QQ09ERV9HRU5FUkFURV9JTlQgMHg3Cj4+ICsjZGVmaW5lIERT Ql9PUENPREVfSU5ERVhFRF9XUklURSAgICAweDkKPj4gKyNkZWZpbmUgRFNCX09QQ09ERV9QT0xM ICAgICAgICAgICAgMHhBCj4+ICsjZGVmaW5lIERTQl9CWVRFX0VOICAgICAgICAgICAgKDB4ZiA8 PCAyMCkKPgo+IEJ1dCBpdHMgYSBuaXRwaWNrIGJ1dCBhcyB3ZSBhcmUgZ29pbmcgYnkgc2hpZnRz IGZvciBPUENPREUsIG1heSBiZSAKPiB3b3VsZCBsb29rIGNvbnNpc3RlbnQgdG8gY3JlYXRlIDIg ZGlmZmVyZW50IG1hY3JvcyBmb3IgZW5hYmxlIGFsc28uCj4KPiAjZGVmaW5lIERTQl9CWVRFX0VO ICAgICAgICAgICAgMHhGCj4KPiAjZGVmaW5lIERTQl9CWVRFX0VOX1NISUZUICAgICAgICAyMAoK T2suCgo+Cj4KPj4gKwo+Cj4gVGhpcyBwYXRjaCBpcyB1c2luZyBvbmx5IDMgb2YgdGhlIGRlZmlu ZWQgY29tbWFuZHM6IAo+IERTQl9PUENPREVfTU1JT19XUklURSwgRFNCX09QQ09ERV9TSElGVCwg RFNCX0JZVEVfRU4KPgo+IEFsbCBvdGhlciBkZWZpbml0aW9ucyBhcmUgdW51c2VkLiBQbGVhc2Ug YWRkIHRoZW0gb25seSBpbiB0aGUgcGF0Y2ggCj4gd2hlcmUgdGhleSBhcmUgYmVpbmcgdXNlZC4K Ck9rLgoKPgo+PiAgIHN0cnVjdCBpbnRlbF9kc2IgKgo+PiAgIGludGVsX2RzYl9nZXQoc3RydWN0 IGludGVsX2NydGMgKmNydGMpCj4+ICAgewo+PiBAQCAtODEsMyArOTUsMjUgQEAgdm9pZCBpbnRl bF9kc2JfcHV0KHN0cnVjdCBpbnRlbF9kc2IgKmRzYikKPj4gICAgICAgICAgIG11dGV4X3VubG9j aygmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4+ICAgICAgIH0KPj4gICB9Cj4+ICsKPj4gK3Zv aWQgaW50ZWxfZHNiX3JlZ193cml0ZShzdHJ1Y3QgaW50ZWxfZHNiICpkc2IsIGk5MTVfcmVnX3Qg cmVnLCB1MzIgCj4+IHZhbCkKPj4gK3sKPj4gKyAgICBzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9 IGRzYi0+Y3J0YzsKPj4gKyAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0 b19pOTE1KGNydGMtPmJhc2UuZGV2KTsKPj4gKyAgICB1MzIgKmJ1ZiA9IGRzYi0+Y21kX2J1ZjsK Pj4gKwo+IERvIHdlIG5lZWQgYSBIQVNfRFNCKCkgY2hlY2sgaGVyZSA/IE9yIHdvdWxkIGl0IGJl IHRha2VuIGNhcmUgaW4gdGhlIAo+IGNhbGxlciA/CgpBZnRlciBwYXNzaW5nIGZyb20gSEFTX0RT QigpIGNoZWNrIHdpbGwgZ2V0IHRoZSBkc2ItPmNtZF9idWYsIHNvIGhhdmluZyAKbm9uLW51bGwg Y21kX2J1ZiBpbXBsaWVzIEhBU19EU0IgaXMgcGFzc2VkLgoKPj4gKyAgICBpZiAoIWJ1Zikgewo+ PiArICAgICAgICBJOTE1X1dSSVRFKHJlZywgdmFsKTsKPgo+IFdlIGNhbiBkZWJhdGUgb24gaWYg dGhpcyBpcyBhIGdvb2QgaWRlYSB0byBmYWxsYmFjayB0byBJOTE1X3dyaXRlKCkgaWYgCj4gRFNC IGlzIG5vdCBhdmFpbGFibGUuIE1heSBiZSB3ZSBzaG91bGQgdGhpbmsgYWJvdXQgd2h5IGFyZSB3 ZSBzZWVpbmcgCj4gdGhpcyBjb25kaXRpb24gKCFidWYpLCBhbmQgdGhhdCBjYW4gYmUgY2hlY2tl ZCBvbmx5IHdoZW4gSSBzZWUgdGhlIAo+IGNhbGxlci4KPgo+IEZvciBub3csIGxldHMgYXNzdW1l IHdlIHdpbGwgZmFsbGJhY2sgdG8gSTkxNV9XUklURSgpOwoKSGF2aW5nICghYnVmKSBjaGVjayB3 aWxsIGhlbHAgdG8gaWRlbnRpZnkgcGxhdGZvcm0gd2hpY2ggYXJlIG5vdCBoYXZpbmcgCkRTQiBz dXBwb3J0LgpBcyBwZXIgYWdyZWVkIGRlc2lnbiB3aXRoIEphbmkgd2Ugd2FudCB0byByZXBsYWNl IEk5MTVfV1JJVEUgd2l0aCAKZHNwLXdyaXRlIGFwaSBmb3IgYWxsIHBsYXRmb3JtIGFuZCBmb3Ig b2xkZXIgcGxhdGZvcm0gd2lsbCBmYWxsYmFjayB0byAKaTkxNV9XUklURSBjYWxsLgoKPgo+PiAr ICAgICAgICByZXR1cm47Cj4+ICsgICAgfQo+PiArCj4+ICsgICAgaWYgKFdBUk5fT04oZHNiLT5m cmVlX3BvcyA+PSBEU0JfQlVGX1NJWkUpKSB7Cj4+ICsgICAgICAgIERSTV9ERUJVR19LTVMoIkRT QiBidWZmZXIgb3ZlcmZsb3cuXG4iKTsKPiBXb3VsZG4ndCBpdCBtYWtlIHNlbnNlIHRvIGRvIGEg STkxNV9XUklURShyZWcsIHZhbCkgaGVyZSBhbHNvLCBsaWtlIAo+IGFib3ZlID8KCldhbnRlZCB0 byBiZSBjYXB0dXJlIHRoaXMgZXJyb3IgYW5kIGRvbid0IHdhbnQgdG8gcGFzcyB0aHJvdWdoIGZh bGxiYWNrIAptZWNoYW5pc20uCkJhc2VkIG9uIG5lZWQgd2lsbCBmaW5lIHR1bmUgRFNCIGJ1ZmZl ciBzaXplIGluIGZ1dHVyZSBpZiBuZWVkZWQuCgo+Cj4+ICsgICAgICAgIHJldHVybjsKPj4gKyAg ICB9Cj4+ICsKPj4gKyAgICBidWZbZHNiLT5mcmVlX3BvcysrXSA9IHZhbDsKPj4gKyAgICBidWZb ZHNiLT5mcmVlX3BvcysrXSA9IChEU0JfT1BDT0RFX01NSU9fV1JJVEUgIDw8Cj4+ICsgICAgICAg ICAgICAgICAgRFNCX09QQ09ERV9TSElGVCkgfCBEU0JfQllURV9FTiB8Cj4+ICsgICAgICAgICAg ICAgICAgaTkxNV9tbWlvX3JlZ19vZmZzZXQocmVnKTsKPiBPbmNlIHRoZSB3cml0ZSBpcyBkb25l LCBhcmUgd2UgcGxhbm5pbmcgdG8gcmVzZXQgdGhpcyBmcmVlX3BvcyA/IE1heSAKPiBiZSBpbiBz b21lIHVwY29taW5nIHBhdGNoIGluIHRoZSBzZXJpZXMgPwoKWWVzLCBhZnRlciBjb21taXQgd2ls bCBiZSBkb25lLgoKUmVnYXJkcywKQW5pbWVzaAoKPj4gK30KPj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmggCj4+IGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuaAo+PiBpbmRleCA0YTQwOTFjYWRjMWUuLjFiMzNhYjEx ODY0MCAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9k c2IuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5oCj4+ IEBAIC02LDYgKzYsOCBAQAo+PiAgICNpZm5kZWYgX0lOVEVMX0RTQl9ICj4+ICAgI2RlZmluZSBf SU5URUxfRFNCX0gKPj4gICArI2luY2x1ZGUgImk5MTVfcmVnLmgiCj4+ICsKPj4gICBzdHJ1Y3Qg aW50ZWxfY3J0YzsKPj4gICBzdHJ1Y3QgaTkxNV92bWE7Cj4+ICAgQEAgLTIyLDEwICsyNCwxNyBA QCBzdHJ1Y3QgaW50ZWxfZHNiIHsKPj4gICAgICAgZW51bSBkc2JfaWQgaWQ7Cj4+ICAgICAgIHUz MiAqY21kX2J1ZjsKPj4gICAgICAgc3RydWN0IGk5MTVfdm1hICp2bWE7Cj4+ICsKPj4gKyAgICAv Kgo+PiArICAgICAqIGZyZWVfcG9zIHdpbGwgcG9pbnQgdGhlIGZpcnN0IGZyZWUgZW50cnkgcG9z aXRpb24KPj4gKyAgICAgKiBhbmQgaGVscCBpbiBjYWxjdWxhdGluZyBjbWRfYnVmX3RhaWwuCj4+ ICsgICAgICovCj4+ICsgICAgaW50IGZyZWVfcG9zOwo+PiAgIH07Cj4+ICAgICBzdHJ1Y3QgaW50 ZWxfZHNiICoKPj4gICBpbnRlbF9kc2JfZ2V0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKTsKPj4g ICB2b2lkIGludGVsX2RzYl9wdXQoc3RydWN0IGludGVsX2RzYiAqZHNiKTsKPj4gK3ZvaWQgaW50 ZWxfZHNiX3JlZ193cml0ZShzdHJ1Y3QgaW50ZWxfZHNiICpkc2IsIGk5MTVfcmVnX3QgcmVnLCB1 MzIgCj4+IHZhbCk7Cj4+ICAgICAjZW5kaWYKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeA==