From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 12/13] drm/i915: Bump signaler priority on adding a waiter Date: Tue, 7 May 2019 15:32:49 +0100 Message-ID: <809ae6a3-54df-aec4-9e05-555401ba3170@linux.intel.com> References: <20190503115225.30831-1-chris@chris-wilson.co.uk> <20190503115225.30831-12-chris@chris-wilson.co.uk> <602e3ddb-cd81-06f3-b6b0-2581b4199dcf@linux.intel.com> <155723484120.2489.9311580428082688600@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 08F7789E08 for ; Tue, 7 May 2019 14:32:53 +0000 (UTC) In-Reply-To: <155723484120.2489.9311580428082688600@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzA1LzIwMTkgMTQ6MTQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA1LTA3IDEzOjQ2OjQ1KQo+Pgo+PiBPbiAwMy8wNS8yMDE5IDEyOjUy LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBUaGUgaGFuZGxpbmcgb2YgdGhlIG5vLXByZWVtcHRp b24gcHJpb3JpdHkgbGV2ZWwgaW1wb3NlcyB0aGUgcmVzdHJpY3Rpb24KPj4+IHRoYXQgd2UgbmVl ZCB0byBtYWludGFpbiB0aGUgaW1wbGllZCBvcmRlcmluZyBldmVuIHRob3VnaCBwcmVlbXB0aW9u IGlzCj4+PiBkaXNhYmxlZC4gT3RoZXJ3aXNlIHdlIG1heSBlbmQgdXAgd2l0aCBhbiBBQi1CQSBk ZWFkbG9jayBhY3Jvc3MgbXVsdGlwbGUKPj4+IGVuZ2luZSBkdWUgdG8gYSByZWFsIHByZWVtcHRp b24gZXZlbnQgcmVvcmRlcmluZyB0aGUgbm8tcHJlZW1wdGlvbgo+Pj4gV0FJVHMuIFRvIHJlc29s dmUgdGhpcyBpc3N1ZSB3ZSBjdXJyZW50bHkgcHJvbW90ZSBhbGwgcmVxdWVzdHMgdG8gV0FJVAo+ Pj4gb24gdW5zdWJtaXNzaW9uLCBob3dldmVyIHRoaXMgaW50ZXJmZXJlcyB3aXRoIHRoZSB0aW1l c2xpY2luZwo+Pj4gcmVxdWlyZW1lbnQgdGhhdCB3ZSBkbyBub3QgYXBwbHkgYW55IGltcGxpY2l0 IHByb21vdGlvbiB0aGF0IHdpbGwgZGVmZWF0Cj4+PiB0aGUgcm91bmQtcm9iaW4gdGltZXNsaWNl IGxpc3QuIChJZiB3ZSBhdXRvbWF0aWNhbGx5IHByb21vdGUgdGhlIGFjdGl2ZQo+Pj4gcmVxdWVz dCBpdCB3aWxsIGdvIGJhY2sgdG8gdGhlIGhlYWQgb2YgdGhlIHF1ZXVlIGFuZCBub3QgdGhlIHRh aWwhKQo+Pj4KPj4+IFNvIHdlIG5lZWQgaW1wbGljaXQgcHJvbW90aW9uIHRvIHByZXZlbnQgcmVv cmRlcmluZyBhcm91bmQgc2VtYXBob3Jlcwo+Pj4gd2hlcmUgd2UgYXJlIG5vdCBhbGxvd2VkIHRv IHByZWVtcHQsIGFuZCB3ZSBtdXN0IGF2b2lkIGltcGxpY2l0Cj4+PiBwcm9tb3Rpb24gb24gdW5z dWJtaXNzaW9uLiBTbyBpbnN0ZWFkIG9mIGF0IHVuc3VibWl0LCBpZiB3ZSBhcHBseSB0aGF0Cj4+ PiBpbXBsaWNpdCBwcm9tb3Rpb24gb24gYWRkaW5nIHRoZSBkZXBlbmRlbmN5LCB3ZSBhdm9pZCB0 aGUgc2VtYXBob3JlCj4+PiBkZWFkbG9jayBhbmQgd2UgYWxzbyByZWR1Y2UgdGhlIGdhaW5zIG1h ZGUgYnkgdGhlIHByb21vdGlvbiBmb3IgdXNlcgo+Pj4gc3BhY2Ugd2FpdGluZy4gRnVydGhlcm1v cmUsIGJ5IGtlZXBpbmcgdGhlIGVhcmxpZXIgZGVwZW5kZW5jaWVzIGF0IGEKPj4+IGhpZ2hlciBs ZXZlbCwgd2UgcmVkdWNlIHRoZSBzZWFyY2ggc3BhY2UgZm9yIHRpbWVzbGljaW5nIHdpdGhvdXQK Pj4+IGFsdGVyaW5nIHJ1bnRpbWUgc2NoZWR1bGluZyB0b28gYmFkbHkgKG5vIGRlcGVuZGVuY2ll cyBhdCBhbGwgd2lsbCBiZQo+Pj4gYXNzaWduZWQgYSBoaWdoZXIgcHJpb3JpdHkgZm9yIHJydWwp Lgo+Pj4KPj4+IHYyOiBMaW1pdCB0aGUgYnVtcCB0byBleHRlcm5hbCBlZGdlcyAoYXMgb3JpZ2lu YWxseSBpbnRlbmRlZCkgaS5lLgo+Pj4gYmV0d2VlbiBjb250ZXh0cyBhbmQgb3V0IHRvIHRoZSB1 c2VyLgo+Pj4KPj4+IFRlc3RjYXNlOiBpZ3QvZ2VtX2NvbmN1cnJlbnRfYmxpdAo+Pj4gU2lnbmVk LW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiAtLS0K Pj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L3NlbGZ0ZXN0X2xyYy5jICAgICAgfCAxMiAr KysrKysrKy0tLS0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jICAg ICAgICAgfCAgOSAtLS0tLS0tLS0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc2No ZWR1bGVyLmMgICAgICAgfCAxMSArKysrKysrKysrKwo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9zY2hlZHVsZXJfdHlwZXMuaCB8ICAzICsrLQo+Pj4gICAgNCBmaWxlcyBjaGFuZ2Vk LCAyMSBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Qvc2VsZnRlc3RfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9ndC9zZWxmdGVzdF9scmMuYwo+Pj4gaW5kZXggNGIwNDI4OTNkYzBlLi41YjNkOGUzM2Yx Y2YgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9zZWxmdGVzdF9scmMu Ywo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Qvc2VsZnRlc3RfbHJjLmMKPj4+IEBA IC05OCwxMiArOTgsMTQgQEAgc3RhdGljIGludCBsaXZlX2J1c3l3YWl0X3ByZWVtcHQodm9pZCAq YXJnKQo+Pj4gICAgICAgIGN0eF9oaSA9IGtlcm5lbF9jb250ZXh0KGk5MTUpOwo+Pj4gICAgICAg IGlmICghY3R4X2hpKQo+Pj4gICAgICAgICAgICAgICAgZ290byBlcnJfdW5sb2NrOwo+Pj4gLSAg ICAgY3R4X2hpLT5zY2hlZC5wcmlvcml0eSA9IElOVF9NQVg7Cj4+PiArICAgICBjdHhfaGktPnNj aGVkLnByaW9yaXR5ID0KPj4+ICsgICAgICAgICAgICAgSTkxNV9VU0VSX1BSSU9SSVRZKEk5MTVf Q09OVEVYVF9NQVhfVVNFUl9QUklPUklUWSk7Cj4+PiAgICAKPj4+ICAgICAgICBjdHhfbG8gPSBr ZXJuZWxfY29udGV4dChpOTE1KTsKPj4+ICAgICAgICBpZiAoIWN0eF9sbykKPj4+ICAgICAgICAg ICAgICAgIGdvdG8gZXJyX2N0eF9oaTsKPj4+IC0gICAgIGN0eF9sby0+c2NoZWQucHJpb3JpdHkg PSBJTlRfTUlOOwo+Pj4gKyAgICAgY3R4X2xvLT5zY2hlZC5wcmlvcml0eSA9Cj4+PiArICAgICAg ICAgICAgIEk5MTVfVVNFUl9QUklPUklUWShJOTE1X0NPTlRFWFRfTUlOX1VTRVJfUFJJT1JJVFkp Owo+Pj4gICAgCj4+PiAgICAgICAgb2JqID0gaTkxNV9nZW1fb2JqZWN0X2NyZWF0ZV9pbnRlcm5h bChpOTE1LCBQQUdFX1NJWkUpOwo+Pj4gICAgICAgIGlmIChJU19FUlIob2JqKSkgewo+Pj4gQEAg LTk1OCwxMiArOTYwLDE0IEBAIHN0YXRpYyBpbnQgbGl2ZV9wcmVlbXB0X2hhbmcodm9pZCAqYXJn KQo+Pj4gICAgICAgIGN0eF9oaSA9IGtlcm5lbF9jb250ZXh0KGk5MTUpOwo+Pj4gICAgICAgIGlm ICghY3R4X2hpKQo+Pj4gICAgICAgICAgICAgICAgZ290byBlcnJfc3Bpbl9sbzsKPj4+IC0gICAg IGN0eF9oaS0+c2NoZWQucHJpb3JpdHkgPSBJOTE1X0NPTlRFWFRfTUFYX1VTRVJfUFJJT1JJVFk7 Cj4+PiArICAgICBjdHhfaGktPnNjaGVkLnByaW9yaXR5ID0KPj4+ICsgICAgICAgICAgICAgSTkx NV9VU0VSX1BSSU9SSVRZKEk5MTVfQ09OVEVYVF9NQVhfVVNFUl9QUklPUklUWSk7Cj4+PiAgICAK Pj4+ICAgICAgICBjdHhfbG8gPSBrZXJuZWxfY29udGV4dChpOTE1KTsKPj4+ICAgICAgICBpZiAo IWN0eF9sbykKPj4+ICAgICAgICAgICAgICAgIGdvdG8gZXJyX2N0eF9oaTsKPj4+IC0gICAgIGN0 eF9sby0+c2NoZWQucHJpb3JpdHkgPSBJOTE1X0NPTlRFWFRfTUlOX1VTRVJfUFJJT1JJVFk7Cj4+ PiArICAgICBjdHhfbG8tPnNjaGVkLnByaW9yaXR5ID0KPj4+ICsgICAgICAgICAgICAgSTkxNV9V U0VSX1BSSU9SSVRZKEk5MTVfQ09OVEVYVF9NSU5fVVNFUl9QUklPUklUWSk7Cj4+PiAgICAKPj4+ ICAgICAgICBmb3JfZWFjaF9lbmdpbmUoZW5naW5lLCBpOTE1LCBpZCkgewo+Pj4gICAgICAgICAg ICAgICAgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnE7Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl cXVlc3QuYwo+Pj4gaW5kZXggOGNiM2VkNTUzMWUzLi4wNjVkYTFiY2JiNGMgMTAwNjQ0Cj4+PiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYwo+Pj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMKPj4+IEBAIC00NjgsMTUgKzQ2OCw2IEBAIHZv aWQgX19pOTE1X3JlcXVlc3RfdW5zdWJtaXQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcmVxdWVzdCkK Pj4+ICAgICAgICAvKiBXZSBtYXkgYmUgcmVjdXJzaW5nIGZyb20gdGhlIHNpZ25hbCBjYWxsYmFj ayBvZiBhbm90aGVyIGk5MTUgZmVuY2UgKi8KPj4+ICAgICAgICBzcGluX2xvY2tfbmVzdGVkKCZy ZXF1ZXN0LT5sb2NrLCBTSU5HTEVfREVQVEhfTkVTVElORyk7Cj4+PiAgICAKPj4+IC0gICAgIC8q Cj4+PiAtICAgICAgKiBBcyB3ZSBkbyBub3QgYWxsb3cgV0FJVCB0byBwcmVlbXB0IGluZmxpZ2h0 IHJlcXVlc3RzLAo+Pj4gLSAgICAgICogb25jZSB3ZSBoYXZlIGV4ZWN1dGVkIGEgcmVxdWVzdCwg YWxvbmcgd2l0aCB0cmlnZ2VyaW5nCj4+PiAtICAgICAgKiBhbnkgZXhlY3V0aW9uIGNhbGxiYWNr cywgd2UgbXVzdCBwcmVzZXJ2ZSBpdHMgb3JkZXJpbmcKPj4+IC0gICAgICAqIHdpdGhpbiB0aGUg bm9uLXByZWVtcHRpYmxlIEZJRk8uCj4+PiAtICAgICAgKi8KPj4+IC0gICAgIEJVSUxEX0JVR19P TihfX05PX1BSRUVNUFRJT04gJiB+STkxNV9QUklPUklUWV9NQVNLKTsgLyogb25seSBpbnRlcm5h bCAqLwo+Pj4gLSAgICAgcmVxdWVzdC0+c2NoZWQuYXR0ci5wcmlvcml0eSB8PSBfX05PX1BSRUVN UFRJT047Cj4+PiAtCj4+PiAgICAgICAgaWYgKHRlc3RfYml0KERNQV9GRU5DRV9GTEFHX0VOQUJM RV9TSUdOQUxfQklULCAmcmVxdWVzdC0+ZmVuY2UuZmxhZ3MpKQo+Pj4gICAgICAgICAgICAgICAg aTkxNV9yZXF1ZXN0X2NhbmNlbF9icmVhZGNydW1iKHJlcXVlc3QpOwo+Pj4gICAgCj4+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zY2hlZHVsZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfc2NoZWR1bGVyLmMKPj4+IGluZGV4IDM4MGNiNzM0M2ExMC4uZmYw Y2E1NzE4Zjk3IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zY2hl ZHVsZXIuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zY2hlZHVsZXIuYwo+ Pj4gQEAgLTM5MSw2ICszOTEsMTYgQEAgYm9vbCBfX2k5MTVfc2NoZWRfbm9kZV9hZGRfZGVwZW5k ZW5jeShzdHJ1Y3QgaTkxNV9zY2hlZF9ub2RlICpub2RlLAo+Pj4gICAgICAgICAgICAgICAgICAg ICFub2RlX3N0YXJ0ZWQoc2lnbmFsKSkKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgbm9kZS0+ ZmxhZ3MgfD0gSTkxNV9TQ0hFRF9IQVNfU0VNQVBIT1JFX0NIQUlOOwo+Pj4gICAgCj4+PiArICAg ICAgICAgICAgIC8qCj4+PiArICAgICAgICAgICAgICAqIEFzIHdlIGRvIG5vdCBhbGxvdyBXQUlU IHRvIHByZWVtcHQgaW5mbGlnaHQgcmVxdWVzdHMsCj4+PiArICAgICAgICAgICAgICAqIG9uY2Ug d2UgaGF2ZSBleGVjdXRlZCBhIHJlcXVlc3QsIGFsb25nIHdpdGggdHJpZ2dlcmluZwo+Pj4gKyAg ICAgICAgICAgICAgKiBhbnkgZXhlY3V0aW9uIGNhbGxiYWNrcywgd2UgbXVzdCBwcmVzZXJ2ZSBp dHMgb3JkZXJpbmcKPj4+ICsgICAgICAgICAgICAgICogd2l0aGluIHRoZSBub24tcHJlZW1wdGli bGUgRklGTy4KPj4+ICsgICAgICAgICAgICAgICovCj4+PiArICAgICAgICAgICAgIEJVSUxEX0JV R19PTihfX05PX1BSRUVNUFRJT04gJiB+STkxNV9QUklPUklUWV9NQVNLKTsKPj4+ICsgICAgICAg ICAgICAgaWYgKGZsYWdzICYgSTkxNV9ERVBFTkRFTkNZX0VYVEVSTkFMKQo+Pj4gKyAgICAgICAg ICAgICAgICAgICAgIF9fYnVtcF9wcmlvcml0eShzaWduYWwsIF9fTk9fUFJFRU1QVElPTik7Cj4+ PiArCj4+Cj4+IEkgZG9uJ3QgcmVhbGx5IGZvbGxvdyBob3cgY2FuIHRoaXMgYmUgb2theSBmcm9t IGhlcmUuIEl0IGdpdmVzIHdhaXQKPj4gcHJpb3JpdHkgdG8gZXZlcnkgcmVxdWVzdCB3aGljaCBo YXMgYSBkZXBlbmRlbmN5IG5vdy4gV2hpY2ggc291bmRzIG5vdAo+PiBmYXIgb2ZmIGZyb20gcmVt b3ZpbmcgdGhlIHByaW9yaXR5IGJ1bXAgZm9yIHdhaXRlcnMgYWx0b2dldGhlci4gT3IKPj4gcmV2 ZXJzaW5nIHRoaW5ncyBhbmQgZ2l2aW5nIHJlcXVlc3RzIHdpdGggbm8gcHJpb3JpdHkgYSBib29z dC4KPiAKPiBJdCB0cmVhdHMgZXZlbiBpbnRlci1jb250ZXh0IHdhaXQgZXF1YWxseSwgYW5kIHNv IHJlZHVjZXMgdGhlIGVmZmVjdCBvZgo+IHRoZSB1c2VyIHdhaXQgZnJvbSB0aGUgd2FpdC9zZXQt ZG9tYWluIGlvY3RsIGFuZCBpbnN0ZWFkIGluY2x1ZGVzIGFsbAo+IHRoZSB3YWl0cyB0aGV5IHN1 cHBseSBkdXJpbmcgZXhlY2J1Zi4KPiAKPiBJdCBhbGwgc3RlbXMgZnJvbSB0aGUgd2F5IHRob3Nl IHByaW9yaXRpZXMgYXJlIGlnbm9yZWQgZm9yIHByZWVtcHRpb24uCj4gQ3VycmVudGx5IHdlIHBl cmZvcm0gdGhlIHNhbWUgYm9vc3QgaW1wbGljaXRseSB0byBhbGwgcnVubmluZyByZXF1ZXN0cywK PiB3aGljaCBzY3Jld3MgdXAgdGltZXNsaWNpbmcsIHNvIGluc3RlYWQgb2YgZG9pbmcgaXQgb24g dGhlIHJ1bm5pbmcKPiByZXF1ZXN0IHdlIGFwcGx5IGl0IHRvIHRoZSBxdWV1ZSBhbmQgbGltaXQg aXQgdG8ganVzdCB0aGUgZWRnZXMgdGhhdCBhcmUKPiBzdXNjZXB0aWJsZSB0byBkZWFkbG9ja3Mg KHNvIGluIGVmZmVjdCB3ZSBhcmUgcmVkdWNpbmcgdGhlIG51bWJlciBvZgo+IHJlcXVlc3RzIHRo YXQgaGF2ZSB0aGUgaW1wbGljaXQgYm9vc3QpLgoKSSBkb24ndCByZWFsbHkgdW5kZXJzdGFuZCB3 aHkgcHJpb3JpdHkgYnVtcCBvbiB1bnN1Ym1pdCB3b3VsZCBzY3JldyB1cCAKdGltZXNsaWNpbmcu IFdvdWxkIG1vcmUgdGhvcm91Z2ggdGltZS1zbGljaW5nIHNjaGVkdWxlciBoZWxwIHRoZXJlPyBG b3IgCmluc3RhbmNlLCBwcmlvIGJ1bXAgb24gdW5zdWJtaXQgc291bmRzIGxpa2Ugc29tZXRoaW5n IHNjaGVkdWxlciBub3JtYWxseSAKZG8gdG8gcHJldmVudCBzdGFydmF0aW9uLiBTbyBmdW5kYW1l bnRhbGx5IGNvbmNlcHQgc291bmRzIHNhbmUuIFBlcmhhcHMgCnRoZSBpc3N1ZSBpcyBqdXN0IHNv bWUgaW1wbGVtZW50YXRpb24gZGV0YWlscy4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4