From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EB9CC433EF for ; Fri, 5 Nov 2021 09:57:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E624F601FC for ; Fri, 5 Nov 2021 09:57:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E624F601FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4C7B56E0DE; Fri, 5 Nov 2021 09:57:04 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D37366E106 for ; Fri, 5 Nov 2021 09:57:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636106222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oZ67s9sbnfsD5fqdtGG0nGBmSdAaIG5RWNWBFufx9E8=; b=W7IGsDQVC0RYBsafcKMVArUW0bQ6fSy44WFpJVO4U3eUdy0fzoK8YaahUEM2FoQkhdo4ID qhu/wJIkObICBKmNQkfIVOqd/ZxHqYiEHkmTdn3CU4DvlqSB0fv7WUQrWE4Mj4uKoUD8mi AoMpAaeyxxBcn2QQG3ETdgQpoMTtlp8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-4-G8MSWnWcO4GrwQ9lEgAbzQ-1; Fri, 05 Nov 2021 05:55:43 -0400 X-MC-Unique: G8MSWnWcO4GrwQ9lEgAbzQ-1 Received: by mail-wr1-f70.google.com with SMTP id p3-20020a056000018300b00186b195d4ddso2129322wrx.15 for ; Fri, 05 Nov 2021 02:55:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=oZ67s9sbnfsD5fqdtGG0nGBmSdAaIG5RWNWBFufx9E8=; b=iQ3i2ym+NZWx3ySPGw/2Rq8JmgFiDm8sdO3egkobhLcHuzTkjFVADj8XLedst5Rxbn mpKPmSv5N+RZ4vKJXHIjFDnXA3dg/jWRNQ02mvGSV0ptyQCDsQlurvGtU8wEngZAy7k4 xFlOl54X6jTj9/eSyhRQT4/bBqpg2PpFgZanwsNSCQ6bfNdq24QmsGHR8yyhz8+jOr0/ xWcFKZEokeb6VQODVIrQCaGigF4fL389Z/4oE6+wb3MU0B4KO6LVYkTIejK8YD6i2shi HOjQKUsQRoQNpF08S6c+htLonqmhYU+7pxq0PgQwlHrASGsZjJxCjTB8dtB1o8lnoZyB aPsA== X-Gm-Message-State: AOAM533ba/adR2XZoVqEBqz5zNM+nMxxaEyoUNHAAzoHWF5jQ0NzPSl9 gkNmTfSoPF4k3uLC9/h/cMVPNwXHPVNaUZJ0/V1qmVaW7GR/XyinDyqdU8f81fgGYR3r3bDPuNL agDwkGhe3KubzoY2UakpSprZRKrBk X-Received: by 2002:a7b:c8d5:: with SMTP id f21mr27635773wml.146.1636106142131; Fri, 05 Nov 2021 02:55:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyT8viACi1U7JY5S3rkG/MaHma60ZlmQ0NQODpS8eTcPcWv9ZvZPYhizNzNYarjDaHcIaJjnA== X-Received: by 2002:a7b:c8d5:: with SMTP id f21mr27635740wml.146.1636106141897; Fri, 05 Nov 2021 02:55:41 -0700 (PDT) Received: from [192.168.1.128] ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id s26sm5390804wmc.0.2021.11.05.02.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 02:55:41 -0700 (PDT) Message-ID: <847c2315-b4a2-3bd1-e048-4263b5f496ed@redhat.com> Date: Fri, 5 Nov 2021 10:55:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: Thomas Zimmermann , linux-kernel@vger.kernel.org References: <20211104160707.1407052-1-javierm@redhat.com> <20211104160707.1407052-3-javierm@redhat.com> From: Javier Martinez Canillas In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Gurchetan Singh , Gerd Hoffmann , amd-gfx@lists.freedesktop.org, VMware Graphics , Peter Robinson , nouveau@lists.freedesktop.org, Dave Airlie , Chia-I Wu , Ben Skeggs , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Maxime Ripard , virtualization@lists.linux-foundation.org, Pekka Paalanen , Greg Kroah-Hartman , "Pan, Xinhui" , spice-devel@lists.freedesktop.org, Alex Deucher , intel-gfx@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= , Zack Rusin Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/5/21 10:00, Thomas Zimmermann wrote: [snip] >> + >> +static int __init disable_modeset(char *str) >> +{ >> + drm_nomodeset = true; >> + >> + pr_warn("You have booted with nomodeset. This means your GPU drivers are DISABLED\n"); >> + pr_warn("Any video related functionality will be severely degraded, and you may not even be able to suspend the system properly\n"); >> + pr_warn("Unless you actually understand what nomodeset does, you should reboot without enabling it\n"); > > I'd update this text to be less sensational. > This is indeed quite sensational. But think we can do it as a follow-up patch. Since we will have to stick with nomodeset for backward compatibility, I was planning to add documentation to explain what this parameter is about and what is the actual effect of setting it. So I think we can change this as a part of that patch-set. >> + >> + return 1; >> +} >> + >> +/* Disable kernel modesetting */ >> +__setup("nomodeset", disable_modeset); >> diff --git a/drivers/gpu/drm/i915/i915_module.c b/drivers/gpu/drm/i915/i915_module.c >> index 45cb3e540eff..c890c1ca20c4 100644 >> --- a/drivers/gpu/drm/i915/i915_module.c >> +++ b/drivers/gpu/drm/i915/i915_module.c >> @@ -4,8 +4,6 @@ >> * Copyright © 2021 Intel Corporation >> */ >> >> -#include >> - > > These changes should be in patch 1? > Yes, I forgot to move these when changed the order of the patches. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat