[intel-gpu-tools][PATCH] Correct identification of the GEN5 chips on the IS_9XX() define

[intel-gpu-tools][PATCH] Correct identification of the GEN5 chips on the IS_9XX() define

[Diego Celix]

[-- Attachment #1.1: Type: text/plain, Size: 1347 bytes --]

Hi,

I've been trying to find the main cause because I got the following error:

Couldn't map MMIO region: No such file or directory

It happens when I execute some of the tools of the package.
I've realized that the mmio_bar was not correctly set (inside the
intel_get_mmio() function).

This patch changes one of the repeated checks for GEN4 in the IS_9XX macro,
to check for GEN5 instead.



>From 62d5a29c9484e989a41f591a403bf9e6c5a8f81e Mon Sep 17 00:00:00 2001
From: Diego Celix <dcelix@gmail.com>
Date: Mon, 14 Feb 2011 15:21:53 +0000
Subject: [PATCH] lib/intel_chipset: GEN5 fix

This fixes the correct identification of the GEN5 chipsets inside the
IS_9XX() #define. Fixes the following error:
Couldn't map MMIO region: No such file or directory
Provided on each call of the intel_get_mmio function.
---
 lib/intel_chipset.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
index 48c441d..754bdd3 100755
--- a/lib/intel_chipset.h
+++ b/lib/intel_chipset.h
@@ -141,7 +141,7 @@

 #define IS_9XX(devid)        (IS_GEN3(devid) || \
                  IS_GEN4(devid) || \
-                 IS_GEN4(devid) || \
+                 IS_GEN5(devid) || \
                  IS_GEN6(devid))

 #define IS_INTEL(devid)        (IS_GEN2(devid) || \
-- 
1.7.3.4



Regards,

-- 
Diego Celix

[-- Attachment #1.2: Type: text/html, Size: 1584 bytes --]

[-- Attachment #2: 0001-lib-intel_chipset-GEN5-fix.patch --]
[-- Type: text/x-patch, Size: 865 bytes --]

From 62d5a29c9484e989a41f591a403bf9e6c5a8f81e Mon Sep 17 00:00:00 2001
From: Diego Celix <dcelix@gmail.com>
Date: Mon, 14 Feb 2011 15:21:53 +0000
Subject: [PATCH] lib/intel_chipset: GEN5 fix

This fixes the correct identification of the GEN5 chipsets inside the
IS_9XX() #define. Fixes the following error:
Couldn't map MMIO region: No such file or directory
Provided on each call of the intel_get_mmio function.
---
 lib/intel_chipset.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
index 48c441d..754bdd3 100755
--- a/lib/intel_chipset.h
+++ b/lib/intel_chipset.h
@@ -141,7 +141,7 @@
 
 #define IS_9XX(devid)		(IS_GEN3(devid) || \
 				 IS_GEN4(devid) || \
-				 IS_GEN4(devid) || \
+				 IS_GEN5(devid) || \
 				 IS_GEN6(devid))
 
 #define IS_INTEL(devid)		(IS_GEN2(devid) || \
-- 
1.7.3.4


[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [intel-gpu-tools][PATCH] Correct identification of the GEN5 chips on the IS_9XX() define

[Chris Wilson]

On Mon, 14 Feb 2011 15:44:51 +0000, Diego Celix <dcelix@gmail.com> wrote:
> Hi,
> 
> I've been trying to find the main cause because I got the following error:
> 
> Couldn't map MMIO region: No such file or directory

Sigh. I wrote that off as another bug, since it was exactly the same
symptom as when changing the caching mode of the registers.

I applied a variant of that patch to remove IS_9XX instead.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre