From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 8/8] drm/i915: only save/restore VGA clock
	regs for non-KMS case
Date: Mon, 21 Mar 2011 09:49:23 +0000
Message-ID: <849307$c2sdhr@azsmga001.ch.intel.com>
References: <1300699639-23996-1-git-send-email-zhenyuw@linux.intel.com>
	<1300699639-23996-9-git-send-email-zhenyuw@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 419DD9E78F
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 21 Mar 2011 02:49:26 -0700 (PDT)
In-Reply-To: <1300699639-23996-9-git-send-email-zhenyuw@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Zhenyu Wang <zhenyuw@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 21 Mar 2011 17:27:19 +0800, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> For KMS we want to disable VGA anyway, do so by using correct setting
> order in i915_disable_vga().

Whilst we are here... Can anybody explain the distinction between those
VGA registers and i915_save_vga()? Might this be a good point to merge
those code blocks and add some comments?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre