Re: [PATCH 8/8] drm/i915: only save/restore VGA clock regs for non-KMS case

Jesse Barnes
2011-03-21T17:49:07Z

On Mon, 21 Mar 2011 09:49:23 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Mon, 21 Mar 2011 17:27:19 +0800, Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> > For KMS we want to disable VGA anyway, do so by using correct setting
> > order in i915_disable_vga().
>
> Whilst we are here... Can anybody explain the distinction between those
> VGA registers and i915_save_vga()? Might this be a good point to merge
> those code blocks and add some comments?

And/or just move this block into the modeset_regs function, since it
already checks for modesetting.

Not sure if the divisor regs are aliases for the CRTC regs or not; the
VGA plane control reg is definitely separate though.

--
Jesse Barnes, Intel Open Source Technology Center