From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: Splitting HAS_PCH_SPLIT code in intel_crtc_mode_set(). Date: Thu, 31 Mar 2011 08:34:45 +0100 Message-ID: <849307$c8epkl@azsmga001.ch.intel.com> References: <1301515270-3768-1-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DFF29E799 for ; Thu, 31 Mar 2011 00:34:49 -0700 (PDT) In-Reply-To: <1301515270-3768-1-git-send-email-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 30 Mar 2011 13:01:01 -0700, Eric Anholt wrote: > In doing new chipset enablement for the first time in quite a while, > it sunk in just how bad the spaghetti in our modeset path was these > days. I think that splitting the crtc_mode_set up a bit gets us a > more readable path for whichever generation you're trying to look at, > while not duplicating too much code -- note that patch 1/9 is +675 > LOC, while after 8/9 we're down to +299 overall. > > To atone for about +300LOC, patch 9/9 does another cleanup I think is > appropriate and cuts almost 300 lines of used-once #define spam. No atonement necessary for cutting through the mountain of spaghetti. I'll throw this onto my collection of boxes and see if anything comes adrift. -Chris -- Chris Wilson, Intel Open Source Technology Centre