From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 6/6] drm/i915: Attach a fb to the load-detect pipe Date: Wed, 20 Apr 2011 19:55:10 +0100 Message-ID: <849307$cj6rpk@azsmga001.ch.intel.com> References: <1303291342-27668-1-git-send-email-chris@chris-wilson.co.uk> <1303291342-27668-7-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id B4F919E74C for ; Wed, 20 Apr 2011 11:55:17 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 20 Apr 2011 11:43:38 -0700, Keith Packard wrote: > On Wed, 20 Apr 2011 10:22:22 +0100, Chris Wilson wrote: > > > For bonus amusement value, we perform the first load detect before even > > establishing our fbdev. > > It seems like we need to be able to perform load detection in this > case to create a suitable frame buffer at boot time. Aye, a classic chicken and egg problem. I wanted to ignore it as everything would have been resized upon the first probe by userspace (hotplug polling being disabled for load-detect paths), but only after the probe completes so there is the issue that the fb may be too small and so we don't prevent all potential PGTBL_ER. And VGA is laso likely to be a boot device. I'll spin up a patch for a temporary buffer and see what you think. -Chris -- Chris Wilson, Intel Open Source Technology Centre