From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 5/5] drm/i915: debugfs interface for forcewake reference count Date: Mon, 25 Apr 2011 20:28:50 +0100 Message-ID: <849307$clgp0b@azsmga001.ch.intel.com> References: <1303343599-18509-6-git-send-email-ben@bwidawsk.net> <1303755956-7056-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E1679E74C for ; Mon, 25 Apr 2011 12:29:18 -0700 (PDT) In-Reply-To: <1303755956-7056-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 25 Apr 2011 11:25:56 -0700, Ben Widawsky wrote: > forcewake is controlled by the open and close of the debugfs file. This > assures that buggy applications cannot cause the GT to stay on forever. I pushed them out to drm-intel-staging for wider testing. I'm not sure that this last past merits being applied to the stable kernel (as this does little to prevent root from breaking his machine anyway and so will probably just suggest applying to -next instead) but the earlier patches lead up to the important bug fixes where we were not holding the required mutex. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre