From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 11/24] drm: Introduce an iterator over holes in the drm_mm range manager Date: Fri, 26 Oct 2012 11:55:49 +0100 Message-ID: <84c8a8$69bmrm@orsmga001.jf.intel.com> References: <1346340679-7699-1-git-send-email-chris@chris-wilson.co.uk> <1346340679-7699-12-git-send-email-chris@chris-wilson.co.uk> <20121025192225.GE5691@phenom.ffwll.local> <20121025135442.4d1b0850@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id B9C99A0C4C for ; Fri, 26 Oct 2012 03:56:24 -0700 (PDT) In-Reply-To: <20121025135442.4d1b0850@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky , Daniel Vetter Cc: Dave Airlie , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 25 Oct 2012 13:54:42 -0700, Ben Widawsky wrote: > On Thu, 25 Oct 2012 21:22:25 +0200 > Daniel Vetter wrote: > > > On Thu, Aug 30, 2012 at 04:31:06PM +0100, Chris Wilson wrote: > > > This will be used i915 in forthcoming patches in order to measure the > > > largest contiguous chunk of memory available for enabling chipset > > > features. > > > > > > Signed-off-by: Chris Wilson > > > Cc: Dave Airlie > > > > While discussing the iterator in private a bit with Ben I've noticed that > > you've ignore my bikeshed! tsk ... ;-) > > > > http://lists.freedesktop.org/archives/intel-gfx/2012-September/020436.html > > > > -Daniel > > While the macro is undeniably horendous to read, I think Daniel's > suggestion makes it slightly better simply for reading. That wasn't an intentional snub, macro changes applied. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre