From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: fixup sparse warnings Date: Mon, 03 Dec 2012 21:13:52 +0000 Message-ID: <84c8a8$6pr9bk@orsmga001.jf.intel.com> References: <1354223932-8278-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id B2F57E5C14 for ; Mon, 3 Dec 2012 13:14:05 -0800 (PST) In-Reply-To: <1354223932-8278-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Thu, 29 Nov 2012 22:18:51 +0100, Daniel Vetter wrote: > - __iomem where there is none (I love how we mix these things up). > - Use gfp_t instead of an other plain type. > - Unconfuse one place about enum pipe vs enum transcoder - for the pch > transcoder we actually use the pipe enum. Fixup the other cases > where we assign the pipe to the cpu transcoder with explicit casts. > - Declare the mch_lock properly in a header. > > There is still a decent mess in intel_bios.c about __iomem, but heck, > this is x86 and we're allowed to do that. > > Signed-off-by: Daniel Vetter Makes-sparse-happy: Chris Wilson How about deciding whether it is '(cast) object' or '(cast)object' and be consistent. -Chris -- Chris Wilson, Intel Open Source Technology Centre