Re: [PATCH] drm/i915: Don't continually defer the hangcheck

Daniel Vetter
2014-11-19T10:44:55Z

On Wed, Nov 19, 2014 at 09:47:19AM +0000, Chris Wilson wrote:
> With multiple rings, we may continue to render on the blitter whilst
> executing an infinite shader on the render ring. As we currently, rearm
> the timer with each execbuf, in this scenario the hangcheck will never
> fire and we will never detect the lockup on the render ring. Instead,
> only arm the timer once per hangcheck, so that hangcheck runs more
> frequently.
>
> v2: Rearrange code to avoid triggering a BUG_ON in add_timer from
> softirq context.
>
> Testcase: igt/gem_reset_stats/defer-hangcheck*
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86225
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>

I went right ahead and upgraded this to r-b: mika.

Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch