From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kumar, Mahesh" Subject: Re: [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function Date: Tue, 10 Jul 2018 18:48:02 +0530 Message-ID: <84ed4de3-57f8-e491-61d4-5d0bbf515572@intel.com> References: <20180702110729.8171-1-mahesh1.kumar@intel.com> <20180702110729.8171-9-mahesh1.kumar@intel.com> <18451995.rnOpagHzdN@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <18451995.rnOpagHzdN@avalon> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGksCgpUaGFua3MgZm9yIHRoZSByZXZpZXcuCgpPbiA3LzEwLzIwMTggNToxOSBQTSwgTGF1cmVu dCBQaW5jaGFydCB3cm90ZToKPiBIaSBNYWhlc2gsCj4KPiBUaGFuayB5b3UgZm9yIHRoZSBwYXRj aC4KPgo+IE9uIE1vbmRheSwgMiBKdWx5IDIwMTggMTQ6MDc6MjcgRUVTVCBNYWhlc2ggS3VtYXIg d3JvdGU6Cj4+IFRoaXMgcGF0Y2ggbWFrZSBjaGFuZ2VzIHRvIGFsbG9jYXRlIGNyYy1lbnRyaWVz IGJ1ZmZlciBiZWZvcmUKPj4gZW5hYmxpbmcgQ1JDIGdlbmVyYXRpb24uCj4+IEl0IG1vdmVzIGFs bCB0aGUgZmFpbHVyZSBjaGVjayBlYXJseSBpbiB0aGUgZnVuY3Rpb24gYmVmb3JlIHNldHRpbmcK Pj4gdGhlIHNvdXJjZSBvciBtZW1vcnkgYWxsb2NhdGlvbi4KPj4gTm93IHNldF9jcmNfc291cmNl IHRha2VzIG9ubHkgdHdvIHZhcmlhYmxlIGlucHV0cywgdmFsdWVzX2NudCB3ZQo+PiBhbHJlYWR5 IGdldHMgYXMgcGFydCBvZiB2ZXJpZnlfY3JjX3NvdXJjZS4KPj4KPj4gU2lnbmVkLW9mZi1ieTog TWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFyQGludGVsLmNvbT4KPj4gQ2M6IGRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gUmV2aWV3ZWQtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxt YWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvZ3B1 L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmggIHwgIDMgKy0KPj4gICAuLi4v Z3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtX2NyYy5jICB8ICA0ICstCj4+ ICAgZHJpdmVycy9ncHUvZHJtL2RybV9kZWJ1Z2ZzX2NyYy5jICAgICAgICAgICAgICAgICAgfCA1 MiArKysrKysrKy0tLS0tLS0tLS0tCj4+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2 LmggICAgICAgICAgICAgICAgICAgfCAgMyArLQo+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3BpcGVfY3JjLmMgICAgICAgICAgICAgIHwgIDQgKy0KPj4gICBkcml2ZXJzL2dwdS9kcm0v cmNhci1kdS9yY2FyX2R1X2NydGMuYyAgICAgICAgICAgICB8ICA1ICstLQo+PiAgIGRyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMgICAgICAgIHwgIDYgKy0tCj4+ICAg aW5jbHVkZS9kcm0vZHJtX2NydGMuaCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgMyAr LQo+PiAgIDggZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgNTAgZGVsZXRpb25zKC0p Cj4gW3NuaXBdCj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVidWdmc19j cmMuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVidWdmc19jcmMuYyBpbmRleCBmNGQ3NjUy OGQyNGMuLjczOWE4MTNiNGIwOSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9k ZWJ1Z2ZzX2NyYy5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGVidWdmc19jcmMuYwo+ PiBAQCAtMTI0LDExICsxMjQsOSBAQCBzdGF0aWMgc3NpemVfdCBjcmNfY29udHJvbF93cml0ZShz dHJ1Y3QgZmlsZSAqZmlsZSwKPj4gY29uc3QgY2hhciBfX3VzZXIgKnVidWYsIGlmIChzb3VyY2Vb bGVuXSA9PSAnXG4nKQo+PiAgIAkJc291cmNlW2xlbl0gPSAnXDAnOwo+Pgo+PiAtCWlmIChjcnRj LT5mdW5jcy0+dmVyaWZ5X2NyY19zb3VyY2UpIHsKPj4gLQkJcmV0ID0gY3J0Yy0+ZnVuY3MtPnZl cmlmeV9jcmNfc291cmNlKGNydGMsIHNvdXJjZSwgJnZhbHVlc19jbnQpOwo+PiAtCQlpZiAocmV0 KQo+PiAtCQkJcmV0dXJuIHJldDsKPj4gLQl9Cj4+ICsJcmV0ID0gY3J0Yy0+ZnVuY3MtPnZlcmlm eV9jcmNfc291cmNlKGNydGMsIHNvdXJjZSwgJnZhbHVlc19jbnQpOwo+PiArCWlmIChyZXQpCj4+ ICsJCXJldHVybiByZXQ7Cj4+Cj4+ICAgCXNwaW5fbG9ja19pcnEoJmNyYy0+bG9jayk7Cj4+Cj4+ IEBAIC0xOTMsMTIgKzE5MSwxNSBAQCBzdGF0aWMgaW50IGNydGNfY3JjX29wZW4oc3RydWN0IGlu b2RlICppbm9kZSwgc3RydWN0Cj4+IGZpbGUgKmZpbGVwKSByZXR1cm4gcmV0Owo+PiAgIAl9Cj4+ Cj4+IC0JaWYgKGNydGMtPmZ1bmNzLT52ZXJpZnlfY3JjX3NvdXJjZSkgewo+PiAtCQlyZXQgPSBj cnRjLT5mdW5jcy0+dmVyaWZ5X2NyY19zb3VyY2UoY3J0YywgY3JjLT5zb3VyY2UsCj4+IC0JCQkJ CQkgICAgICZ2YWx1ZXNfY250KTsKPj4gLQkJaWYgKHJldCkKPj4gLQkJCXJldHVybiByZXQ7Cj4+ IC0JfQo+PiArCXJldCA9IGNydGMtPmZ1bmNzLT52ZXJpZnlfY3JjX3NvdXJjZShjcnRjLCBjcmMt PnNvdXJjZSwgJnZhbHVlc19jbnQpOwo+PiArCWlmIChyZXQpCj4+ICsJCXJldHVybiByZXQ7Cj4+ ICsKPj4gKwlpZiAoV0FSTl9PTih2YWx1ZXNfY250ID4gRFJNX01BWF9DUkNfTlIpKQo+PiArCQly ZXR1cm4gLUVJTlZBTDsKPj4gKwo+PiArCWlmIChXQVJOX09OKHZhbHVlc19jbnQgPT0gMCkpCj4+ ICsJCXJldHVybiAtRUlOVkFMOwo+Pgo+PiAgIAlzcGluX2xvY2tfaXJxKCZjcmMtPmxvY2spOwo+ PiAgIAlpZiAoIWNyYy0+b3BlbmVkKQo+PiBAQCAtMjEwLDMwICsyMTEsMjIgQEAgc3RhdGljIGlu dCBjcnRjX2NyY19vcGVuKHN0cnVjdCBpbm9kZSAqaW5vZGUsIHN0cnVjdAo+PiBmaWxlICpmaWxl cCkgaWYgKHJldCkKPj4gICAJCXJldHVybiByZXQ7Cj4+Cj4+IC0JcmV0ID0gY3J0Yy0+ZnVuY3Mt PnNldF9jcmNfc291cmNlKGNydGMsIGNyYy0+c291cmNlLCAmdmFsdWVzX2NudCk7Cj4+IC0JaWYg KHJldCkKPj4gLQkJZ290byBlcnI7Cj4+IC0KPj4gLQlpZiAoV0FSTl9PTih2YWx1ZXNfY250ID4g RFJNX01BWF9DUkNfTlIpKSB7Cj4+IC0JCXJldCA9IC1FSU5WQUw7Cj4+IC0JCWdvdG8gZXJyX2Rp c2FibGU7Cj4+IC0JfQo+PiAtCj4+IC0JaWYgKFdBUk5fT04odmFsdWVzX2NudCA9PSAwKSkgewo+ PiAtCQlyZXQgPSAtRUlOVkFMOwo+PiAtCQlnb3RvIGVycl9kaXNhYmxlOwo+PiAtCX0KPj4gLQo+ PiAgIAllbnRyaWVzID0ga2NhbGxvYyhEUk1fQ1JDX0VOVFJJRVNfTlIsIHNpemVvZigqZW50cmll cyksIEdGUF9LRVJORUwpOwo+PiAgIAlpZiAoIWVudHJpZXMpIHsKPj4gICAJCXJldCA9IC1FTk9N RU07Cj4+IC0JCWdvdG8gZXJyX2Rpc2FibGU7Cj4+ICsJCWdvdG8gZXJyOwo+PiAgIAl9Cj4gSWYg eW91IG1vdmVkIGFsbG9jYXRpb24gYmVmb3JlIHRoZSAhY3JjLT5vcGVuZWQgY2hlY2ssIHlvdSBj b3VsZCBncm91cCB0aGUgdHdvCj4gY29kZSBibG9ja3MgcHJvdGVjdGVkIGJ5IHRoZSBjcmMtPmxv Y2suCmFncmVlLCB3aWxsIHVwZGF0ZSBpbiBuZXh0IHZlcnNpb24uCi1NYWhlc2gKPj4gICAJc3Bp bl9sb2NrX2lycSgmY3JjLT5sb2NrKTsKPj4gICAJY3JjLT5lbnRyaWVzID0gZW50cmllczsKPj4g ICAJY3JjLT52YWx1ZXNfY250ID0gdmFsdWVzX2NudDsKPj4gKwlzcGluX3VubG9ja19pcnEoJmNy Yy0+bG9jayk7Cj4+Cj4+ICsJcmV0ID0gY3J0Yy0+ZnVuY3MtPnNldF9jcmNfc291cmNlKGNydGMs IGNyYy0+c291cmNlKTsKPj4gKwlpZiAocmV0KQo+PiArCQlnb3RvIGVycjsKPj4gKwo+PiArCXNw aW5fbG9ja19pcnEoJmNyYy0+bG9jayk7Cj4+ICAgCS8qCj4+ICAgCSAqIE9ubHkgcmV0dXJuIG9u Y2Ugd2UgZ290IGEgZmlyc3QgZnJhbWUsIHNvIHVzZXJzcGFjZSBkb2Vzbid0IGhhdmUgdG8KPj4g ICAJICogZ3Vlc3Mgd2hlbiB0aGlzIHBhcnRpY3VsYXIgcGllY2Ugb2YgSFcgd2lsbCBiZSByZWFk eSB0byBzdGFydAo+PiBAQCAtMjUwLDcgKzI0Myw3IEBAIHN0YXRpYyBpbnQgY3J0Y19jcmNfb3Bl bihzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzdHJ1Y3QKPj4gZmlsZSAqZmlsZXApIHJldHVybiAwOwo+ Pgo+PiAgIGVycl9kaXNhYmxlOgo+PiAtCWNydGMtPmZ1bmNzLT5zZXRfY3JjX3NvdXJjZShjcnRj LCBOVUxMLCAmdmFsdWVzX2NudCk7Cj4+ICsJY3J0Yy0+ZnVuY3MtPnNldF9jcmNfc291cmNlKGNy dGMsIE5VTEwpOwo+PiAgIGVycjoKPj4gICAJc3Bpbl9sb2NrX2lycSgmY3JjLT5sb2NrKTsKPj4g ICAJY3J0Y19jcmNfY2xlYW51cChjcmMpOwo+PiBAQCAtMjYyLDkgKzI1NSw4IEBAIHN0YXRpYyBp bnQgY3J0Y19jcmNfcmVsZWFzZShzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzdHJ1Y3QKPj4gZmlsZSAq ZmlsZXApIHsKPj4gICAJc3RydWN0IGRybV9jcnRjICpjcnRjID0gZmlsZXAtPmZfaW5vZGUtPmlf cHJpdmF0ZTsKPj4gICAJc3RydWN0IGRybV9jcnRjX2NyYyAqY3JjID0gJmNydGMtPmNyYzsKPj4g LQlzaXplX3QgdmFsdWVzX2NudDsKPj4KPj4gLQljcnRjLT5mdW5jcy0+c2V0X2NyY19zb3VyY2Uo Y3J0YywgTlVMTCwgJnZhbHVlc19jbnQpOwo+PiArCWNydGMtPmZ1bmNzLT5zZXRfY3JjX3NvdXJj ZShjcnRjLCBOVUxMKTsKPj4KPj4gICAJc3Bpbl9sb2NrX2lycSgmY3JjLT5sb2NrKTsKPj4gICAJ Y3J0Y19jcmNfY2xlYW51cChjcmMpOwo+PiBAQCAtMzcwLDcgKzM2Miw3IEBAIGludCBkcm1fZGVi dWdmc19jcnRjX2NyY19hZGQoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+PiAgIHsKPj4gICAJc3Ry dWN0IGRlbnRyeSAqY3JjX2VudCwgKmVudDsKPj4KPj4gLQlpZiAoIWNydGMtPmZ1bmNzLT5zZXRf Y3JjX3NvdXJjZSkKPj4gKwlpZiAoIWNydGMtPmZ1bmNzLT5zZXRfY3JjX3NvdXJjZSB8fCAhY3J0 Yy0+ZnVuY3MtPnZlcmlmeV9jcmNfc291cmNlKQo+PiAgIAkJcmV0dXJuIDA7Cj4+Cj4+ICAgCWNy Y19lbnQgPSBkZWJ1Z2ZzX2NyZWF0ZV9kaXIoImNyYyIsIGNydGMtPmRlYnVnZnNfZW50cnkpOwo+ IFtzbmlwXQo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK