Re: [PATCH 06/12] Remove glamor support from UXA acceleration

Keith Packard
2014-07-31T05:52:39Z

[-- Attachment #1.1: Type: text/plain, Size: 911 bytes --]

Eric Anholt <eric@anholt.net> writes:

> Something weird happened in this commit.
>
> uxa-glamor.h is removed from the repo, but the makefile only drops
> intel_glamor.h, which keeps getting used. I suspect make distcheck is
> broken.

Yeah, almost certainly. In fact, after this patch, the driver does *not*
build if you ask for glamor.

> intel_glamor.c is no longer built, but USE_GLAMOR might still be defined
> I think, and if so intel_glamor_flush() from it is still getting
> called.

Right, the driver explicitly doesn't build with --enable-glamor after
this patch. Cleaning it up so that it would build makes more of a mess
though, so I just didn't worry about it as I was re-adding glamor when
all of the USE_GLAMOR bits would be needed again.

I can make it work if you like, but this patch and the re-enable glamor
patch would both get larger.

--
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 810 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org