From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH 06/12] Remove glamor support from UXA
	acceleration
Date: Wed, 30 Jul 2014 22:52:39 -0700
Message-ID: <86a97qdqhk.fsf@hiro.keithp.com>
References: <1406243908-1123-1-git-send-email-keithp@keithp.com>
 <1406243908-1123-7-git-send-email-keithp@keithp.com>
 <87k36ue223.fsf@eliezer.anholt.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2007323904=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <87k36ue223.fsf@eliezer.anholt.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Eric Anholt <eric@anholt.net>, xorg-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============2007323904==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Eric Anholt <eric@anholt.net> writes:

> Something weird happened in this commit.
>
> uxa-glamor.h is removed from the repo, but the makefile only drops
> intel_glamor.h, which keeps getting used.  I suspect make distcheck is
> broken.

Yeah, almost certainly. In fact, after this patch, the driver does *not*
build if you ask for glamor.

> intel_glamor.c is no longer built, but USE_GLAMOR might still be defined
> I think, and if so intel_glamor_flush() from it is still getting
> called.

Right, the driver explicitly doesn't build with --enable-glamor after
this patch. Cleaning it up so that it would build makes more of a mess
though, so I just didn't worry about it as I was re-adding glamor when
all of the USE_GLAMOR bits would be needed again.

I can make it work if you like, but this patch and the re-enable glamor
patch would both get larger.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBU9nZp9siGmkAAAARAQgRJw//Xm+TPFLktdfYUxEXu1MCyHr3HsXiEDzP
8PtQC+iRk+X6UyVDMiedBf0tX47rZ5v0IuM5i+Fk6gflQi9LhzR1yXJiCoAbxlFh
Gmp97hQqUDWWzZMyQx6aH4KZIpO1Zg5yw+OrFhMPMysEDYAk4DoV1zUfiL+7jvQs
l/UsBastDXPG7DhwggBEFdWHQsdv0XqSZl7xJcybdWnHJ46COT1fMiy88xQ3pEj9
jGmODeBFeO1gduc0hY1O5YfIE6o98gam8UtP1wGh7dtXYKuTU3eAH+j5gnBvL4Jk
RAo/HAPUBCydEEPLiYZ28vPHk1DxvZrVdt8QH6buhOdkHu9kByVU6PaodR28jZ7+
5d/66C8CJIgwiwASLAGtpkko4TXKIWzruzdACca8YXBd+kt4Pih76DR2iTrpEaDo
LGk9MO+Zgp9hBVXuj1ngZ3902HIiiiGIps+NmpjnHEHrlu2HkvwY+rJd9JFgDHvM
xxGDMDlQ1oCYmZjWzEXBYpmaCecZkk/3hbDfiGJBZ44p4HagyyB/NCcIJF7RQ4cV
zKjJZ3PApg/kpBOf9i0M59lkZt0LAbkCs5+izq51lDb+WYmpLiDG+21z85pjZ2SX
WWi8frog3ClDLQgwKKcg1c2/owlYAuunA7OR4/ck7crEOLIMAiKGly0BQxCFw/kA
MMS9NaEY8Wc=
=37xH
-----END PGP SIGNATURE-----
--=-=-=--

--===============2007323904==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============2007323904==--