From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keith Packard <keithp@keithp.com>
Subject: Re: [PATCH 03/12] Don't use GetScratchPixmapHeader for
	shadow pixmaps
Date: Wed, 30 Jul 2014 22:49:42 -0700
Message-ID: <86d2cmdqmh.fsf@hiro.keithp.com>
References: <1406243908-1123-1-git-send-email-keithp@keithp.com>
 <1406243908-1123-4-git-send-email-keithp@keithp.com>
 <87oaw6e2i4.fsf@eliezer.anholt.net>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1871796719=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <87oaw6e2i4.fsf@eliezer.anholt.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Eric Anholt <eric@anholt.net>, xorg-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

--===============1871796719==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Eric Anholt <eric@anholt.net> writes:

> This change appears to be unrelated, and possibly harmful (if X has
> dropped the last ref to the BO, but it's still the scanout buffer, a new
> allocation would now reuse the BO and scribble on scanout until the next
> modeset happens).

Yeah, it's unrelated. intel_allocate_framebuffer calls disable_reuse, so
there's no need to call it from these two other places. I'll split that
change out into a separate patch with separate comment.

> Unrelated whitespace.

There are a bunch of whitespace fixups; should I pull those into a
separate patch or just leave them scattered in the first patch to change
a file?

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBU9nY9tsiGmkAAAARAQhLDg//UWjvhf8+SCpKCwHa1kq161eDJS6Rf5x7
YulqnyozeEEHTviBH0Ir7Cfnq5wq2IL1U7rCY5BvJQR18Ie9Ju8p1LWT29Wj3sWM
nb7VUV7yNHXDq43PFwKpMiilGyKAlA/h9vUL/6qxA4Q1NK8Y3EcPrYwjjH1fZcbU
fL8sQq1/QlFdDGShe13hWGwx/2jKf41IDU24hC4bl1VLE8EpnvLSDqqg/Fx4gPn3
beYWufoDgnPchYAUqJxjN+0f/c5tlvCymQnjnbHCzTlMNS845xlXA3F4QFwTDJc7
Xq+uynaiMAMRfiFLVUXDqxrmbdH1zSiaRJo6lKx30HfXtF555rbggCwQWvLtl5c3
9yPdlUWkGkzT4bU4ZMhOiGLoXsVAXQh/bHYxZKi0BjpwE0rgrF6cyu1FU9n+yIS3
vG4Qs7EuR4Jcqb0hwOdt6pp8mwkX9bnkI8Ik/ydrQ9ROzbyVG6l9G2oqmejO0yM5
bL+sFzlyz6WfNqZa39WsD2wpdtwmULACCC/0nAVN+nazAEki0QdrW/kDyxJHpjMc
OaLhpii8uORRL7lC4fKw3uht+l5hZcVnGeGO/ZYiNgEe3z7m9fdbkUzfdO5dwHFZ
ehd/rFui+LRU+MjaFG3IzngmxPtJzi3LYqf+dmXkuKOUZGsI5jpA26CyPqRoKbuY
x3e3ZhV+ND8=
=y6HT
-----END PGP SIGNATURE-----
--=-=-=--

--===============1871796719==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1871796719==--