From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Packard Subject: Re: [PATCH 00/12] Rework intel 2D driver glamor support Date: Wed, 30 Jul 2014 23:56:12 -0700 Message-ID: <86oaw6c8z7.fsf@hiro.keithp.com> References: <1406243908-1123-1-git-send-email-keithp@keithp.com> <874mxydzwo.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0740927199==" Return-path: In-Reply-To: <874mxydzwo.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Eric Anholt , xorg-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0740927199== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eric Anholt writes: > Keith Packard writes: > >> I spent the day just cleaning up this patch series and testing. I >> think it's ready for others to use and review. I've been running it on >> two machines for a couple of days now and it's been solid. > > Patches 2, 4 are: > > Reviewed-by: Eric Anholt > > Patch 5 is: > > Acked-by: Eric Anholt I've pushed a new version of the tree with your review marked and a few changes: * Split the GetScratchPixmapHeader change into two pieces; the first just removes the redundant calls to drm_intel_bo_disable_reuse and the second contains the scratch pixmap changes and the other misc stuff. Yes, I could split the misc changes out into another cleanup patch if you want. * Removed the tiling check from intel_present when flipping. The kernel doesn't appear to ever require matching tiling. * Removed call to dixPrivateKeyRegistered in the 'Add glamor back' patch. What I didn't do is clean up the 'remove glamor' patch so that it would compile even with --enable-glamor. Fixing that seems like noise to me; all of the changes needed to make it work would be immediately un-done when adding glamor back. =2D-=20 keith.packard@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUBU9nojNsiGmkAAAARAQhpmBAAq5f/0R+SRdFAP0A+zmOwfYE+KZwvdpPg dB7qKM9QdW3lNyIrhlc1CnHa8kaOSFfavuYC6kselHgAUDMI8w1hP5t8x1esC0nv QyIj2MGwVnIjkagvNXigQuHERiMNvlXsxQm5xAlkyVhZuuvCBdjyyqn5hkWRcLbj CJhZj3x9fvHO3d9QbmBG8u8IbyxByUGCyX2L4LbNhu2sUIzwkW9RExYoVkv8G+pq DbS7/wCcrYYjfH6vW/fK6etdYbcMdubWQWO6pUb52G3cj04liJ7vfsVFE6pudQdl 6Swb2qGGdK0BFNBNl1XcWWbEnH9mMRpDM7RgfEGQ+gXNjIGSu7BKdF0bisjQaBJu AkCHuRikAleRBdr+iZaoMkgrJRNtG2mdtGsByv1mERwovVetyNZX8agQcDtoMqkZ f36V9Z0rXZ1l+Cl+NmrXUU+RgRwaswmdQZN5f46C1Ht3ETAoUVOtC3Ve3Hi1x2TM 4zTqwl0YSlF9fDX7I6MSaTFkKQjb6QOOlR/Ju4YgD/rJ61RWf2OFn2G80kAE8B4i 3IgcwNGfr70bV2r2lMiEqe3mZnViu3IFPUlVYyZN0h+9XLESk7EFXshcXGETbAJ4 c7JsmIK9L0aL9a6w0JU6gMCQXOOsUimQuVkll6kLhcDaHfQa9m0nwvL/289a/qUH eQtcL6sLBkI= =yaCZ -----END PGP SIGNATURE----- --=-=-=-- --===============0740927199== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0740927199==--