Re: [PATCH 00/12] Rework intel 2D driver glamor support

Keith Packard
2014-07-31T06:56:12Z

[-- Attachment #1.1: Type: text/plain, Size: 1311 bytes --]

Eric Anholt <eric@anholt.net> writes:

> Keith Packard <keithp@keithp.com> writes:
>
>> I spent the day just cleaning up this patch series and testing. I
>> think it's ready for others to use and review. I've been running it on
>> two machines for a couple of days now and it's been solid.
>
> Patches 2, 4 are:
>
> Reviewed-by: Eric Anholt <eric@anholt.net>
>
> Patch 5 is:
>
> Acked-by: Eric Anholt <eric@anholt.net>

I've pushed a new version of the tree with your review marked and a few
changes:

* Split the GetScratchPixmapHeader change into two pieces; the first
just removes the redundant calls to drm_intel_bo_disable_reuse and
the second contains the scratch pixmap changes and the other misc
stuff. Yes, I could split the misc changes out into another cleanup
patch if you want.

* Removed the tiling check from intel_present when flipping. The kernel
doesn't appear to ever require matching tiling.

* Removed call to dixPrivateKeyRegistered in the 'Add glamor back' patch.

What I didn't do is clean up the 'remove glamor' patch so that it would
compile even with --enable-glamor. Fixing that seems like noise to me;
all of the changes needed to make it work would be immediately un-done
when adding glamor back.

--
keith.packard@intel.com

[-- Attachment #1.2: Type: application/pgp-signature, Size: 810 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org