Re: [PATCH 01/12] Stop trying to out-guess mesa for BO allocation

Eric Anholt
2014-08-04T16:58:02Z

[-- Attachment #1.1: Type: text/plain, Size: 587 bytes --]

Keith Packard <keithp@keithp.com> writes:

> Eric Anholt <eric@anholt.net> writes:
>
>> Keith Packard <keithp@keithp.com> writes:
>>
>> I don't see anything indicating that this code path is only used by
>> glamor.
>
> True. It's a fix for DRI3 for either UXA or "none". Mesa allocates a
> single page for a 1x1 texture, but this code thinks that should take two
> pages causing a texture-to-pixmap operation to fail.

OK, but isn't the problem with the code you're #if 0ing (which, really?
#if 0 in a patch being submitted for review?) that it's aligning to
2*height instead of height?

[-- Attachment #1.2: Type: application/pgp-signature, Size: 818 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org