From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55A03C02180 for ; Wed, 15 Jan 2025 19:22:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A1D1D10E7BE; Wed, 15 Jan 2025 19:22:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="Ip1BlMl9"; dkim-atps=neutral Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE8EA10E7BE for ; Wed, 15 Jan 2025 19:22:53 +0000 (UTC) Received: from relay7-d.mail.gandi.net (unknown [217.70.183.200]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 942CBC0A90 for ; Wed, 15 Jan 2025 19:22:50 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 72E1720003; Wed, 15 Jan 2025 19:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1736968947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvlL0mfj44cUCiwG8WLJrEnhaM51ApZOW7dKY/vuFiA=; b=Ip1BlMl93pKCALrSZKHRK3E2cThEoM684DtxClKerUnAHE+XALAA4E2QB0oMKrk/srchnw SJACqMQ8SlerS5Kd+G3O5/P45LVKnwrNDo1y0dGnMb+LEMnqepEj9cNaqlHat/BXjDU/tP wDExJThqs0CvG1AoQXpOb0CDhjX+RyXeoAEFcHqL7xUtC5Bh/X1rfPZ3SqnXmD9BC9Ah6r ap8ZH1MoMHQXnwlAB0GScmJZaG66htE4tpUppAUx/nrlA022aIhLqJPRxwrBodwjIzaiKC 72MBi2xsYuISHHTtsIMZSsPNPbyG7C+vTGixVFj08ptr7fvShIjyoRcooioWfg== From: Miquel Raynal To: "Usyskin, Alexander" Cc: Richard Weinberger , Vignesh Raghavendra , "De Marchi, Lucas" , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , "Vivi, Rodrigo" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , "Poosa, Karthik" , "Abliyev, Reuven" , "Weil, Oren jer" , "linux-mtd@lists.infradead.org" , "dri-devel@lists.freedesktop.org" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 01/11] mtd: core: always create master device In-Reply-To: (Alexander Usyskin's message of "Tue, 14 Jan 2025 14:05:40 +0000") References: <20250101153925.865703-1-alexander.usyskin@intel.com> <20250101153925.865703-2-alexander.usyskin@intel.com> <87sepwp6d9.fsf@bootlin.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 15 Jan 2025 20:22:25 +0100 Message-ID: <871px3lw5q.fsf@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, On 14/01/2025 at 14:05:40 GMT, "Usyskin, Alexander" wrote: >> > > Create master device without partition when >> > > CONFIG_MTD_PARTITIONED_MASTER flag is unset. >> > >> > I don't think you took into consideration my remarks regarding the fact >> > that you would break userspace. If you enable the master, you no longer >> > have the same device numbering in userspace. I know people should not >> > care about these numbers, but in practice they do. >> > >> > If I'm wrong, please be a little more verbose about why :) >> > >> > Thanks, >> > Miqu=C3=A8l >>=20 >> Hi Miquel >>=20 >> I've created separate class (mtd_master) for such devices. >> Uses-space looking for mtd device continues to receive same number of >> /dev/mtdX devices. >> There will be additional /dev/mtd_masterX devices, but this is unavoidab= le, I >> suppose. >> Maybe we can rename it to something that not in /dev/mtd* expression (e.= g. >> mastermtdX), >> if it helps. >>=20 > > Miquel, is this good enough or requires rewrite? This is an important change that requires attention, and at the time I have not been able to dedicate enough to this patch. Also, if the other mtd maintainers want to help, I'll be enthousiastic about it :) Thanks, Miqu=C3=A8l