From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AAF8E7717F for ; Tue, 17 Dec 2024 10:55:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D23C10E8F8; Tue, 17 Dec 2024 10:55:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LK+ARMb0"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3B4410E073; Tue, 17 Dec 2024 10:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734432915; x=1765968915; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=pAF3u81RSfxk8S/RON9x9Z3Vk7U9w46EWtt0bOQ4oWI=; b=LK+ARMb0t711/o3uQ9IY6fUXldAzefq5G1TwI6JUzsk2IuRPp/XQaJo1 YGOazZ/RWQQCMqYt7OanCWjhmRGh+z8JL1iMdxu/XYlZXKnAoVxib2XOR FGOs71+qvnDAQK12vKQD9dy3qcxkRjsNOBZq2tvHRjrE9o/aYbgUIh4YZ afc0IiKECfRrvaJCtYZQJrtx4YmgKEtkTCyRk5zFoR6A4/4LuTxQtqYEv s1BmCCxQkrq1KbyuwSfoSxqlNFzLcdr8rVAumkdbGea3LQjWxjuULeWYO TkSOq06GEvjz+jyRcn+uACMtFQV7kkImJBfwC44GFaifdTeVuYI5U/jIb g==; X-CSE-ConnectionGUID: mPjEy2z5TKG2IwyUzaLGhw== X-CSE-MsgGUID: dYdbO9e0QZmyL/0X7cvuzQ== X-IronPort-AV: E=McAfee;i="6700,10204,11288"; a="35007819" X-IronPort-AV: E=Sophos;i="6.12,241,1728975600"; d="scan'208";a="35007819" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 02:55:14 -0800 X-CSE-ConnectionGUID: PKQMN8/wRT6zG0Mv42a8sQ== X-CSE-MsgGUID: N6n6xr3RS+azAKlDGq3JNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="97343731" Received: from carterle-desk.ger.corp.intel.com (HELO localhost) ([10.245.246.55]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 02:55:12 -0800 From: Jani Nikula To: Ankit Nautiyal , intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org, suraj.kandpal@intel.com, imre.deak@intel.com Subject: Re: [PATCH 02/14] drm/i915/dp: Return early if DSC not supported In-Reply-To: <20241217093244.3938132-3-ankit.k.nautiyal@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20241217093244.3938132-1-ankit.k.nautiyal@intel.com> <20241217093244.3938132-3-ankit.k.nautiyal@intel.com> Date: Tue, 17 Dec 2024 12:55:09 +0200 Message-ID: <871py6sho2.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 17 Dec 2024, Ankit Nautiyal wrote: > Check for DSC support before computing link config with DSC. > For DP MST we are already doing the same. > > Signed-off-by: Ankit Nautiyal > Reviewed-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 908b9887f89b..dd2da9facaad 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2375,9 +2375,6 @@ int intel_dp_dsc_compute_config(struct intel_dp *intel_dp, > intel_dp_supports_fec(intel_dp, connector, pipe_config) && > !intel_dp_is_uhbr(pipe_config)); > > - if (!intel_dp_supports_dsc(intel_dp, connector, pipe_config)) > - return -EINVAL; > - > if (!intel_dp_dsc_supports_format(connector, pipe_config->output_format)) > return -EINVAL; > > @@ -2652,6 +2649,9 @@ intel_dp_compute_link_config(struct intel_encoder *encoder, > str_yes_no(ret), str_yes_no(joiner_needs_dsc), > str_yes_no(intel_dp->force_dsc_en)); > > + if (!intel_dp_supports_dsc(intel_dp, connector, pipe_config)) > + return -EINVAL; > + The (pre-existing) problem with this is that we debug log we fall back to DSC, while we don't. Maybe we should do something like this instead, both in SST and MST code: --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -2644,6 +2644,11 @@ intel_dp_compute_link_config(struct intel_encoder *encoder, dsc_needed = true; } + if (dsc_needed && !intel_dp_supports_dsc(connector, pipe_config)) { + drm_dbg_kms(display->drm, "DSC required but not available.\n"); + return -EINVAL; + } + if (dsc_needed) { drm_dbg_kms(display->drm, "Try DSC (fallback=%s, joiner=%s, force=%s)\n", BR, Jani. > if (!intel_dp_compute_config_limits(intel_dp, pipe_config, > respect_downstream_limits, > true, -- Jani Nikula, Intel