intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] drm/i915/dp: Fix colorimetry detection
@ 2024-09-18 19:04 Ville Syrjala
  2024-09-18 19:04 ` [PATCH 2/3] drm/i915/dp: Make intel_dp_get_colorimetry_status() static Ville Syrjala
                   ` (5 more replies)
  0 siblings, 6 replies; 11+ messages in thread
From: Ville Syrjala @ 2024-09-18 19:04 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jouni Högander

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

intel_dp_init_connector() is no place for detecting stuff via
DPCD (except perhaps for eDP). Move the colorimetry stuff into
a more appropriate place.

Cc: Jouni Högander <jouni.hogander@intel.com>
Fixes: 00076671a648 ("drm/i915/display: Move colorimetry_support from intel_psr to intel_dp")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 19f78432cc8f..f44951d8a0f8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4082,6 +4082,9 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp, struct intel_connector *connector
 			 drm_dp_is_branch(intel_dp->dpcd));
 	intel_init_dpcd_quirks(intel_dp, &intel_dp->desc.ident);
 
+	intel_dp->colorimetry_support =
+		intel_dp_get_colorimetry_status(intel_dp);
+
 	/*
 	 * Read the eDP display control registers.
 	 *
@@ -4195,6 +4198,9 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)
 
 		intel_init_dpcd_quirks(intel_dp, &intel_dp->desc.ident);
 
+		intel_dp->colorimetry_support =
+			intel_dp_get_colorimetry_status(intel_dp);
+
 		intel_dp_update_sink_caps(intel_dp);
 	}
 
@@ -6946,9 +6952,6 @@ intel_dp_init_connector(struct intel_digital_port *dig_port,
 				    "HDCP init failed, skipping.\n");
 	}
 
-	intel_dp->colorimetry_support =
-		intel_dp_get_colorimetry_status(intel_dp);
-
 	intel_dp->frl.is_trained = false;
 	intel_dp->frl.trained_rate_gbps = 0;
 
-- 
2.44.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-09-26  7:49 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-18 19:04 [PATCH 1/3] drm/i915/dp: Fix colorimetry detection Ville Syrjala
2024-09-18 19:04 ` [PATCH 2/3] drm/i915/dp: Make intel_dp_get_colorimetry_status() static Ville Syrjala
2024-09-25 14:21   ` Luca Coelho
2024-09-18 19:04 ` [PATCH 3/3] drm/i915/dp: Extract intel_edp_set_sink_rates() Ville Syrjala
2024-09-25 14:22   ` Luca Coelho
2024-09-26  7:48   ` Jani Nikula
2024-09-26  7:49     ` Jani Nikula
2024-09-18 20:14 ` ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/dp: Fix colorimetry detection Patchwork
2024-09-18 20:15 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-19  6:09 ` [PATCH 1/3] " Hogander, Jouni
2024-09-19  7:43 ` ✗ Fi.CI.IGT: failure for series starting with [1/3] " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).