From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85715E784A4 for ; Mon, 2 Oct 2023 07:41:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C87A810E227; Mon, 2 Oct 2023 07:41:28 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 17E9210E223; Mon, 2 Oct 2023 07:41:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696232485; x=1727768485; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=1qUwGk01htOg6hilSZjSFVpakohj7jFoYXU7zfjfW7I=; b=nGcrTIFh+zlSfoHjpfATSUZon8W9kiLBDQ7QfrWN2NXX17t9vXK1uvJB ggPQQDKJ8fgvOnMFuEDCTV2Iev0cemSWppLj21+NFcpz/pS6PMo9XBpUf NGKTDljG+MQMCb9AftDJwG5/ocKm7AGi09ECoppor/qG4x8lAcC9m/TcC 3LMgLjSls63nR6d4+gUgMk/Q/ndaHMLAPZVVfD837bd5A979+g4Z0IhPF zA0hQkaUWILSVO75rk1j8XbcjKWmVxy4niXMvgSGr7AeX5wS1I2qfx0fg f9I1XpFOZXTFN9Veyhz7ZL3z8uVg8x+4Y3J9c293PcTskAhtnzWZOYXTL A==; X-IronPort-AV: E=McAfee;i="6600,9927,10850"; a="449086558" X-IronPort-AV: E=Sophos;i="6.03,193,1694761200"; d="scan'208";a="449086558" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 00:41:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,193,1694761200"; d="scan'208";a="1443811" Received: from svandens-mobl.ger.corp.intel.com (HELO localhost) ([10.252.55.151]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2023 00:40:44 -0700 From: Jani Nikula To: Rodrigo Vivi , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org In-Reply-To: <20230929205023.1202735-1-rodrigo.vivi@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230929205023.1202735-1-rodrigo.vivi@intel.com> Date: Mon, 02 Oct 2023 10:41:14 +0300 Message-ID: <871qedii91.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915: Abstract display info away during probe X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 29 Sep 2023, Rodrigo Vivi wrote: > The goal is to have this function ready for Xe to use > directly. So, let's use the available macro. Seesm wrong to use DISPLAY_INFO() as an lvalue, and I'm not sure why this wouldn't work as-is. But *shrug*. Reviewed-by: Jani Nikula for merging to i915. (xe should come as a backport with cherry-pick -x.) BR, Jani > > Cc: Jani Nikula > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_display_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c > index a6a18eae7ae8..ce55b968e658 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_device.c > +++ b/drivers/gpu/drm/i915/display/intel_display_device.c > @@ -926,7 +926,7 @@ void intel_display_device_probe(struct drm_i915_private *i915) > else > info = probe_display(i915); > > - i915->display.info.__device_info = info; > + DISPLAY_INFO(i915) = info; > > memcpy(DISPLAY_RUNTIME_INFO(i915), > &DISPLAY_INFO(i915)->__runtime_defaults, -- Jani Nikula, Intel