From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13C8EC4332F for ; Fri, 9 Dec 2022 18:32:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23C8410E57F; Fri, 9 Dec 2022 18:32:05 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0402C10E57D; Fri, 9 Dec 2022 18:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670610719; x=1702146719; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=KM6dsX8+UrSVnWIZWRX5+Y4yvGo/GU2ieRu1v5T9YcQ=; b=kfozwrVs02hYKXW/lJwLsv6uzhuAg2elzgpH3a5YLVpyfFlWZN/aYo5Y B0f9Z2Tu3xegubcZVmj9BdvIfYvqaXu5z8VyL/Q+rsSwZoMibQIpPOLio 0lwNpp7U6QrLRxntO7hTHe3iIGGbW/UZgvHvuUYZBccYAM/uiSkp8Sb/E BDU2Nwx7qc/G3RyYifI7NMgL6FR7kVHra+ykcNLv1lrWFXsjJz4kVtURv 7Hc92ckNvCjXdoo9UKaiHBmOeuITNv+VHEEF9b9FploT2VTLKtOw6tkSK 8A0fUTm1WExwxzoPbye19dcZ9DBRSlJtmkvjeQ48l33kCuPQ+tdrTfnZZ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10556"; a="297201601" X-IronPort-AV: E=Sophos;i="5.96,232,1665471600"; d="scan'208";a="297201601" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2022 10:31:59 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10556"; a="771942194" X-IronPort-AV: E=Sophos;i="5.96,232,1665471600"; d="scan'208";a="771942194" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.24.17]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Dec 2022 10:31:58 -0800 Date: Fri, 09 Dec 2022 10:31:58 -0800 Message-ID: <871qp8mns1.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Vinay Belgaumkar In-Reply-To: <20220814234654.34800-1-vinay.belgaumkar@intel.com> References: <20220814234654.34800-1-vinay.belgaumkar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Allow SLPC to use efficient frequency X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, 14 Aug 2022 16:46:54 -0700, Vinay Belgaumkar wrote: > > Host Turbo operates at efficient frequency when GT is not idle unless > the user or workload has forced it to a higher level. Replicate the same > behavior in SLPC by allowing the algorithm to use efficient frequency. > We had disabled it during boot due to concerns that it might break > kernel ABI for min frequency. However, this is not the case since > SLPC will still abide by the (min,max) range limits. This change seems to have broken the i915 kernel ABI for min frequency for DG2. Tvrtko pointed this out here: https://patchwork.freedesktop.org/patch/512274/?series=110574&rev=3 These bugs are the result of that ABI break: Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/6806 Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/6786 On DG2 when we set min == max freq, we see the GPU running not at the set min == max freq but at efficient freq (different from the set freq). We are still trying to see if the ABI can be salvaged but something is definitely wrong at present. Thanks. -- Ashutosh