From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56F5DC433F5 for ; Tue, 11 Oct 2022 17:39:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 712F010E981; Tue, 11 Oct 2022 17:39:14 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 15EA410E981 for ; Tue, 11 Oct 2022 17:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665509950; x=1697045950; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=a8WFgdRxklICkOAQFHOZjbNNDaBzUTTRSjJ/e4sGh6k=; b=mUGt4dcK1qP1g4gxNX5Q+1A5h9XlCu6ywv51zqJP2NqgKZpTvFDFLv2s UjaLKpWwJtpiPBi4Rzt3XSOqC4apwMfoMyCPErdojGczxCddyCjL3lPNf zbDXGhqZvQgbf7xZR4gUFxgloQ6Ipo99PoBlrVqqu48HwvIwQSjadEGYo rNC5EQVdXJ0gOjP1kISYqQveidIocjhytxIkm1mrclxLuB5yYkZprKEIe KUE+cpbRVTHZQNCk+4Ar3Sw4kEBW74yaA2XEeprkNbkQktF2r2ZfRaFEJ o93AKaS8BamvY+NpQOCqm5I6lgLhFuMrvI/1Ti2FlOOi48cMzK1Xv4pxX g==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="287845153" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="287845153" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 10:39:09 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="604234737" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="604234737" Received: from milawils-mobl.ger.corp.intel.com (HELO localhost) ([10.252.40.183]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 10:39:07 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org In-Reply-To: <20221011170011.17198-1-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20221011170011.17198-1-ville.syrjala@linux.intel.com> Date: Tue, 11 Oct 2022 20:39:04 +0300 Message-ID: <871qrexnt3.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 00/22] drm/i915: ELD precompute and readout X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Takashi Iwai Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 11 Oct 2022, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > There was some discussion around ELD precompute, so I > decided to have a quick look at hooking that up. Unfortunately > the i915 audio code is a bit of a mess so ended up with > a patchbomb of cleanups. Sorry about that. > > The actually interesting stuff is at the end of the series. > The precumpute+readot+state checker is pretty self explanatory > stuff for the most part. > > But I think we need to decide what to do with the hardware > ELD buffer in general. It's totally busted atm on HSW=20 > (and I'd expecpt BDW as well), but we had no idea since > we had no readout+state checker for it.=20 > > So do we try to salvage it (I guess to mainly act as some > kind of "did we enable audio correctly?" canary) or do we > just stop programming it outright? And on which platforms > could we do that? Quickly eyeballed through it all, overall looks good, but didn't do detailed review. Ack. Cc: Vinod too. BR, Jani. > > Cc: Chaitanya Kumar Borah > Cc: Kai Vehmanen > Cc: Takashi Iwai > > Ville Syrj=C3=A4l=C3=A4 (22): > drm/i915/audio: s/dev_priv/i915/ > drm/i915/audio: Nuke leftover ROUNDING_FACTOR > drm/i915/audio: Remove CL/BLC audio stuff > drm/i915/audio: Exract struct ilk_audio_regs > drm/i915/audio: Use REG_BIT() & co. > drm/i915/audio: Unify register bit naming > drm/i915/audio: Protect singleton register with a lock > drm/i915/audio: Nuke intel_eld_uptodate() > drm/i915/audio: Read ELD buffer size from hardware > drm/i915/audio: Make sure we write the whole ELD buffer > drm/i915/audio: Use u32* for ELD > drm/i915/audio: Use intel_de_rmw() for most audio registers > drm/i915/audio: Split "ELD valid" vs. audio PD on hsw+ > drm/i915/audio: Do the vblank waits > drm/i915/audio: Precompute the ELD > drm/i915/audio: Hardware ELD readout > drm/i915/sdvo: Extract intel_sdvo_has_audio() > drm/i915/sdvo: Precompute the ELD > drm/i915/sdvo: Do ELD hardware readout > drm/i915/audio: Hook up ELD into the state checker > drm/i915/audio: Include ELD in the state dump > hax: drm/i915/audio: Make HSW hardware ELD buffer sort of work > > drivers/gpu/drm/i915/display/g4x_dp.c | 2 + > drivers/gpu/drm/i915/display/g4x_hdmi.c | 2 + > drivers/gpu/drm/i915/display/intel_audio.c | 792 ++++++++++-------- > drivers/gpu/drm/i915/display/intel_audio.h | 7 + > .../gpu/drm/i915/display/intel_audio_regs.h | 88 +- > .../drm/i915/display/intel_crtc_state_dump.c | 17 + > drivers/gpu/drm/i915/display/intel_ddi.c | 2 + > drivers/gpu/drm/i915/display/intel_display.c | 43 + > .../drm/i915/display/intel_display_types.h | 2 + > drivers/gpu/drm/i915/display/intel_dp.c | 4 +- > drivers/gpu/drm/i915/display/intel_hdmi.c | 4 +- > drivers/gpu/drm/i915/display/intel_sdvo.c | 54 +- > 12 files changed, 608 insertions(+), 409 deletions(-) --=20 Jani Nikula, Intel Open Source Graphics Center