From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30998C433EF for ; Tue, 7 Jun 2022 22:07:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8310E10E75A; Tue, 7 Jun 2022 22:07:33 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 538BF10E6AE; Tue, 7 Jun 2022 22:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654639652; x=1686175652; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=bE6yGqtHIv7+WZw3e5CWBx5Pf72ThSkZeI357hG/y5E=; b=LuWd3gPHVN7ygw1TXLq2ERir0VovX2hP/hpL+jTWGa9HGy1eb99HQb0K Jh6wZqoVmT6xwXbvxhpXiQH4oRKKuFtL8yHBUZwkb9SM41kSZL4C1Y2mN 2z27YErlPdxJhHbldIpcxPrRVe9W3ruwOR8qFa/NtstE4KC30vnNVRbYU aqA68EyT2eJf6HMbTRH41j9vsf/icc8al5QYVq1Aoutt9vmcpxSBvZoz+ +sMyoLBdnjJ6Yp33m5JFRdYP3wTJkRAd74oRhnpiV36dgyi/5ou2T1d/i 5vu6dFbQmAIWItFvaao631zAVG4ce3DS/s239+6AjLX5kYNULQaDNdviQ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="256588587" X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="256588587" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 15:07:31 -0700 X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="584427156" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.186.67]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 15:07:31 -0700 Date: Tue, 07 Jun 2022 15:07:31 -0700 Message-ID: <871qw0ktzw.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: John.C.Harrison@Intel.com In-Reply-To: <20220607215103.3342267-1-John.C.Harrison@Intel.com> References: <20220607215103.3342267-1-John.C.Harrison@Intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915/guc: Use drm_err instead of pr_err X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel-GFX@Lists.FreeDesktop.Org, DRI-Devel@Lists.FreeDesktop.Org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 07 Jun 2022 14:51:03 -0700, John.C.Harrison@Intel.com wrote: > > From: John Harrison > > Don't use pr_err in places where we have access to a struct_drm. Seem to be many more pr_err's in selftests. Is there a reason why drm_err's cannot be used in selftests (especially those using an i915 device)? Thanks.