From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3D2BC433EF for ; Tue, 26 Apr 2022 00:29:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D82710EA7A; Tue, 26 Apr 2022 00:29:05 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2A94F10EBBF for ; Tue, 26 Apr 2022 00:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650932944; x=1682468944; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=a/SKu6pOeCSv4l35zCzabgzCodKhNFZDuGG936nDniA=; b=lMJCPQWwOJb4SglnmNwj9PoOckMa9xLpag/8FiKU0nmixxn3E3bQ/dYx GquOJL/O/fAKwK8cdgfnhiAJAFz4xVRg8LcV+1nlKVuHJAeDnSFsuqZQV 50AH6/C204jzOqr+qpu3Yd00Ef0FRtbC9sWHG98Hs+bV3qkVpZUv+lj0/ aqfVXFy9xnWupgtNtHt3qjJ6C2xAEHpzIoonVWNOQLps2HVjpZYD7RttK CCRW/JD1EPSRdbsS3UknDuoYpD6aVtMd7ALqkewz2tfnXnvZNs/pkCEEl b6KE2LiD01Gzku70KQz810rY6HUTyL0bVr9pxAUDiUJok3wRghKZAgv/K A==; X-IronPort-AV: E=McAfee;i="6400,9594,10328"; a="265206728" X-IronPort-AV: E=Sophos;i="5.90,289,1643702400"; d="scan'208";a="265206728" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2022 17:29:03 -0700 X-IronPort-AV: E=Sophos;i="5.90,289,1643702400"; d="scan'208";a="512882904" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.212.195.217]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2022 17:29:03 -0700 Date: Mon, 25 Apr 2022 17:29:03 -0700 Message-ID: <871qxk7kmo.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 21 Apr 2022 13:57:03 -0700, Rodrigo Vivi wrote: > > On Tue, Apr 19, 2022 at 10:21:26PM -0700, Ashutosh Dixit wrote: > > > +#define U8_8_VAL_MASK 0xffff > > +#define U8_8_SCALE_TO_VALUE "0.00390625" > > I really like this style because it gets future proof... > Well, honestly I don't believe that for Media multipliers we will be ever > move away from the GuC API. Nevertheless we have other cases in the pipeline > like balancing the gt and basedie that benefits of this abstraction and > it is good to have a standard api and in sync. > > For this reason I'm in favor of this one here and code looks correct to me, > so: > > Reviewed-by: Rodrigo Vivi Thanks. > Should we split this series with only this 2 first patches so we don't > get blocked on the intel_pcode refactor? I have posted a series with with just the first 2 patches here: https://patchwork.freedesktop.org/series/103110/ We can look at merging this after it goes through CI. Thanks. -- Ashutosh