From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96916C433DF for ; Wed, 1 Jul 2020 15:43:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 794232071A for ; Wed, 1 Jul 2020 15:43:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 794232071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA2396E937; Wed, 1 Jul 2020 15:43:04 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 791A26E937 for ; Wed, 1 Jul 2020 15:43:03 +0000 (UTC) IronPort-SDR: TyxbF/q14Ja2nM7x1uZDsETgw0+UiXr7CMZR9NFO4/LqijjjSjcUKNHkddrm8zrlZk2YVWm2jY YGXR6X2288tg== X-IronPort-AV: E=McAfee;i="6000,8403,9668"; a="231473812" X-IronPort-AV: E=Sophos;i="5.75,300,1589266800"; d="scan'208";a="231473812" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 08:36:00 -0700 IronPort-SDR: xG1VzIkN8NrRCWpf3sM25XAl3jrCmm6GWOiZRHkNG00KNJrpqQGYq7ujO7+ezDojePBycqkpjW 1FtyEa1rW3XA== X-IronPort-AV: E=Sophos;i="5.75,300,1589266800"; d="scan'208";a="455143881" Received: from gaulion-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.51.61]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 08:35:58 -0700 From: Jani Nikula To: Lucas De Marchi , intel-gfx@lists.freedesktop.org In-Reply-To: <87ftabl3ku.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200625001120.22810-1-lucas.demarchi@intel.com> <20200625001120.22810-4-lucas.demarchi@intel.com> <87ftabl3ku.fsf@intel.com> Date: Wed, 01 Jul 2020 18:35:55 +0300 Message-ID: <871rlvl02s.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v2 3/6] drm/i915/display: start description-based ddi initialization X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lucas De Marchi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 01 Jul 2020, Jani Nikula wrote: > On Wed, 24 Jun 2020, Lucas De Marchi wrote: >> >> +struct intel_ddi_port_info { > > Just thinking out loud, should we have a "struct port" or "struct > intel_port" instead. Maybe, maybe not. *shrug* After reading the whole series, I might lean even more towards introducing a struct intel_port. Not insisting you'd have to do that as part of this series, but something to consider. How would things look like? BR, Jani. > > Anyway the patch is > > Reviewed-by: Jani Nikula > >> + const char *name; >> + enum port port; >> +}; >> + >> static inline enum dpio_channel >> vlv_dport_to_channel(struct intel_digital_port *dport) >> { -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx