From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 00/10] drm/i915: some more header juggling
Date: Wed, 07 Aug 2019 12:53:44 +0300 [thread overview]
Message-ID: <871rxxjo7r.fsf@intel.com> (raw)
In-Reply-To: <156508781641.2892.9805858219316342@skylake-alporthouse-com>
On Tue, 06 Aug 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2019-08-06 11:07:21)
>> The big theme here is to emphasize that intel_drv.h is a display header, so
>> rename it display/intel_display_types.h and reduce its use in non-display
>> code. Also reduce the inclusion of that and the other mega header i915_drv.h
>> from other headers.
>>
>> BR,
>> Jani.
>>
>>
>> Jani Nikula (10):
>> drm/i915: move intel_display.c function declarations
>> drm/i915/sprite: un-inline icl_is_hdr_plane()
>> drm/i915/irq: un-inline functions to avoid i915_drv.h include
>> drm/i915/bw: make intel_atomic_get_bw_state() static
>> drm/i915/mst: un-inline intel_dp_mst_encoder_active_links()
>> drm/i915/tc: un-inline intel_tc_port_ref_held()
>> drm/i915: avoid including intel_drv.h via i915_drv.h->i915_trace.h
>> drm/i915: rename intel_drv.h to display/intel_display_types.h
>> drm/i915: remove unnecessary includes of intel_display_types.h header
>> drm/i915: move property enums to intel_display_types.h
>
> A few moments of exasperation of "we use that there!?", but looks all
> dandy. I didn't spot anything other than mechanical translations and I
> agree with the direction,
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed the lot, many thanks for reviewing these tedious patches!
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-07 9:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 10:07 [PATCH 00/10] drm/i915: some more header juggling Jani Nikula
2019-08-06 10:07 ` [PATCH 01/10] drm/i915: move intel_display.c function declarations Jani Nikula
2019-08-06 10:07 ` [PATCH 02/10] drm/i915/sprite: un-inline icl_is_hdr_plane() Jani Nikula
2019-08-06 10:07 ` [PATCH 03/10] drm/i915/irq: un-inline functions to avoid i915_drv.h include Jani Nikula
2019-08-06 10:07 ` [PATCH 04/10] drm/i915/bw: make intel_atomic_get_bw_state() static Jani Nikula
2019-08-06 10:07 ` [PATCH 05/10] drm/i915/mst: un-inline intel_dp_mst_encoder_active_links() Jani Nikula
2019-08-06 10:07 ` [PATCH 06/10] drm/i915/tc: un-inline intel_tc_port_ref_held() Jani Nikula
2019-08-06 11:37 ` [PATCH v2] " Jani Nikula
2019-08-06 10:07 ` [PATCH 07/10] drm/i915: avoid including intel_drv.h via i915_drv.h->i915_trace.h Jani Nikula
2019-08-06 10:07 ` [PATCH 08/10] drm/i915: rename intel_drv.h to display/intel_display_types.h Jani Nikula
2019-08-06 11:39 ` [PATCH v2] " Jani Nikula
2019-08-06 10:07 ` [PATCH 09/10] drm/i915: remove unnecessary includes of intel_display_types.h header Jani Nikula
2019-08-06 10:07 ` [PATCH 10/10] drm/i915: move property enums to intel_display_types.h Jani Nikula
2019-08-06 10:36 ` [PATCH 00/10] drm/i915: some more header juggling Chris Wilson
2019-08-07 9:53 ` Jani Nikula [this message]
2019-08-06 10:54 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-06 10:59 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-08-06 11:32 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-06 11:43 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: some more header juggling (rev3) Patchwork
2019-08-06 11:47 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-08-06 12:03 ` ✓ Fi.CI.BAT: success " Patchwork
2019-08-06 20:57 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rxxjo7r.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).