From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [CI] drm/i915: Refactor unsettting obj->mm.pages Date: Mon, 11 Jun 2018 15:35:19 +0300 Message-ID: <871sdd4i2g.fsf@intel.com> References: <20180611075532.26534-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A1CE89DDD for ; Mon, 11 Jun 2018 12:35:26 +0000 (UTC) In-Reply-To: <20180611075532.26534-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxMSBKdW4gMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IEFzIGk5MTVfZ2VtX29iamVjdF9waHlzX2F0dGFjaCgpIHdhbnRzIHRvIHBs YXkgZGlydHkgYW5kIG1lc3MgYXJvdW5kCj4gd2l0aCBvYmotPm1tLnBhZ2VzIGl0c2VsZiAocmVw bGFjaW5nIHRoZSBzaG1lbWZzIHdpdGggYSBETUEgYWxsb2NhdGlvbiksCj4gcmVmYWN0b3IgdGhl IGd1YmJpbnMgc28gaW50byBpOTE1X2dlbV9vYmplY3RfdW5zZXRfcGFnZXMoKSB0aGF0IHdlIGRv bid0Cj4gaGF2ZSB0byBkdXBsaWNhdGUgYWxsIHRoZSBzZWNyZXRzLgoKVHJpcGxlIHQgaW4gInVu c2V0dHRpbmciIGluIHRoZSBzdWJqZWN0LiBDYW4gYmUgZml4ZWQgd2hpbGUgYXBwbHlpbmcuCgpC UiwKSmFuaS4KCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXgu aW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBNYXR0aGV3IEF1bGQgPG1hdHRoZXcuYXVsZEBpbnRl bC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCA2OCArKysr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM3IGluc2Vy dGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5k ZXggNDE4N2UwNjg4ZTUwLi4wMjZhMjdhZmE2NWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPiBAQCAtMjQwMSwyOSArMjQwMSwxNSBAQCBzdGF0aWMgdm9pZCBfX2k5MTVfZ2VtX29iamVj dF9yZXNldF9wYWdlX2l0ZXIoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPiAgCXJj dV9yZWFkX3VubG9jaygpOwo+ICB9Cj4gIAo+IC12b2lkIF9faTkxNV9nZW1fb2JqZWN0X3B1dF9w YWdlcyhzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+IC0JCQkJIGVudW0gaTkxNV9t bV9zdWJjbGFzcyBzdWJjbGFzcykKPiArc3RhdGljIHN0cnVjdCBzZ190YWJsZSAqCj4gK19faTkx NV9nZW1fb2JqZWN0X3Vuc2V0X3BhZ2VzKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmop Cj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1ID0gdG9faTkxNShvYmotPmJh c2UuZGV2KTsKPiAgCXN0cnVjdCBzZ190YWJsZSAqcGFnZXM7Cj4gIAo+IC0JaWYgKGk5MTVfZ2Vt X29iamVjdF9oYXNfcGlubmVkX3BhZ2VzKG9iaikpCj4gLQkJcmV0dXJuOwo+IC0KPiAtCUdFTV9C VUdfT04ob2JqLT5iaW5kX2NvdW50KTsKPiAtCWlmICghaTkxNV9nZW1fb2JqZWN0X2hhc19wYWdl cyhvYmopKQo+IC0JCXJldHVybjsKPiAtCj4gLQkvKiBNYXkgYmUgY2FsbGVkIGJ5IHNocmlua2Vy IGZyb20gd2l0aGluIGdldF9wYWdlcygpIChvbiBhbm90aGVyIGJvKSAqLwo+IC0JbXV0ZXhfbG9j a19uZXN0ZWQoJm9iai0+bW0ubG9jaywgc3ViY2xhc3MpOwo+IC0JaWYgKHVubGlrZWx5KGF0b21p Y19yZWFkKCZvYmotPm1tLnBhZ2VzX3Bpbl9jb3VudCkpKQo+IC0JCWdvdG8gdW5sb2NrOwo+IC0K PiAtCS8qIC0+cHV0X3BhZ2VzIG1pZ2h0IG5lZWQgdG8gYWxsb2NhdGUgbWVtb3J5IGZvciB0aGUg Yml0MTcgc3dpenpsZQo+IC0JICogYXJyYXksIGhlbmNlIHByb3RlY3QgdGhlbSBmcm9tIGJlaW5n IHJlYXBlZCBieSByZW1vdmluZyB0aGVtIGZyb20gZ3R0Cj4gLQkgKiBsaXN0cyBlYXJseS4gKi8K PiAgCXBhZ2VzID0gZmV0Y2hfYW5kX3plcm8oJm9iai0+bW0ucGFnZXMpOwo+IC0JR0VNX0JVR19P TighcGFnZXMpOwo+ICsJaWYgKCFwYWdlcykKPiArCQlyZXR1cm4gTlVMTDsKPiAgCj4gIAlzcGlu X2xvY2soJmk5MTUtPm1tLm9ial9sb2NrKTsKPiAgCWxpc3RfZGVsKCZvYmotPm1tLmxpbmspOwo+ IEBAIC0yNDQyLDEyICsyNDI4LDM3IEBAIHZvaWQgX19pOTE1X2dlbV9vYmplY3RfcHV0X3BhZ2Vz KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gIAl9Cj4gIAo+ICAJX19pOTE1X2dl bV9vYmplY3RfcmVzZXRfcGFnZV9pdGVyKG9iaik7Cj4gKwlvYmotPm1tLnBhZ2Vfc2l6ZXMucGh5 cyA9IG9iai0+bW0ucGFnZV9zaXplcy5zZyA9IDA7Cj4gKwo+ICsJcmV0dXJuIHBhZ2VzOwo+ICt9 Cj4gIAo+ICt2b2lkIF9faTkxNV9nZW1fb2JqZWN0X3B1dF9wYWdlcyhzdHJ1Y3QgZHJtX2k5MTVf Z2VtX29iamVjdCAqb2JqLAo+ICsJCQkJIGVudW0gaTkxNV9tbV9zdWJjbGFzcyBzdWJjbGFzcykK PiArewo+ICsJc3RydWN0IHNnX3RhYmxlICpwYWdlczsKPiArCj4gKwlpZiAoaTkxNV9nZW1fb2Jq ZWN0X2hhc19waW5uZWRfcGFnZXMob2JqKSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJR0VNX0JVR19P TihvYmotPmJpbmRfY291bnQpOwo+ICsJaWYgKCFpOTE1X2dlbV9vYmplY3RfaGFzX3BhZ2VzKG9i aikpCj4gKwkJcmV0dXJuOwo+ICsKPiArCS8qIE1heSBiZSBjYWxsZWQgYnkgc2hyaW5rZXIgZnJv bSB3aXRoaW4gZ2V0X3BhZ2VzKCkgKG9uIGFub3RoZXIgYm8pICovCj4gKwltdXRleF9sb2NrX25l c3RlZCgmb2JqLT5tbS5sb2NrLCBzdWJjbGFzcyk7Cj4gKwlpZiAodW5saWtlbHkoYXRvbWljX3Jl YWQoJm9iai0+bW0ucGFnZXNfcGluX2NvdW50KSkpCj4gKwkJZ290byB1bmxvY2s7Cj4gKwo+ICsJ LyoKPiArCSAqIC0+cHV0X3BhZ2VzIG1pZ2h0IG5lZWQgdG8gYWxsb2NhdGUgbWVtb3J5IGZvciB0 aGUgYml0MTcgc3dpenpsZQo+ICsJICogYXJyYXksIGhlbmNlIHByb3RlY3QgdGhlbSBmcm9tIGJl aW5nIHJlYXBlZCBieSByZW1vdmluZyB0aGVtIGZyb20gZ3R0Cj4gKwkgKiBsaXN0cyBlYXJseS4K PiArCSAqLwo+ICsJcGFnZXMgPSBfX2k5MTVfZ2VtX29iamVjdF91bnNldF9wYWdlcyhvYmopOwo+ ICAJaWYgKCFJU19FUlIocGFnZXMpKQo+ICAJCW9iai0+b3BzLT5wdXRfcGFnZXMob2JqLCBwYWdl cyk7Cj4gIAo+IC0Jb2JqLT5tbS5wYWdlX3NpemVzLnBoeXMgPSBvYmotPm1tLnBhZ2Vfc2l6ZXMu c2cgPSAwOwo+IC0KPiAgdW5sb2NrOgo+ICAJbXV0ZXhfdW5sb2NrKCZvYmotPm1tLmxvY2spOwo+ ICB9Cj4gQEAgLTYwOTAsMTYgKzYxMDEsNyBAQCBpbnQgaTkxNV9nZW1fb2JqZWN0X2F0dGFjaF9w aHlzKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosIGludCBhbGlnbikKPiAgCQlnb3Rv IGVycl91bmxvY2s7Cj4gIAl9Cj4gIAo+IC0JcGFnZXMgPSBmZXRjaF9hbmRfemVybygmb2JqLT5t bS5wYWdlcyk7Cj4gLQlpZiAocGFnZXMpIHsKPiAtCQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq aTkxNSA9IHRvX2k5MTUob2JqLT5iYXNlLmRldik7Cj4gLQo+IC0JCV9faTkxNV9nZW1fb2JqZWN0 X3Jlc2V0X3BhZ2VfaXRlcihvYmopOwo+IC0KPiAtCQlzcGluX2xvY2soJmk5MTUtPm1tLm9ial9s b2NrKTsKPiAtCQlsaXN0X2RlbCgmb2JqLT5tbS5saW5rKTsKPiAtCQlzcGluX3VubG9jaygmaTkx NS0+bW0ub2JqX2xvY2spOwo+IC0JfQo+ICsJcGFnZXMgPSBfX2k5MTVfZ2VtX29iamVjdF91bnNl dF9wYWdlcyhvYmopOwo+ICAKPiAgCW9iai0+b3BzID0gJmk5MTVfZ2VtX3BoeXNfb3BzOwo+ICAK PiBAQCAtNjExNyw3ICs2MTE5LDExIEBAIGludCBpOTE1X2dlbV9vYmplY3RfYXR0YWNoX3BoeXMo c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwgaW50IGFsaWduKQo+ICAKPiAgZXJyX3hm ZXI6Cj4gIAlvYmotPm9wcyA9ICZpOTE1X2dlbV9vYmplY3Rfb3BzOwo+IC0Jb2JqLT5tbS5wYWdl cyA9IHBhZ2VzOwo+ICsJaWYgKCFJU19FUlJfT1JfTlVMTChwYWdlcykpIHsKPiArCQl1bnNpZ25l ZCBpbnQgc2dfcGFnZV9zaXplcyA9IGk5MTVfc2dfcGFnZV9zaXplcyhwYWdlcy0+c2dsKTsKPiAr Cj4gKwkJX19pOTE1X2dlbV9vYmplY3Rfc2V0X3BhZ2VzKG9iaiwgcGFnZXMsIHNnX3BhZ2Vfc2l6 ZXMpOwo+ICsJfQo+ICBlcnJfdW5sb2NrOgo+ICAJbXV0ZXhfdW5sb2NrKCZvYmotPm1tLmxvY2sp Owo+ICAJcmV0dXJuIGVycjsKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3Jh cGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=