public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] warn
Date: Tue, 24 Oct 2017 17:46:27 +0300	[thread overview]
Message-ID: <871slshad8.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20171023213237.26536-4-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> ---
>  drivers/gpu/drm/i915/i915_irq.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index f8205841868b..e4bd20ce031d 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -1391,6 +1391,9 @@ gen8_cs_irq_handler(struct intel_engine_cs *engine, u32 iir, int test_shift)
>  		if (READ_ONCE(engine->execlists.active)) {
>  			__set_bit(ENGINE_IRQ_EXECLIST, &engine->irq_posted);
>  			tasklet = true;
> +		} else if (WARN_ON(!engine->i915->gt.awake)) {

READ_ONCE

I'll get my coat.
-Mika

> +			struct drm_printer p = drm_info_printer(engine->i915->drm.dev);
> +			intel_engine_dump(engine, &p);
>  		}
>  	}
>  
> -- 
> 2.15.0.rc1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-10-24 14:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 21:32 [PATCH 1/4] drm/i915: Bump wait-times for the final CS interrupt before parking Chris Wilson
2017-10-23 21:32 ` [PATCH 2/4] drm/i915: Synchronize irq before parking each engine Chris Wilson
2017-10-24  8:01   ` Chris Wilson
2017-10-24  9:05   ` Chris Wilson
2017-10-24  9:19     ` Mika Kuoppala
2017-10-24  9:32       ` Chris Wilson
2017-10-24 14:26     ` Mika Kuoppala
2017-10-23 21:32 ` [PATCH 3/4] drm/i915: Filter out spurious execlists context-switch interrupts Chris Wilson
2017-10-24 14:40   ` Mika Kuoppala
2017-10-23 21:32 ` [PATCH 4/4] warn Chris Wilson
2017-10-24 14:46   ` Mika Kuoppala [this message]
2017-10-24 15:01     ` Chris Wilson
2017-10-23 22:04 ` ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Bump wait-times for the final CS interrupt before parking Patchwork
2017-10-23 23:15 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871slshad8.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox