public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [CI 5/5] igt/gem_workarounds: Add hibernation coverage
Date: Wed, 04 Oct 2017 16:48:34 +0300	[thread overview]
Message-ID: <871smj2fd9.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20171003134045.7600-5-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  tests/gem_workarounds.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/tests/gem_workarounds.c b/tests/gem_workarounds.c
> index 74bb11d2..dc39a76b 100644
> --- a/tests/gem_workarounds.c
> +++ b/tests/gem_workarounds.c
> @@ -34,6 +34,7 @@ static int gen;
>  enum operation {
>  	GPU_RESET,
>  	SUSPEND_RESUME,
> +	HIBERNATE_RESUME,
>  	SIMPLE_READ,
>  };
>  
> @@ -61,12 +62,6 @@ static struct write_only_list {
>  static struct intel_wa_reg *wa_regs;
>  static int num_wa_regs;
>  
> -static void test_suspend_resume(void)
> -{
> -	igt_info("Suspending the device ...\n");
> -	igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE);
> -}
> -
>  static bool write_only(const uint32_t addr)
>  {
>  	int i;
> @@ -194,7 +189,13 @@ static void check_workarounds(int fd, enum operation op, unsigned int flags)
>  		break;
>  
>  	case SUSPEND_RESUME:
> -		test_suspend_resume();
> +		igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
> +					      SUSPEND_TEST_NONE);
> +		break;
> +
> +	case HIBERNATE_RESUME:
> +		igt_system_suspend_autoresume(SUSPEND_STATE_DISK,
> +					      SUSPEND_TEST_NONE);
>  		break;
>  
>  	case SIMPLE_READ:
> @@ -222,6 +223,7 @@ igt_main
>  		{ "basic-read", SIMPLE_READ },
>  		{ "reset", GPU_RESET },
>  		{ "suspend-resume", SUSPEND_RESUME },
> +		{ "hibernate-resume", HIBERNATE_RESUME },
>  		{ }
>  	}, *op;
>  	const struct {
> -- 
> 2.14.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-10-04 13:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03 13:40 [CI 1/5] igt/gem_workarounds: Read the workaround registers from the active context Chris Wilson
2017-10-03 13:40 ` [CI 2/5] igt/gem_workarounds: Also exercise fresh contexts not the persistent default Chris Wilson
2017-10-04 13:13   ` Mika Kuoppala
2017-10-04 13:22     ` Chris Wilson
2017-10-03 13:40 ` [CI 3/5] igt/gem_workarounds: Also test new fd (implicit default context) Chris Wilson
2017-10-04 13:42   ` Mika Kuoppala
2017-10-03 13:40 ` [CI 4/5] igt/gem_workarounds: Reduce manual list to combinatorial loops Chris Wilson
2017-10-04 13:47   ` Mika Kuoppala
2017-10-03 13:40 ` [CI 5/5] igt/gem_workarounds: Add hibernation coverage Chris Wilson
2017-10-04 13:48   ` Mika Kuoppala [this message]
2017-10-03 15:19 ` [CI 1/5] igt/gem_workarounds: Read the workaround registers from the active context Mika Kuoppala
2017-10-03 15:32   ` Chris Wilson
2017-10-04 13:53     ` Mika Kuoppala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871smj2fd9.fsf@gaia.fi.intel.com \
    --to=mika.kuoppala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox