From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] drm/i915: Remove pre-production Broxton register workarounds Date: Wed, 27 Sep 2017 17:10:19 +0300 Message-ID: <871sms8c6s.fsf@intel.com> References: <20170927093325.24206-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id B803889A44 for ; Wed, 27 Sep 2017 14:10:47 +0000 (UTC) In-Reply-To: <20170927093325.24206-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyNyBTZXAgMjAxNywgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IFdlJ3ZlIGJlZ3VuIGV4Y2x1ZGluZyBwcmUtcHJvZHVjdGlvbiBCcm94dG9u IG1hY2hpbmVzIHNpbmNlIGNvbW1pdAo+IDAxMDJiYTFmZDhhZiAoImRybS9pOTE1OiBBZGQgZWFy bHkgQlhUIHNkdiB0byB0aGUgbGlzdCBvZiBwcmVwcm9kdWN0aW9uCj4gbWFjaGluZXMiKSwgbm93 IHJlbW92ZSB0aGUgbGlzdCBvZiB3b3JrYXJvdW5kIHJlZ2lzdGVyIHZhbHVlcyBmb3IgdGhvc2UK PiBlYXJseSBtYWNoaW5lcy4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNA Y2hyaXMtd2lsc29uLmNvLnVrPgoKT24gdGhlIHNlcmllcywKClJldmlld2VkLWJ5OiBKYW5pIE5p a3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKU2lkZSBub3RlICMxLCBzaG91bGQgd2UgdGhy b3cgb3V0IHRoZSBvbGQgdW51c2VkIHN0ZXBwaW5nIG1hY3Jvcz8KClNpZGUgbm90ZSAjMiwgd2Ug c2VlbSB0byBiZSBtaXNzaW5nIGEgYnVuY2ggb2YgcGxhdGZvcm1zIGZyb20KaW50ZWxfZGV0ZWN0 X3ByZXByb2R1Y3Rpb25faHcoKS4gQXQgbGVhc3QgS0JMLCBHTEssIENGTCwgYW5kIENOTCB3b3Vs ZApiZSByZWxldmFudC4gSSBzdXBwb3NlIHdlIGNvdWxkIGFsc28gcmVtb3ZlIEhTVyBjaGVjayBp biB0aGVyZSwgYW5kCmFzc3VtZSBub2JvZHkgd291bGQgdXNlIGEgcHJlLXByb2R1Y3Rpb24gdmVy c2lvbiBvZiBzdWNoIGFuIG9sZCB0aGluZz8KCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9lbmdpbmVfY3MuYyB8IDU2ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCA1NSBkZWxldGlvbnMoLSkKPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gaW5kZXggYTI4ZTJhODY0Y2Yx Li5jZDUxZDgxZWM2ZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZW5naW5lX2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3Mu Ywo+IEBAIC05OTQsMjIgKzk5NCw2IEBAIHN0YXRpYyBpbnQgZ2VuOV9pbml0X3dvcmthcm91bmRz KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgCQlXQV9TRVRfQklUX01BU0tFRChI QUxGX1NMSUNFX0NISUNLRU4zLAo+ICAJCQkJICBHRU45X0RJU0FCTEVfT0NMX09PQl9TVVBQUkVT U19MT0dJQyk7Cj4gIAo+IC0JLyogV2FEaXNhYmxlRGdNaXJyb3JGaXhJbkhhbGZTbGljZUNoaWNr ZW41OmJ4dCAqLwo+IC0JaWYgKElTX0JYVF9SRVZJRChkZXZfcHJpdiwgMCwgQlhUX1JFVklEX0Ex KSkKPiAtCQlXQV9DTFJfQklUX01BU0tFRChHRU45X0hBTEZfU0xJQ0VfQ0hJQ0tFTjUsCj4gLQkJ CQkgIEdFTjlfREdfTUlSUk9SX0ZJWF9FTkFCTEUpOwo+IC0KPiAtCS8qIFdhU2V0RGlzYWJsZVBp eE1hc2tDYW1taW5nQW5kUmh3b0luQ29tbW9uU2xpY2VDaGlja2VuOmJ4dCAqLwo+IC0JaWYgKElT X0JYVF9SRVZJRChkZXZfcHJpdiwgMCwgQlhUX1JFVklEX0ExKSkgewo+IC0JCVdBX1NFVF9CSVRf TUFTS0VEKEdFTjdfQ09NTU9OX1NMSUNFX0NISUNLRU4xLAo+IC0JCQkJICBHRU45X1JIV09fT1BU SU1JWkFUSU9OX0RJU0FCTEUpOwo+IC0JCS8qCj4gLQkJICogV0EgYWxzbyByZXF1aXJlcyBHRU45 X1NMSUNFX0NPTU1PTl9FQ09fQ0hJQ0tFTjBbMTQ6MTRdIHRvIGJlIHNldAo+IC0JCSAqIGJ1dCB3 ZSBkbyB0aGF0IGluIHBlciBjdHggYmF0Y2hidWZmZXIgYXMgdGhlcmUgaXMgYW4gaXNzdWUKPiAt CQkgKiB3aXRoIHRoaXMgcmVnaXN0ZXIgbm90IGdldHRpbmcgcmVzdG9yZWQgb24gY3R4IHJlc3Rv cmUKPiAtCQkgKi8KPiAtCX0KPiAtCj4gIAkvKiBXYUVuYWJsZVlWMTJCdWdGaXhJbkhhbGZTbGlj ZUNoaWNrZW43OnNrbCxieHQsa2JsLGdsayxjZmwgKi8KPiAgCS8qIFdhRW5hYmxlU2FtcGxlckdQ R1BVUHJlZW1wdGlvblN1cHBvcnQ6c2tsLGJ4dCxrYmwsY2ZsICovCj4gIAlXQV9TRVRfQklUX01B U0tFRChHRU45X0hBTEZfU0xJQ0VfQ0hJQ0tFTjcsCj4gQEAgLTEwMjUsMTEgKzEwMDksNiBAQCBz dGF0aWMgaW50IGdlbjlfaW5pdF93b3JrYXJvdW5kcyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUpCj4gIAlXQV9DTFJfQklUX01BU0tFRChHRU45X0hBTEZfU0xJQ0VfQ0hJQ0tFTjUsCj4g IAkJCSAgR0VOOV9DQ1NfVExCX1BSRUZFVENIX0VOQUJMRSk7Cj4gIAo+IC0JLyogV2FEaXNhYmxl TWFza0Jhc2VkQ2FtbWluZ0luUkNDOmJ4dCAqLwo+IC0JaWYgKElTX0JYVF9SRVZJRChkZXZfcHJp diwgMCwgQlhUX1JFVklEX0ExKSkKPiAtCQlXQV9TRVRfQklUX01BU0tFRChTTElDRV9FQ09fQ0hJ Q0tFTjAsCj4gLQkJCQkgIFBJWEVMX01BU0tfQ0FNTUlOR19ESVNBQkxFKTsKPiAtCj4gIAkvKiBX YUZvcmNlQ29udGV4dFNhdmVSZXN0b3JlTm9uQ29oZXJlbnQ6c2tsLGJ4dCxrYmwsY2ZsICovCj4g IAlXQV9TRVRfQklUX01BU0tFRChIRENfQ0hJQ0tFTjAsCj4gIAkJCSAgSERDX0ZPUkNFX0NPTlRF WFRfU0FWRV9SRVNUT1JFX05PTl9DT0hFUkVOVCB8Cj4gQEAgLTEwNTksOCArMTAzOCw3IEBAIHN0 YXRpYyBpbnQgZ2VuOV9pbml0X3dvcmthcm91bmRzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu Z2luZSkKPiAgCS8qIFdhRGlzYWJsZVNhbXBsZXJQb3dlckJ5cGFzc0ZvclNPUGluZ1Bvbmc6c2ts LGJ4dCxrYmwsY2ZsICovCj4gIAlpZiAoSVNfU0tZTEFLRShkZXZfcHJpdikgfHwKPiAgCSAgICBJ U19LQUJZTEFLRShkZXZfcHJpdikgfHwKPiAtCSAgICBJU19DT0ZGRUVMQUtFKGRldl9wcml2KSB8 fAo+IC0JICAgIElTX0JYVF9SRVZJRChkZXZfcHJpdiwgMCwgQlhUX1JFVklEX0IwKSkKPiArCSAg ICBJU19DT0ZGRUVMQUtFKGRldl9wcml2KSkKPiAgCQlXQV9TRVRfQklUX01BU0tFRChIQUxGX1NM SUNFX0NISUNLRU4zLAo+ICAJCQkJICBHRU44X1NBTVBMRVJfUE9XRVJfQllQQVNTX0RJUyk7Cj4g IAo+IEBAIC0xMTc4LDE3ICsxMTU2LDYgQEAgc3RhdGljIGludCBieHRfaW5pdF93b3JrYXJvdW5k cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIAlpZiAocmV0KQo+ICAJCXJldHVy biByZXQ7Cj4gIAo+IC0JLyogV2FTdG9yZU11bHRpcGxlUFRFZW5hYmxlOmJ4dCAqLwo+IC0JLyog VGhpcyBpcyBhIHJlcXVpcmVtZW50IGFjY29yZGluZyB0byBIYXJkd2FyZSBzcGVjaWZpY2F0aW9u ICovCj4gLQlpZiAoSVNfQlhUX1JFVklEKGRldl9wcml2LCAwLCBCWFRfUkVWSURfQTEpKQo+IC0J CUk5MTVfV1JJVEUoVElMRUNUTCwgSTkxNV9SRUFEKFRJTEVDVEwpIHwgVElMRUNUTF9UTEJQRik7 Cj4gLQo+IC0JLyogV2FTZXRDbGNrR2F0aW5nRGlzYWJsZU1lZGlhOmJ4dCAqLwo+IC0JaWYgKElT X0JYVF9SRVZJRChkZXZfcHJpdiwgMCwgQlhUX1JFVklEX0ExKSkgewo+IC0JCUk5MTVfV1JJVEUo R0VON19NSVNDQ1BDVEwsIChJOTE1X1JFQUQoR0VON19NSVNDQ1BDVEwpICYKPiAtCQkJCQkgICAg fkdFTjhfRE9QX0NMT0NLX0dBVEVfTUVESUFfRU5BQkxFKSk7Cj4gLQl9Cj4gLQo+ICAJLyogV2FE aXNhYmxlVGhyZWFkU3RhbGxEb3BDbG9ja0dhdGluZzpieHQgKi8KPiAgCVdBX1NFVF9CSVRfTUFT S0VEKEdFTjhfUk9XX0NISUNLRU4sCj4gIAkJCSAgU1RBTExfRE9QX0dBVElOR19ESVNBQkxFKTsK PiBAQCAtMTE5OSwyNyArMTE2Niw2IEBAIHN0YXRpYyBpbnQgYnh0X2luaXRfd29ya2Fyb3VuZHMo c3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJCQkgICBfTUFTS0VEX0JJVF9FTkFC TEUoR0VOOV9QT09MRURfRVVfTE9BRF9CQUxBTkNJTkdfRklYX0RJU0FCTEUpKTsKPiAgCX0KPiAg Cj4gLQkvKiBXYURpc2FibGVTYmVDYWNoZURpc3BhdGNoUG9ydFNoYXJpbmc6Ynh0ICovCj4gLQlp ZiAoSVNfQlhUX1JFVklEKGRldl9wcml2LCAwLCBCWFRfUkVWSURfQjApKSB7Cj4gLQkJV0FfU0VU X0JJVF9NQVNLRUQoCj4gLQkJCUdFTjdfSEFMRl9TTElDRV9DSElDS0VOMSwKPiAtCQkJR0VON19T QkVfU1NfQ0FDSEVfRElTUEFUQ0hfUE9SVF9TSEFSSU5HX0RJU0FCTEUpOwo+IC0JfQo+IC0KPiAt CS8qIFdhRGlzYWJsZU9iamVjdExldmVsUHJlZW1wdGlvbkZvclRyaWZhbk9yUG9seWdvbjpieHQg Ki8KPiAtCS8qIFdhRGlzYWJsZU9iamVjdExldmVsUHJlZW1wdGlvbkZvckluc3RhbmNlZERyYXc6 Ynh0ICovCj4gLQkvKiBXYURpc2FibGVPYmplY3RMZXZlbFByZWVtdGlvbkZvckluc3RhbmNlSWQ6 Ynh0ICovCj4gLQkvKiBXYURpc2FibGVMU1FDUk9QRVJGZm9yT0NMOmJ4dCAqLwo+IC0JaWYgKElT X0JYVF9SRVZJRChkZXZfcHJpdiwgMCwgQlhUX1JFVklEX0ExKSkgewo+IC0JCXJldCA9IHdhX3Jp bmdfd2hpdGVsaXN0X3JlZyhlbmdpbmUsIEdFTjlfQ1NfREVCVUdfTU9ERTEpOwo+IC0JCWlmIChy ZXQpCj4gLQkJCXJldHVybiByZXQ7Cj4gLQo+IC0JCXJldCA9IHdhX3Jpbmdfd2hpdGVsaXN0X3Jl ZyhlbmdpbmUsIEdFTjhfTDNTUUNSRUc0KTsKPiAtCQlpZiAocmV0KQo+IC0JCQlyZXR1cm4gcmV0 Owo+IC0JfQo+IC0KPiAgCS8qIFdhUHJvZ3JhbUwzU3FjUmVnMURlZmF1bHRGb3JQZXJmOmJ4dCAq Lwo+ICAJaWYgKElTX0JYVF9SRVZJRChkZXZfcHJpdiwgQlhUX1JFVklEX0IwLCBSRVZJRF9GT1JF VkVSKSkKPiAgCQlJOTE1X1dSSVRFKEdFTjhfTDNTUUNSRUcxLCBMM19HRU5FUkFMX1BSSU9fQ1JF RElUUyg2MikgfAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK