From: Jani Nikula <jani.nikula@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "ben@bwidawsk.net" <ben@bwidawsk.net>,
"Chery, Nanley G" <nanley.g.chery@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: Kill GEN_RANGE in favor of INTEL_GEN.
Date: Thu, 07 Sep 2017 11:25:51 +0300 [thread overview]
Message-ID: <871sni6hkg.fsf@nikula.org> (raw)
In-Reply-To: <1504728785.7549.36.camel@rdvivi-vienna>
On Wed, 06 Sep 2017, "Vivi, Rodrigo" <rodrigo.vivi@intel.com> wrote:
> On Wed, 2017-09-06 at 20:57 +0100, Chris Wilson wrote:
>> Quoting Rodrigo Vivi (2017-09-06 20:51:37)
>> > Instead of limiting the range with this unusual GEN_RANGE
>> > let's assume following platforms would use same scheme
>> > unless stated otherwise.
>>
>> No. This is uabi that should indeed be checked before exposed and not
>> assumed that unprivileged access to a register of yesterday is still
>> safe tommorrow.
>
> hm... makes sense..
>
> can we at least move to
>
> INTEL_GEN >= 4 && INTEL_GEN <= 10
>
> or some flag on platform definition?
>
> I really don't like GEN_RANGE...
Why?
My only problem with it is that gen N does not map to bit N in the
mask. I think it would be more important to optimize for developer brain
reading the code than saving one bit.
BR,
Jani.
>
>> -Chris
>
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-07 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 19:51 [PATCH] drm/i915: Kill GEN_RANGE in favor of INTEL_GEN Rodrigo Vivi
2017-09-06 19:57 ` Chris Wilson
2017-09-06 20:13 ` Vivi, Rodrigo
2017-09-06 21:03 ` Chris Wilson
2017-09-07 8:25 ` Jani Nikula [this message]
2017-09-06 20:35 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-09-07 0:10 ` ✗ Fi.CI.IGT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sni6hkg.fsf@nikula.org \
--to=jani.nikula@intel.com \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nanley.g.chery@intel.com \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox