* [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting
@ 2015-06-04 15:01 Imre Deak
2015-06-05 9:22 ` shuang.he
2015-06-10 16:18 ` Matt Roper
0 siblings, 2 replies; 5+ messages in thread
From: Imre Deak @ 2015-06-04 15:01 UTC (permalink / raw)
To: intel-gfx
According to bspec the DDI PHY vswing scale value is "don't care" in
case the scale enable bit [27] is clear. But this doesn't seem to be
correct. The scale value seems to also matter if the scale mode bit
[26] is set. So both bit 26 and 27 depend on the value. Setting the
scale value to 0 while either bit is set results in a failed modeset on
HDMI (sink reports no signal).
After reset the scale value is 0x98, but according to the spec we have
to program it to 0x9a. So for consistency program it always to 0x9a
regardless of the scale enable bit.
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 36 ++++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 832e4e1..5246cfa 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -181,15 +181,15 @@ struct bxt_ddi_buf_trans {
*/
static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {
/* Idx NT mV diff db */
- { 52, 0, 0, 128, true }, /* 0: 400 0 */
- { 78, 0, 0, 85, false }, /* 1: 400 3.5 */
- { 104, 0, 0, 64, false }, /* 2: 400 6 */
- { 154, 0, 0, 43, false }, /* 3: 400 9.5 */
- { 77, 0, 0, 128, false }, /* 4: 600 0 */
- { 116, 0, 0, 85, false }, /* 5: 600 3.5 */
- { 154, 0, 0, 64, false }, /* 6: 600 6 */
- { 102, 0, 0, 128, false }, /* 7: 800 0 */
- { 154, 0, 0, 85, false }, /* 8: 800 3.5 */
+ { 52, 0x9A, 0, 128, true }, /* 0: 400 0 */
+ { 78, 0x9A, 0, 85, false }, /* 1: 400 3.5 */
+ { 104, 0x9A, 0, 64, false }, /* 2: 400 6 */
+ { 154, 0x9A, 0, 43, false }, /* 3: 400 9.5 */
+ { 77, 0x9A, 0, 128, false }, /* 4: 600 0 */
+ { 116, 0x9A, 0, 85, false }, /* 5: 600 3.5 */
+ { 154, 0x9A, 0, 64, false }, /* 6: 600 6 */
+ { 102, 0x9A, 0, 128, false }, /* 7: 800 0 */
+ { 154, 0x9A, 0, 85, false }, /* 8: 800 3.5 */
{ 154, 0x9A, 1, 128, false }, /* 9: 1200 0 */
};
@@ -198,15 +198,15 @@ static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {
*/
static const struct bxt_ddi_buf_trans bxt_ddi_translations_hdmi[] = {
/* Idx NT mV diff db */
- { 52, 0, 0, 128, false }, /* 0: 400 0 */
- { 52, 0, 0, 85, false }, /* 1: 400 3.5 */
- { 52, 0, 0, 64, false }, /* 2: 400 6 */
- { 42, 0, 0, 43, false }, /* 3: 400 9.5 */
- { 77, 0, 0, 128, false }, /* 4: 600 0 */
- { 77, 0, 0, 85, false }, /* 5: 600 3.5 */
- { 77, 0, 0, 64, false }, /* 6: 600 6 */
- { 102, 0, 0, 128, false }, /* 7: 800 0 */
- { 102, 0, 0, 85, false }, /* 8: 800 3.5 */
+ { 52, 0x9A, 0, 128, false }, /* 0: 400 0 */
+ { 52, 0x9A, 0, 85, false }, /* 1: 400 3.5 */
+ { 52, 0x9A, 0, 64, false }, /* 2: 400 6 */
+ { 42, 0x9A, 0, 43, false }, /* 3: 400 9.5 */
+ { 77, 0x9A, 0, 128, false }, /* 4: 600 0 */
+ { 77, 0x9A, 0, 85, false }, /* 5: 600 3.5 */
+ { 77, 0x9A, 0, 64, false }, /* 6: 600 6 */
+ { 102, 0x9A, 0, 128, false }, /* 7: 800 0 */
+ { 102, 0x9A, 0, 85, false }, /* 8: 800 3.5 */
{ 154, 0x9A, 1, 128, true }, /* 9: 1200 0 */
};
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting
2015-06-04 15:01 [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting Imre Deak
@ 2015-06-05 9:22 ` shuang.he
2015-06-10 16:18 ` Matt Roper
1 sibling, 0 replies; 5+ messages in thread
From: shuang.he @ 2015-06-05 9:22 UTC (permalink / raw)
To: shuang.he, lei.a.liu, intel-gfx, imre.deak
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6535
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 270/270 270/270
ILK 303/303 303/303
SNB 312/312 312/312
IVB 343/343 343/343
BYT 287/287 287/287
BDW 318/318 318/318
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting
2015-06-04 15:01 [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting Imre Deak
2015-06-05 9:22 ` shuang.he
@ 2015-06-10 16:18 ` Matt Roper
2015-06-11 10:34 ` Damien Lespiau
1 sibling, 1 reply; 5+ messages in thread
From: Matt Roper @ 2015-06-10 16:18 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
On Thu, Jun 04, 2015 at 06:01:35PM +0300, Imre Deak wrote:
> According to bspec the DDI PHY vswing scale value is "don't care" in
> case the scale enable bit [27] is clear. But this doesn't seem to be
> correct. The scale value seems to also matter if the scale mode bit
> [26] is set. So both bit 26 and 27 depend on the value. Setting the
> scale value to 0 while either bit is set results in a failed modeset on
> HDMI (sink reports no signal).
>
> After reset the scale value is 0x98, but according to the spec we have
> to program it to 0x9a. So for consistency program it always to 0x9a
> regardless of the scale enable bit.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
This patch successfully enables HDMI display for my team.
Tested-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 36 ++++++++++++++++++------------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 832e4e1..5246cfa 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -181,15 +181,15 @@ struct bxt_ddi_buf_trans {
> */
> static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {
> /* Idx NT mV diff db */
> - { 52, 0, 0, 128, true }, /* 0: 400 0 */
> - { 78, 0, 0, 85, false }, /* 1: 400 3.5 */
> - { 104, 0, 0, 64, false }, /* 2: 400 6 */
> - { 154, 0, 0, 43, false }, /* 3: 400 9.5 */
> - { 77, 0, 0, 128, false }, /* 4: 600 0 */
> - { 116, 0, 0, 85, false }, /* 5: 600 3.5 */
> - { 154, 0, 0, 64, false }, /* 6: 600 6 */
> - { 102, 0, 0, 128, false }, /* 7: 800 0 */
> - { 154, 0, 0, 85, false }, /* 8: 800 3.5 */
> + { 52, 0x9A, 0, 128, true }, /* 0: 400 0 */
> + { 78, 0x9A, 0, 85, false }, /* 1: 400 3.5 */
> + { 104, 0x9A, 0, 64, false }, /* 2: 400 6 */
> + { 154, 0x9A, 0, 43, false }, /* 3: 400 9.5 */
> + { 77, 0x9A, 0, 128, false }, /* 4: 600 0 */
> + { 116, 0x9A, 0, 85, false }, /* 5: 600 3.5 */
> + { 154, 0x9A, 0, 64, false }, /* 6: 600 6 */
> + { 102, 0x9A, 0, 128, false }, /* 7: 800 0 */
> + { 154, 0x9A, 0, 85, false }, /* 8: 800 3.5 */
> { 154, 0x9A, 1, 128, false }, /* 9: 1200 0 */
> };
>
> @@ -198,15 +198,15 @@ static const struct bxt_ddi_buf_trans bxt_ddi_translations_dp[] = {
> */
> static const struct bxt_ddi_buf_trans bxt_ddi_translations_hdmi[] = {
> /* Idx NT mV diff db */
> - { 52, 0, 0, 128, false }, /* 0: 400 0 */
> - { 52, 0, 0, 85, false }, /* 1: 400 3.5 */
> - { 52, 0, 0, 64, false }, /* 2: 400 6 */
> - { 42, 0, 0, 43, false }, /* 3: 400 9.5 */
> - { 77, 0, 0, 128, false }, /* 4: 600 0 */
> - { 77, 0, 0, 85, false }, /* 5: 600 3.5 */
> - { 77, 0, 0, 64, false }, /* 6: 600 6 */
> - { 102, 0, 0, 128, false }, /* 7: 800 0 */
> - { 102, 0, 0, 85, false }, /* 8: 800 3.5 */
> + { 52, 0x9A, 0, 128, false }, /* 0: 400 0 */
> + { 52, 0x9A, 0, 85, false }, /* 1: 400 3.5 */
> + { 52, 0x9A, 0, 64, false }, /* 2: 400 6 */
> + { 42, 0x9A, 0, 43, false }, /* 3: 400 9.5 */
> + { 77, 0x9A, 0, 128, false }, /* 4: 600 0 */
> + { 77, 0x9A, 0, 85, false }, /* 5: 600 3.5 */
> + { 77, 0x9A, 0, 64, false }, /* 6: 600 6 */
> + { 102, 0x9A, 0, 128, false }, /* 7: 800 0 */
> + { 102, 0x9A, 0, 85, false }, /* 8: 800 3.5 */
> { 154, 0x9A, 1, 128, true }, /* 9: 1200 0 */
> };
>
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting
2015-06-10 16:18 ` Matt Roper
@ 2015-06-11 10:34 ` Damien Lespiau
2015-06-12 7:48 ` Jani Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Damien Lespiau @ 2015-06-11 10:34 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Wed, Jun 10, 2015 at 09:18:29AM -0700, Matt Roper wrote:
> On Thu, Jun 04, 2015 at 06:01:35PM +0300, Imre Deak wrote:
> > According to bspec the DDI PHY vswing scale value is "don't care" in
> > case the scale enable bit [27] is clear. But this doesn't seem to be
> > correct. The scale value seems to also matter if the scale mode bit
> > [26] is set. So both bit 26 and 27 depend on the value. Setting the
> > scale value to 0 while either bit is set results in a failed modeset on
> > HDMI (sink reports no signal).
> >
> > After reset the scale value is 0x98, but according to the spec we have
> > to program it to 0x9a. So for consistency program it always to 0x9a
> > regardless of the scale enable bit.
> >
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
>
> This patch successfully enables HDMI display for my team.
>
> Tested-by: Matt Roper <matthew.d.roper@intel.com>
I believe this should be enough of a good reason for merging at this
stage.
Acked-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting
2015-06-11 10:34 ` Damien Lespiau
@ 2015-06-12 7:48 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2015-06-12 7:48 UTC (permalink / raw)
To: Damien Lespiau, Matt Roper; +Cc: intel-gfx
On Thu, 11 Jun 2015, Damien Lespiau <damien.lespiau@intel.com> wrote:
> On Wed, Jun 10, 2015 at 09:18:29AM -0700, Matt Roper wrote:
>> On Thu, Jun 04, 2015 at 06:01:35PM +0300, Imre Deak wrote:
>> > According to bspec the DDI PHY vswing scale value is "don't care" in
>> > case the scale enable bit [27] is clear. But this doesn't seem to be
>> > correct. The scale value seems to also matter if the scale mode bit
>> > [26] is set. So both bit 26 and 27 depend on the value. Setting the
>> > scale value to 0 while either bit is set results in a failed modeset on
>> > HDMI (sink reports no signal).
>> >
>> > After reset the scale value is 0x98, but according to the spec we have
>> > to program it to 0x9a. So for consistency program it always to 0x9a
>> > regardless of the scale enable bit.
>> >
>> > Signed-off-by: Imre Deak <imre.deak@intel.com>
>>
>> This patch successfully enables HDMI display for my team.
>>
>> Tested-by: Matt Roper <matthew.d.roper@intel.com>
>
> I believe this should be enough of a good reason for merging at this
> stage.
>
> Acked-by: Damien Lespiau <damien.lespiau@intel.com>
Pushed to drm-intel-next-queued, thanks for the patch and testing/ack.
BR,
Jani.
>
> --
> Damien
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-12 7:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-04 15:01 [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting Imre Deak
2015-06-05 9:22 ` shuang.he
2015-06-10 16:18 ` Matt Roper
2015-06-11 10:34 ` Damien Lespiau
2015-06-12 7:48 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox