From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] drm/i915: constify find_section in VBT parsing Date: Tue, 12 May 2015 15:30:32 +0300 Message-ID: <871tim3rmf.fsf@intel.com> References: <1429100309-21983-1-git-send-email-jani.nikula@intel.com> <20150512120613.GW18908@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F76E6E304 for ; Tue, 12 May 2015 05:28:26 -0700 (PDT) In-Reply-To: <20150512120613.GW18908@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxMiBNYXkgMjAxNSwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gV2VkLCBBcHIgMTUsIDIwMTUgYXQgMDM6MTg6MjhQTSAr MDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IE1ha2UgaW5wdXQgYW5kIG91dHB1dCBvZiBmaW5k X3NlY3Rpb24gY29uc3QsIGFuZCBmaXggdGhlIGZhbGxvdXQuIFdlCj4+IHNob3VsZG4ndCBtb2Rp ZnkgdGhlIFZCVCwgc28gbWFrZSB0aGUgY29tcGlsZXIgaGVscCB1cyBoZXJlLgo+PiAKPj4gU2ln bmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPj4gLS0tCj4+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgfCA2MCArKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRpb25z KCspLCAyOSBkZWxldGlvbnMoLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9iaW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPj4g aW5kZXggYzA4MzY4YzAzZGFkLi40ZTNmM2Y0MjcxNzggMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9iaW9zLmMKPj4gQEAgLTM2LDEwICszNiwxMSBAQAo+PiAgCj4+ICBzdGF0aWMgaW50IHBh bmVsX3R5cGU7Cj4+ICAKPj4gLXN0YXRpYyB2b2lkICoKPj4gLWZpbmRfc2VjdGlvbihzdHJ1Y3Qg YmRiX2hlYWRlciAqYmRiLCBpbnQgc2VjdGlvbl9pZCkKPj4gK3N0YXRpYyBjb25zdCB2b2lkICoK Pj4gK2ZpbmRfc2VjdGlvbihjb25zdCB2b2lkICpfYmRiLCBpbnQgc2VjdGlvbl9pZCkKPj4gIHsK Pj4gLQl1OCAqYmFzZSA9ICh1OCAqKWJkYjsKPj4gKwljb25zdCBzdHJ1Y3QgYmRiX2hlYWRlciAq YmRiID0gX2JkYjsKPj4gKwljb25zdCB1OCAqYmFzZSA9IF9iZGI7Cj4+ICAJaW50IGluZGV4ID0g MDsKPj4gIAl1MTYgdG90YWwsIGN1cnJlbnRfc2l6ZTsKPj4gIAl1OCBjdXJyZW50X2lkOwo+PiBA QCAtNTMsNyArNTQsNyBAQCBmaW5kX3NlY3Rpb24oc3RydWN0IGJkYl9oZWFkZXIgKmJkYiwgaW50 IHNlY3Rpb25faWQpCj4+ICAJCWN1cnJlbnRfaWQgPSAqKGJhc2UgKyBpbmRleCk7Cj4+ICAJCWlu ZGV4Kys7Cj4+ICAKPj4gLQkJY3VycmVudF9zaXplID0gKigodTE2ICopKGJhc2UgKyBpbmRleCkp Owo+PiArCQljdXJyZW50X3NpemUgPSAqKChjb25zdCB1MTYgKikoYmFzZSArIGluZGV4KSk7Cj4+ ICAJCWluZGV4ICs9IDI7Cj4+ICAKPj4gIAkJaWYgKGluZGV4ICsgY3VycmVudF9zaXplID4gdG90 YWwpCj4+IEBAIC02OSw3ICs3MCw3IEBAIGZpbmRfc2VjdGlvbihzdHJ1Y3QgYmRiX2hlYWRlciAq YmRiLCBpbnQgc2VjdGlvbl9pZCkKPj4gIH0KPj4gIAo+PiAgc3RhdGljIHUxNgo+PiAtZ2V0X2Js b2Nrc2l6ZSh2b2lkICpwKQo+PiArZ2V0X2Jsb2Nrc2l6ZShjb25zdCB2b2lkICpwKQo+PiAgewo+ PiAgCXUxNiAqYmxvY2tfcHRyLCBibG9ja19zaXplOwo+PiAgCj4+IEBAIC0zNTAsNyArMzUxLDcg QEAgc3RhdGljIHZvaWQKPj4gIHBhcnNlX3Nkdm9fcGFuZWxfZGF0YShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAJCSAgICAgIHN0cnVjdCBiZGJfaGVhZGVyICpiZGIpCj4+ ICB7Cj4+IC0Jc3RydWN0IGx2ZHNfZHZvX3RpbWluZyAqZHZvX3RpbWluZzsKPj4gKwljb25zdCBz dHJ1Y3QgbHZkc19kdm9fdGltaW5nICpkdm9fdGltaW5nOwo+PiAgCXN0cnVjdCBkcm1fZGlzcGxh eV9tb2RlICpwYW5lbF9maXhlZF9tb2RlOwo+PiAgCWludCBpbmRleDsKPj4gIAo+PiBAQCAtMzYx LDcgKzM2Miw3IEBAIHBhcnNlX3Nkdm9fcGFuZWxfZGF0YShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4+ICAJfQo+PiAgCj4+ICAJaWYgKGluZGV4ID09IC0xKSB7Cj4+IC0JCXN0 cnVjdCBiZGJfc2R2b19sdmRzX29wdGlvbnMgKnNkdm9fbHZkc19vcHRpb25zOwo+PiArCQljb25z dCBzdHJ1Y3QgYmRiX3Nkdm9fbHZkc19vcHRpb25zICpzZHZvX2x2ZHNfb3B0aW9uczsKPj4gIAo+ PiAgCQlzZHZvX2x2ZHNfb3B0aW9ucyA9IGZpbmRfc2VjdGlvbihiZGIsIEJEQl9TRFZPX0xWRFNf T1BUSU9OUyk7Cj4+ICAJCWlmICghc2R2b19sdmRzX29wdGlvbnMpCj4+IEBAIC00MDUsNyArNDA2 LDcgQEAgcGFyc2VfZ2VuZXJhbF9mZWF0dXJlcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4+ICAJCSAgICAgICBzdHJ1Y3QgYmRiX2hlYWRlciAqYmRiKQo+PiAgewo+PiAgCXN0 cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkZXZfcHJpdi0+ZGV2Owo+PiAtCXN0cnVjdCBiZGJfZ2Vu ZXJhbF9mZWF0dXJlcyAqZ2VuZXJhbDsKPj4gKwljb25zdCBzdHJ1Y3QgYmRiX2dlbmVyYWxfZmVh dHVyZXMgKmdlbmVyYWw7Cj4+ICAKPj4gIAlnZW5lcmFsID0gZmluZF9zZWN0aW9uKGJkYiwgQkRC X0dFTkVSQUxfRkVBVFVSRVMpOwo+PiAgCWlmIChnZW5lcmFsKSB7Cj4+IEBAIC00MzAsNyArNDMx LDcgQEAgc3RhdGljIHZvaWQKPj4gIHBhcnNlX2dlbmVyYWxfZGVmaW5pdGlvbnMoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgCQkJICBzdHJ1Y3QgYmRiX2hlYWRlciAqYmRi KQo+PiAgewo+PiAtCXN0cnVjdCBiZGJfZ2VuZXJhbF9kZWZpbml0aW9ucyAqZ2VuZXJhbDsKPj4g Kwljb25zdCBzdHJ1Y3QgYmRiX2dlbmVyYWxfZGVmaW5pdGlvbnMgKmdlbmVyYWw7Cj4+ICAKPj4g IAlnZW5lcmFsID0gZmluZF9zZWN0aW9uKGJkYiwgQkRCX0dFTkVSQUxfREVGSU5JVElPTlMpOwo+ PiAgCWlmIChnZW5lcmFsKSB7Cj4+IEBAIC00NDcsMTAgKzQ0OCwxMCBAQCBwYXJzZV9nZW5lcmFs X2RlZmluaXRpb25zKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gIAl9Cj4+ ICB9Cj4+ICAKPj4gLXN0YXRpYyB1bmlvbiBjaGlsZF9kZXZpY2VfY29uZmlnICoKPj4gLWNoaWxk X2RldmljZV9wdHIoc3RydWN0IGJkYl9nZW5lcmFsX2RlZmluaXRpb25zICpwX2RlZnMsIGludCBp KQo+PiArc3RhdGljIGNvbnN0IHVuaW9uIGNoaWxkX2RldmljZV9jb25maWcgKgo+PiArY2hpbGRf ZGV2aWNlX3B0cihjb25zdCBzdHJ1Y3QgYmRiX2dlbmVyYWxfZGVmaW5pdGlvbnMgKnBfZGVmcywg aW50IGkpCj4+ICB7Cj4+IC0JcmV0dXJuICh2b2lkICopICZwX2RlZnMtPmRldmljZXNbaSAqIHBf ZGVmcy0+Y2hpbGRfZGV2X3NpemVdOwo+PiArCXJldHVybiAoY29uc3Qgdm9pZCAqKSAmcF9kZWZz LT5kZXZpY2VzW2kgKiBwX2RlZnMtPmNoaWxkX2Rldl9zaXplXTsKPj4gIH0KPj4gIAo+PiAgc3Rh dGljIHZvaWQKPj4gQEAgLTQ1OCw4ICs0NTksOCBAQCBwYXJzZV9zZHZvX2RldmljZV9tYXBwaW5n KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gIAkJCSAgc3RydWN0IGJkYl9o ZWFkZXIgKmJkYikKPj4gIHsKPj4gIAlzdHJ1Y3Qgc2R2b19kZXZpY2VfbWFwcGluZyAqcF9tYXBw aW5nOwo+PiAtCXN0cnVjdCBiZGJfZ2VuZXJhbF9kZWZpbml0aW9ucyAqcF9kZWZzOwo+PiAtCXVu aW9uIGNoaWxkX2RldmljZV9jb25maWcgKnBfY2hpbGQ7Cj4+ICsJY29uc3Qgc3RydWN0IGJkYl9n ZW5lcmFsX2RlZmluaXRpb25zICpwX2RlZnM7Cj4+ICsJY29uc3QgdW5pb24gY2hpbGRfZGV2aWNl X2NvbmZpZyAqcF9jaGlsZDsKPj4gIAlpbnQgaSwgY2hpbGRfZGV2aWNlX251bSwgY291bnQ7Cj4+ ICAJdTE2CWJsb2NrX3NpemU7Cj4+ICAKPj4gQEAgLTU0Nyw3ICs1NDgsNyBAQCBzdGF0aWMgdm9p ZAo+PiAgcGFyc2VfZHJpdmVyX2ZlYXR1cmVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwKPj4gIAkJICAgICAgIHN0cnVjdCBiZGJfaGVhZGVyICpiZGIpCj4+ICB7Cj4+IC0Jc3Ry dWN0IGJkYl9kcml2ZXJfZmVhdHVyZXMgKmRyaXZlcjsKPj4gKwljb25zdCBzdHJ1Y3QgYmRiX2Ry aXZlcl9mZWF0dXJlcyAqZHJpdmVyOwo+PiAgCj4+ICAJZHJpdmVyID0gZmluZF9zZWN0aW9uKGJk YiwgQkRCX0RSSVZFUl9GRUFUVVJFUyk7Cj4+ICAJaWYgKCFkcml2ZXIpCj4+IEBAIC01NzMsOSAr NTc0LDkgQEAgcGFyc2VfZHJpdmVyX2ZlYXR1cmVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwKPj4gIHN0YXRpYyB2b2lkCj4+ICBwYXJzZV9lZHAoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LCBzdHJ1Y3QgYmRiX2hlYWRlciAqYmRiKQo+PiAgewo+PiAtCXN0cnVj dCBiZGJfZWRwICplZHA7Cj4+IC0Jc3RydWN0IGVkcF9wb3dlcl9zZXEgKmVkcF9wcHM7Cj4+IC0J c3RydWN0IGVkcF9saW5rX3BhcmFtcyAqZWRwX2xpbmtfcGFyYW1zOwo+PiArCWNvbnN0IHN0cnVj dCBiZGJfZWRwICplZHA7Cj4+ICsJY29uc3Qgc3RydWN0IGVkcF9wb3dlcl9zZXEgKmVkcF9wcHM7 Cj4+ICsJY29uc3Qgc3RydWN0IGVkcF9saW5rX3BhcmFtcyAqZWRwX2xpbmtfcGFyYW1zOwo+PiAg Cj4+ICAJZWRwID0gZmluZF9zZWN0aW9uKGJkYiwgQkRCX0VEUCk7Cj4+ICAJaWYgKCFlZHApIHsK Pj4gQEAgLTY4MCw4ICs2ODEsOCBAQCBwYXJzZV9lZHAoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LCBzdHJ1Y3QgYmRiX2hlYWRlciAqYmRiKQo+PiAgc3RhdGljIHZvaWQKPj4gIHBh cnNlX3BzcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHN0cnVjdCBiZGJfaGVh ZGVyICpiZGIpCj4+ICB7Cj4+IC0Jc3RydWN0IGJkYl9wc3IgKnBzcjsKPj4gLQlzdHJ1Y3QgcHNy X3RhYmxlICpwc3JfdGFibGU7Cj4+ICsJY29uc3Qgc3RydWN0IGJkYl9wc3IgKnBzcjsKPj4gKwlj b25zdCBzdHJ1Y3QgcHNyX3RhYmxlICpwc3JfdGFibGU7Cj4+ICAKPj4gIAlwc3IgPSBmaW5kX3Nl Y3Rpb24oYmRiLCBCREJfUFNSKTsKPj4gIAlpZiAoIXBzcikgewo+PiBAQCAtNzkxLDExICs3OTIs MTIgQEAgc3RhdGljIHU4ICpnb3RvX25leHRfc2VxdWVuY2UodTggKmRhdGEsIGludCAqc2l6ZSkK Pj4gIHN0YXRpYyB2b2lkCj4+ICBwYXJzZV9taXBpKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwgc3RydWN0IGJkYl9oZWFkZXIgKmJkYikKPj4gIHsKPj4gLQlzdHJ1Y3QgYmRiX21p cGlfY29uZmlnICpzdGFydDsKPj4gLQlzdHJ1Y3QgYmRiX21pcGlfc2VxdWVuY2UgKnNlcXVlbmNl Owo+PiAtCXN0cnVjdCBtaXBpX2NvbmZpZyAqY29uZmlnOwo+PiAtCXN0cnVjdCBtaXBpX3Bwc19k YXRhICpwcHM7Cj4+IC0JdTggKmRhdGEsICpzZXFfZGF0YTsKPj4gKwljb25zdCBzdHJ1Y3QgYmRi X21pcGlfY29uZmlnICpzdGFydDsKPj4gKwljb25zdCBzdHJ1Y3QgYmRiX21pcGlfc2VxdWVuY2Ug KnNlcXVlbmNlOwo+PiArCWNvbnN0IHN0cnVjdCBtaXBpX2NvbmZpZyAqY29uZmlnOwo+PiArCWNv bnN0IHN0cnVjdCBtaXBpX3Bwc19kYXRhICpwcHM7Cj4+ICsJdTggKmRhdGE7Cj4KPiBJdCB3b3Vs ZCBzZWVtIHRoaXMgZ3V5IGNvdWxkIGJlIGNvbnN0aWZpZWQgYXMgd2VsbCwgd2l0aCBhIGJpdCBv ZiBleHRyYQo+IGVmZm9ydCB0aGF0IGlzLgoKUGVyaGFwcywgYnV0IHRoYXQncyBub3QgYWN0dWFs bHkgdXNlZCB0byBwb2ludCB0aGF0IHRoZSBWQlQgaXRzZWxmLCBidXQKcmF0aGVyIGEgY29weSBv ZiBpdCwgc28gbm90IGFzIGltcG9ydGFudC4gTWF5YmUgbGF0ZXIuIDspCgpKYW5pLgoKPgo+IEJ1 dCB0aGUgcGF0Y2ggYXMgaXMgbG9va3MgcmVhc29uYWJsZSBzbzoKPiBSZXZpZXdlZC1ieTogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPgo+PiArCWNvbnN0 IHU4ICpzZXFfZGF0YTsKPj4gIAlpbnQgaSwgcGFuZWxfaWQsIHNlcV9zaXplOwo+PiAgCXUxNiBi bG9ja19zaXplOwo+PiAgCj4+IEBAIC0xMDYzLDggKzEwNjUsOSBAQCBzdGF0aWMgdm9pZAo+PiAg cGFyc2VfZGV2aWNlX21hcHBpbmcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ PiAgCQkgICAgICAgc3RydWN0IGJkYl9oZWFkZXIgKmJkYikKPj4gIHsKPj4gLQlzdHJ1Y3QgYmRi X2dlbmVyYWxfZGVmaW5pdGlvbnMgKnBfZGVmczsKPj4gLQl1bmlvbiBjaGlsZF9kZXZpY2VfY29u ZmlnICpwX2NoaWxkLCAqY2hpbGRfZGV2X3B0cjsKPj4gKwljb25zdCBzdHJ1Y3QgYmRiX2dlbmVy YWxfZGVmaW5pdGlvbnMgKnBfZGVmczsKPj4gKwljb25zdCB1bmlvbiBjaGlsZF9kZXZpY2VfY29u ZmlnICpwX2NoaWxkOwo+PiArCXVuaW9uIGNoaWxkX2RldmljZV9jb25maWcgKmNoaWxkX2Rldl9w dHI7Cj4+ICAJaW50IGksIGNoaWxkX2RldmljZV9udW0sIGNvdW50Owo+PiAgCXUxNglibG9ja19z aXplOwo+PiAgCj4+IEBAIC0xMTIxLDggKzExMjQsNyBAQCBwYXJzZV9kZXZpY2VfbWFwcGluZyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ICAKPj4gIAkJY2hpbGRfZGV2X3B0 ciA9IGRldl9wcml2LT52YnQuY2hpbGRfZGV2ICsgY291bnQ7Cj4+ICAJCWNvdW50Kys7Cj4+IC0J CW1lbWNweSgodm9pZCAqKWNoaWxkX2Rldl9wdHIsICh2b2lkICopcF9jaGlsZCwKPj4gLQkJCQkJ c2l6ZW9mKCpwX2NoaWxkKSk7Cj4+ICsJCW1lbWNweShjaGlsZF9kZXZfcHRyLCBwX2NoaWxkLCBz aXplb2YoKnBfY2hpbGQpKTsKPj4gIAl9Cj4+ICAJcmV0dXJuOwo+PiAgfQo+PiAtLSAKPj4gMi4x LjQKPj4gCj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cj4KPiAtLSAKPiBWaWxsZSBTeXJqw6Rsw6QKPiBJbnRlbCBPVEMKCi0tIApKYW5pIE5p a3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK