From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Ensure plane->state->fb stays in sync with plane->fb Date: Fri, 13 Mar 2015 14:38:16 +0200 Message-ID: <871tktqdhj.fsf@intel.com> References: <87ioe6qt90.fsf@intel.com> <20150312161223.GX27526@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 404896E47A for ; Fri, 13 Mar 2015 05:36:48 -0700 (PDT) In-Reply-To: <20150312161223.GX27526@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: Xi Ruoyao , daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAxMiBNYXIgMjAxNSwgTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNv bT4gd3JvdGU6Cj4gT24gVGh1LCBNYXIgMTIsIDIwMTUgYXQgMDI6NDU6MzFQTSArMDIwMCwgSmFu aSBOaWt1bGEgd3JvdGU6Cj4+IAo+PiBNYXR0LCBwbGVhc2UgcmV2aWV3IG9yIHN1Z2dlc3QgYW4g YWx0ZXJuYXRpdmUgZm9yIHY0LjAtcmMuCj4+IAo+PiBUaGFua3MsCj4+IEphbmkuCj4KPiBZZXAs IHRoaXMgbG9va3MgZ29vZCB0byBtZS4gIFNvCj4KPiBSZXZpZXdlZC1ieTogTWF0dCBSb3BlciA8 bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KClB1c2hlZCB0byBkcm0taW50ZWwtZml4ZXMsIHRo YW5rcyBmb3IgdGhlIHBhdGNoIGFuZCByZXZpZXcuCgpCUiwKSmFuaS4KCgo+Cj4KPiBNYXR0Cj4K Pj4gCj4+IAo+PiBPbiBUaHUsIDEyIE1hciAyMDE1LCBYaSBSdW95YW8gPHhyeTExMUBvdXRsb29r LmNvbT4gd3JvdGU6Cj4+ID4gcGxhbmUtPnN0YXRlLT5mYiBhbmQgcGxhbmUtPmZiIHNob3VsZCBh bHdheXMgcmVmZXJlbmNlIHRoZSBzYW1lIEZCIHNvCj4+ID4gdGhhdCBhdG9taWMgYW5kIGxlZ2Fj eSBjb2RlcGF0aHMgaGF2ZSB0aGUgc2FtZSB2aWV3IG9mIGRpc3BsYXkgc3RhdGUuCj4+ID4gSG93 ZXZlciwgdGhlcmUgYXJlIHNvbWUgcGxhY2VzIGluIGtlcm5lbCBjb2RlIHRoYXQgZGlyZWN0bHkg c2V0Cj4+ID4gcGxhbmUtPmZiIGFuZCBuZWdsZWN0IHRvIHVwZGF0ZSBwbGFuZS0+c3RhdGUtPmZi LiBJZiB3ZSBuZXZlciBkbyBhCj4+ID4gc3VjY2Vzc2Z1bCB1cGRhdGUgdGhyb3VnaCB0aGUgYXRv bWljIHBpcGVsaW5lLCB0aGUgUm1GQiBjbGVhbnVwIGNvZGUKPj4gPiB3aWxsIGxvb2sgYXQgdGhl IHBsYW5lLT5zdGF0ZS0+ZmIgcG9pbnRlciwgd2hpY2ggaGFzIG5ldmVyIGFjdHVhbGx5Cj4+ID4g YmVlbiBzZXQgdG8gYSBsZWdpdGltYXRlIHZhbHVlLCBhbmQgdHJ5IHRvIGNsZWFuIGl0IHVwLCBs ZWFkaW5nIHRvCj4+ID4gQlVHJ3MuCj4+ID4KPj4gPiBBZGQgYSBxdWljayBoZWxwZXIgZnVuY3Rp b24gdG8gc3luY2hyb25pemUgcGxhbmUtPnN0YXRlLT5mYiB3aXRoCj4+ID4gcGxhbmUtPmZiIGFu ZCBjYWxsIGl0IGV2ZXJ5d2hlcmUgdGhlIGRyaXZlciB0cmllcyB0byBtYW51YWxseSBzZXQKPj4g PiBwbGFuZS0+ZmIgb3V0c2lkZSBvZiB0aGUgYXRvbWljIHBpcGVsaW5lLiBJbiB0aGlzIGZ1bmN0 aW9uLCB1c2UKPj4gPiBkcm1fYXRvbWljX3NldF9mYl9mb3JfcGxhbmUgaW5zdGVhZCBvZiB3cml0 aW5nIHBsYW5lLT5zdGF0ZS0+ZmIKPj4gPiBkaXJlY3RseSB0byBrZWVwIHRoZSByZWZlcmVuY2Ug Y291bnQgcmlnaHQuCj4+ID4KPj4gPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9w Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg5MDkKPj4gPiBCdWd6aWxsYTogaHR0cHM6Ly9idWd6aWxs YS5rZXJuZWwub3JnL3Nob3dfYnVnLmNnaT9pZD05MzcxMQo+PiA+IFNpZ25lZC1vZmYtYnk6IE1h dHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4+ID4gU2lnbmVkLW9mZi1ieTog RGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPj4gPiBTaWduZWQtb2ZmLWJ5 OiBYaSBSdW95YW8gPHhyeTExMUBvdXRsb29rLmNvbT4KPj4gPiAtLS0KPj4gPiAgVGhpcyBpcyBt b2RpZmllZCBmcm9tIE1hdHQgUm9wZXIncyBwYXRjaCB0byBkcm0taW50ZWwtbmlnaHRseSB3aXRo IAo+PiA+ICBjb21taXQgaWQKPj4gPgo+PiA+ICAJYWZkNjVlYjRjYzA1NzhhOWMwN2Q2MjFhY2Ri OGE1NzBlMjc4MmJmNwo+PiA+Cj4+ID4gIEhvd2V2ZXIgdGhpcyBidWcgZXhpc3RzIGluIG1haW5s aW5lIGtlcm5lbCB0b28sIHNvIEkgY3JlYXRlZCB0aGlzIHRvCj4+ID4gIGZpeCBpdCBpbiBtYWlu bGluZSBrZXJuZWwuCj4+ID4KPj4gPiAgQSBtaW5vciBjaGFuZ2UgaXMgdG8gdXNlIGRybV9hdG9t aWNfc2V0X2ZiX2Zvcl9wbGFuZSBpbnN0ZWFkIG9mCj4+ID4gIHVwZGF0ZSByZWZlcmVuY2UgY291 bnQgbWFudWFsbHkuCj4+ID4KPj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIHwgMTcgKysrKysrKysrKysrKysrKysKPj4gPiAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2Vy dGlvbnMoKykKPj4gPgo+PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gPiBp bmRleCBlNzMwNzg5Li5jNDgzZjJmIDEwMDY0NAo+PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+PiA+IEBAIC0zNyw2ICszNyw3IEBACj4+ID4gICNpbmNsdWRlIDxkcm0vaTkx NV9kcm0uaD4KPj4gPiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4+ID4gICNpbmNsdWRlICJpOTE1 X3RyYWNlLmgiCj4+ID4gKyNpbmNsdWRlIDxkcm0vZHJtX2F0b21pYy5oPgo+PiA+ICAjaW5jbHVk ZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+Cj4+ID4gICNpbmNsdWRlIDxkcm0vZHJtX2RwX2hl bHBlci5oPgo+PiA+ICAjaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBlci5oPgo+PiA+IEBAIC0y NDE2LDYgKzI0MTcsMTQgQEAgb3V0X3VucmVmX29iajoKPj4gPiAgCXJldHVybiBmYWxzZTsKPj4g PiAgfQo+PiA+ICAKPj4gPiArLyogVXBkYXRlIHBsYW5lLT5zdGF0ZS0+ZmIgdG8gbWF0Y2ggcGxh bmUtPmZiIGFmdGVyIGRyaXZlci1pbnRlcm5hbCB1cGRhdGVzICovCj4+ID4gK3N0YXRpYyB2b2lk Cj4+ID4gK3VwZGF0ZV9zdGF0ZV9mYihzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSkKPj4gPiArewo+ PiA+ICsJaWYgKHBsYW5lLT5mYiAhPSBwbGFuZS0+c3RhdGUtPmZiKQo+PiA+ICsJCWRybV9hdG9t aWNfc2V0X2ZiX2Zvcl9wbGFuZShwbGFuZS0+c3RhdGUsIHBsYW5lLT5mYik7Cj4+ID4gK30KPj4g PiArCj4+ID4gIHN0YXRpYyB2b2lkCj4+ID4gIGludGVsX2ZpbmRfcGxhbmVfb2JqKHN0cnVjdCBp bnRlbF9jcnRjICppbnRlbF9jcnRjLAo+PiA+ICAJCSAgICAgc3RydWN0IGludGVsX2luaXRpYWxf cGxhbmVfY29uZmlnICpwbGFuZV9jb25maWcpCj4+ID4gQEAgLTI0NjIsNiArMjQ3MSw4IEBAIGlu dGVsX2ZpbmRfcGxhbmVfb2JqKHN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjLAo+PiA+ICAJ CQlicmVhazsKPj4gPiAgCQl9Cj4+ID4gIAl9Cj4+ID4gKwo+PiA+ICsJdXBkYXRlX3N0YXRlX2Zi KGludGVsX2NydGMtPmJhc2UucHJpbWFyeSk7Cj4+ID4gIH0KPj4gPiAgCj4+ID4gIHN0YXRpYyB2 b2lkIGk5eHhfdXBkYXRlX3ByaW1hcnlfcGxhbmUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+PiA+ IEBAIC02NjUwLDYgKzY2NjEsNyBAQCBpOXh4X2dldF9pbml0aWFsX3BsYW5lX2NvbmZpZyhzdHJ1 Y3QgaW50ZWxfY3J0YyAqY3J0YywKPj4gPiAgCQkgICAgICBwbGFuZV9jb25maWctPnNpemUpOwo+ PiA+ICAKPj4gPiAgCWNydGMtPmJhc2UucHJpbWFyeS0+ZmIgPSBmYjsKPj4gPiArCXVwZGF0ZV9z dGF0ZV9mYihjcnRjLT5iYXNlLnByaW1hcnkpOwo+PiA+ICB9Cj4+ID4gIAo+PiA+ICBzdGF0aWMg dm9pZCBjaHZfY3J0Y19jbG9ja19nZXQoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4+ID4gQEAg LTc2ODcsNiArNzY5OSw3IEBAIHNreWxha2VfZ2V0X2luaXRpYWxfcGxhbmVfY29uZmlnKHN0cnVj dCBpbnRlbF9jcnRjICpjcnRjLAo+PiA+ICAJCSAgICAgIHBsYW5lX2NvbmZpZy0+c2l6ZSk7Cj4+ ID4gIAo+PiA+ICAJY3J0Yy0+YmFzZS5wcmltYXJ5LT5mYiA9IGZiOwo+PiA+ICsJdXBkYXRlX3N0 YXRlX2ZiKGNydGMtPmJhc2UucHJpbWFyeSk7Cj4+ID4gIAlyZXR1cm47Cj4+ID4gIAo+PiA+ICBl cnJvcjoKPj4gPiBAQCAtNzc3OCw2ICs3NzkxLDcgQEAgaXJvbmxha2VfZ2V0X2luaXRpYWxfcGxh bmVfY29uZmlnKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+PiA+ICAJCSAgICAgIHBsYW5lX2Nv bmZpZy0+c2l6ZSk7Cj4+ID4gIAo+PiA+ICAJY3J0Yy0+YmFzZS5wcmltYXJ5LT5mYiA9IGZiOwo+ PiA+ICsJdXBkYXRlX3N0YXRlX2ZiKGNydGMtPmJhc2UucHJpbWFyeSk7Cj4+ID4gIH0KPj4gPiAg Cj4+ID4gIHN0YXRpYyBib29sIGlyb25sYWtlX2dldF9waXBlX2NvbmZpZyhzdHJ1Y3QgaW50ZWxf Y3J0YyAqY3J0YywKPj4gPiBAQCAtOTgxNiw2ICs5ODMwLDcgQEAgc3RhdGljIGludCBpbnRlbF9j cnRjX3BhZ2VfZmxpcChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4+ID4gIAlkcm1fZ2VtX29iamVj dF9yZWZlcmVuY2UoJm9iai0+YmFzZSk7Cj4+ID4gIAo+PiA+ICAJY3J0Yy0+cHJpbWFyeS0+ZmIg PSBmYjsKPj4gPiArCXVwZGF0ZV9zdGF0ZV9mYihjcnRjLT5wcmltYXJ5KTsKPj4gPiAgCj4+ID4g IAl3b3JrLT5wZW5kaW5nX2ZsaXBfb2JqID0gb2JqOwo+PiA+ICAKPj4gPiBAQCAtOTg4NCw2ICs5 ODk5LDcgQEAgY2xlYW51cF91bnBpbjoKPj4gPiAgY2xlYW51cF9wZW5kaW5nOgo+PiA+ICAJYXRv bWljX2RlYygmaW50ZWxfY3J0Yy0+dW5waW5fd29ya19jb3VudCk7Cj4+ID4gIAljcnRjLT5wcmlt YXJ5LT5mYiA9IG9sZF9mYjsKPj4gPiArCXVwZGF0ZV9zdGF0ZV9mYihjcnRjLT5wcmltYXJ5KTsK Pj4gPiAgCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZ3b3JrLT5vbGRfZmJfb2JqLT5iYXNl KTsKPj4gPiAgCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+PiA+ICAJ bXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4+ID4gQEAgLTEzNzE4LDYgKzEzNzM0 LDcgQEAgdm9pZCBpbnRlbF9tb2Rlc2V0X2dlbV9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYp Cj4+ID4gIAkJCQkgIHRvX2ludGVsX2NydGMoYyktPnBpcGUpOwo+PiA+ICAJCQlkcm1fZnJhbWVi dWZmZXJfdW5yZWZlcmVuY2UoYy0+cHJpbWFyeS0+ZmIpOwo+PiA+ICAJCQljLT5wcmltYXJ5LT5m YiA9IE5VTEw7Cj4+ID4gKwkJCXVwZGF0ZV9zdGF0ZV9mYihjLT5wcmltYXJ5KTsKPj4gPiAgCQl9 Cj4+ID4gIAl9Cj4+ID4gIAltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPj4gPiAt LSAKPj4gPiAxLjkuMQo+PiA+Cj4+IAo+PiAtLSAKPj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4g U291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCj4KPiAtLSAKPiBNYXR0IFJvcGVyCj4gR3JhcGhpY3Mg U29mdHdhcmUgRW5naW5lZXIKPiBJb1RHIFBsYXRmb3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQK PiBJbnRlbCBDb3Jwb3JhdGlvbgo+ICg5MTYpIDM1Ni0yNzk1CgotLSAKSmFuaSBOaWt1bGEsIElu dGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==