From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 6/6] drm/i915: Remove most INVALID_PIPE checks from the backlight code Date: Fri, 07 Nov 2014 15:26:32 +0200 Message-ID: <871tpf16rb.fsf@intel.com> References: <1415351764-3514-7-git-send-email-ville.syrjala@linux.intel.com> <1415366423-13016-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id B862B6E793 for ; Fri, 7 Nov 2014 05:26:37 -0800 (PST) In-Reply-To: <1415366423-13016-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAwNyBOb3YgMjAxNCwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IE5vdyB0aGF0IHRoZSBiYWNrbGlnaHQgZGV2aWNlIG5vIGxvbmdlciBnZXRzIHJlZ2lzdGVy ZWQgdG9vIGVhcmx5IHdlCj4gc2hvdWxkIGJlIGFibGUgdG8gZHJvcCBtb3N0IG9mIHRoZSBJTlZB TElEX1BJUEUgY2hlY2tzIGZyb20gdGhlIGJhY2tsaWdodAo+IGNvZGUuCj4KPiBUaGUgb25seSBl eGNlcHRpbyBpcyB0aGUgb3ByZWdpb24gc3R1ZmYgd2hlcmUgd2UgbWF5IChpbiB0aGVvcnkgYXQK PiBsZWFzdCkgZ2V0IGEgcmVxdWVzdCBmcm9tIHRoZSBCSU9TIGFscmVhZHkgZHVyaW5nIGRyaXZl ciBpbml0IGFzIHNvb24gYXMKPiB0aGUgYmFja2xpZ2h0IHNldHVwIGhhcyBiZWVuIGRvbmUuIElu IHdoaWNoIGNhc2Ugd2UgY2FuIHN0aWxsIGdldCB0aGUKPiBJTlZBTElEX1BJUEUgZnJvbSBpbnRl bF9nZXRfcGlwZV9mcm9tX2Nvbm5lY3RvcigpLiBTbyBsZWF2ZSB0aGF0IGNoZWNrCj4gaW4gcGxh Y2UsIGFuZCBhZGQgYSBjb21tZW50IGV4cGxhaW5pbmcgd2h5Lgo+Cj4gRm9yIHRoZSByZXN0LCBp ZiB3ZSBzdGlsbCBtYW5hZ2UgdG8gZ2V0IGhlcmUgd2l0aCBJTlZBTElEX1BJUEUgb24KPiBWTFYv Q0hWIHdlIHdpbGwgbm93IGdldCBhIFdBUk4gZnJvbSB0aGUgbG93ZXIgbGV2ZWwgZnVuY3Rpb25z IGFuZAo+IGNhbiB0aGVuIGFjdHVhbGx5IGludmVzdGlnYXRlIGZ1cnRoZXIuCj4KPiB2MjogTGVh dmUgdGhlIGNoZWNrIGluIHRoZSBCSU9TIHJlbGF0ZWQgY29kZSAoSmFuaSkKPgo+IENjOiBKYW5p IE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5 cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogSmFu aSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3BhbmVsLmMgfCAxNCArKysrKysrKystLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgOSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVsLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wYW5lbC5jCj4gaW5kZXggNzA4NjQyYS4uYzQ1YjEyNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcGFuZWwuYwo+IEBAIC02MzQsMTAgKzYzNCw5IEBAIHN0YXRpYyB2b2lkIGludGVsX3Bh bmVsX3NldF9iYWNrbGlnaHQoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJ c3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNvbm5lY3Rvci0+YmFzZS5kZXY7Cj4gIAlzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAJc3RydWN0 IGludGVsX3BhbmVsICpwYW5lbCA9ICZjb25uZWN0b3ItPnBhbmVsOwo+IC0JZW51bSBwaXBlIHBp cGUgPSBpbnRlbF9nZXRfcGlwZV9mcm9tX2Nvbm5lY3Rvcihjb25uZWN0b3IpOwo+ICAJdTMyIGh3 X2xldmVsOwo+ICAKPiAtCWlmICghcGFuZWwtPmJhY2tsaWdodC5wcmVzZW50IHx8IHBpcGUgPT0g SU5WQUxJRF9QSVBFKQo+ICsJaWYgKCFwYW5lbC0+YmFja2xpZ2h0LnByZXNlbnQpCj4gIAkJcmV0 dXJuOwo+ICAKPiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5iYWNrbGlnaHRfbG9jayk7Cj4gQEAg LTY2NSw2ICs2NjQsMTIgQEAgdm9pZCBpbnRlbF9wYW5lbF9zZXRfYmFja2xpZ2h0X2FjcGkoc3Ry dWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJZW51bSBwaXBlIHBpcGUgPSBpbnRl bF9nZXRfcGlwZV9mcm9tX2Nvbm5lY3Rvcihjb25uZWN0b3IpOwo+ICAJdTMyIGh3X2xldmVsOwo+ ICAKPiArCS8qCj4gKwkgKiBJTlZBTElEX1BJUEUgbWF5IG9jY3VyIGR1cmluZyBkcml2ZXIgaW5p dCBiZWNhdXNlCj4gKwkgKiBjb25uZWN0aW9uX211dGV4IGlzbid0IGhlbGQgYWNyb3NzIHRoZSBl bnRpcmUgYmFja2xpZ2h0Cj4gKwkgKiBzZXR1cCArIG1vZGVzZXQgcmVhZG91dCwgYW5kIHRoZSBC SU9TIGNhbiBpc3N1ZSB0aGUKPiArCSAqIHJlcXVlc3RzIGF0IGFueSB0aW1lLgo+ICsJICovCj4g IAlpZiAoIXBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCB8fCBwaXBlID09IElOVkFMSURfUElQRSkK PiAgCQlyZXR1cm47Cj4gIAo+IEBAIC03NDAsOSArNzQ1LDggQEAgdm9pZCBpbnRlbF9wYW5lbF9k aXNhYmxlX2JhY2tsaWdodChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIAlz dHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY29ubmVjdG9yLT5iYXNlLmRldjsKPiAgCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gIAlzdHJ1Y3Qg aW50ZWxfcGFuZWwgKnBhbmVsID0gJmNvbm5lY3Rvci0+cGFuZWw7Cj4gLQllbnVtIHBpcGUgcGlw ZSA9IGludGVsX2dldF9waXBlX2Zyb21fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gIAo+IC0JaWYg KCFwYW5lbC0+YmFja2xpZ2h0LnByZXNlbnQgfHwgcGlwZSA9PSBJTlZBTElEX1BJUEUpCj4gKwlp ZiAoIXBhbmVsLT5iYWNrbGlnaHQucHJlc2VudCkKPiAgCQlyZXR1cm47Cj4gIAo+ICAJLyoKPiBA QCAtOTQ5LDcgKzk1Myw3IEBAIHZvaWQgaW50ZWxfcGFuZWxfZW5hYmxlX2JhY2tsaWdodChzdHJ1 Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIAlzdHJ1Y3QgaW50ZWxfcGFuZWwgKnBh bmVsID0gJmNvbm5lY3Rvci0+cGFuZWw7Cj4gIAllbnVtIHBpcGUgcGlwZSA9IGludGVsX2dldF9w aXBlX2Zyb21fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gIAo+IC0JaWYgKCFwYW5lbC0+YmFja2xp Z2h0LnByZXNlbnQgfHwgcGlwZSA9PSBJTlZBTElEX1BJUEUpCj4gKwlpZiAoIXBhbmVsLT5iYWNr bGlnaHQucHJlc2VudCkKPiAgCQlyZXR1cm47Cj4gIAo+ICAJRFJNX0RFQlVHX0tNUygicGlwZSAl Y1xuIiwgcGlwZV9uYW1lKHBpcGUpKTsKPiAtLSAKPiAyLjAuNAo+Cj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0 Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5pa3VsYSwgSW50 ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK