From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: Linux 3.16-rc2 Date: Tue, 24 Jun 2014 14:06:24 +0300 Message-ID: <871tuea7nz.fsf@intel.com> References: <1403564870.3091.6.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id DAE296E503 for ; Tue, 24 Jun 2014 04:06:42 -0700 (PDT) In-Reply-To: <1403564870.3091.6.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Thomas Meyer , Linus Torvalds , "intel-gfx@lists.freedesktop.org" , Linux Kernel Mailing List , Chris Wilson List-Id: intel-gfx@lists.freedesktop.org On Tue, 24 Jun 2014, Thomas Meyer wrote: > the i915 driver is still broken in 3.16-rc2. Resume from ram crashes the > X server. This is not new to 3.16-rc2; apparently we've had it since v3.15-rc4 [1]. Also related [2]. Chris, any fresh ideas? Thomas, please consider filing a bug against DRM/Intel at [3]. They will have a better chance of not being forgotten as the mail thread goes cold. Thanks, Jani. [1] http://thread.gmane.org/gmane.linux.kernel/1700872 [2] https://bugs.freedesktop.org/show_bug.cgi?id=76554 [3] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI > > First bad commit is: > > # first bad commit: [78f2975eec9faff353a6194e854d3d39907bab68] drm/i915: Move all ring resets before setting the HWS page > > commit 78f2975eec9faff353a6194e854d3d39907bab68 > Author: Chris Wilson > Date: Wed Apr 2 16:36:07 2014 +0100 > > drm/i915: Move all ring resets before setting the HWS page > > In commit a51435a3137ad8ae75c288c39bd2d8b2696bae8f > Author: Naresh Kumar Kachhi > Date: Wed Mar 12 16:39:40 2014 +0530 > > drm/i915: disable rings before HW status page setup > > we reordered stopping the rings to do so before we set the HWS register. > However, there is an extra workaround for g45 to reset the rings twice, > and for consistency we should apply that workaround before setting the > HWS to be sure that the rings are truly stopped. > > Reference: http://lkml.kernel.org/r/20140423202248.GA3621@amd.pavel.ucw.cz > Tested-by: Pavel Machek > Cc: Naresh Kumar Kachhi > Signed-off-by: Chris Wilson > Reviewed-by: Jesse Barnes > Signed-off-by: Daniel Vetter > Signed-off-by: Jani Nikula > > Above commit is not revertable anymore on 3.16-rc2 without conflict. > > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center