From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Avoid NULL ctx->obj dereference in debugfs/i915_context_info
Date: Wed, 30 Apr 2014 14:00:16 +0300 [thread overview]
Message-ID: <871twft73z.fsf@intel.com> (raw)
In-Reply-To: <20140430073752.GC20800@phenom.ffwll.local>
On Wed, 30 Apr 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Apr 30, 2014 at 08:30:00AM +0100, Chris Wilson wrote:
>> In commit 691e6415c891b8b2b082a120b896b443531c4d45
>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>> Date: Wed Apr 9 09:07:36 2014 +0100
>>
>> drm/i915: Always use kref tracking for all contexts.
>>
>> we populated fake contexts on all platforms. These were identical to the
>> full hardware context tracking structs, except for the ctx->obj used to
>> store the hardware state. However, there remained one place where we
>> assumed that if a context existed, it would have an object associated
>> with it.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77717
>> Testcase: igt/drv_suspend/debugfs-reader
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Queued for -next, thanks for the patch.
Why not -fixes? "drm/i915: Always use kref tracking for all contexts" is
present in v3.15-rc2.
Jani.
> -Daniel
>
>> ---
>> drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
>> index 3c066e635022..9f50675c327a 100644
>> --- a/drivers/gpu/drm/i915/i915_debugfs.c
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -1796,6 +1796,9 @@ static int i915_context_status(struct seq_file *m, void *unused)
>> }
>>
>> list_for_each_entry(ctx, &dev_priv->context_list, link) {
>> + if (ctx->obj == NULL)
>> + continue;
>> +
>> seq_puts(m, "HW context ");
>> describe_ctx(m, ctx);
>> for_each_ring(ring, dev_priv, i)
>> --
>> 2.0.0.rc0
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-04-30 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 7:30 [PATCH] drm/i915: Avoid NULL ctx->obj dereference in debugfs/i915_context_info Chris Wilson
2014-04-30 7:37 ` Daniel Vetter
2014-04-30 11:00 ` Jani Nikula [this message]
2014-04-30 12:40 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871twft73z.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox