From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 4/4] drm/i915: Introduce a get_aux_send_ctl() vfunc Date: Tue, 21 Jan 2014 12:12:55 +0200 Message-ID: <871u017ie0.fsf@intel.com> References: <1390233152-2913-1-git-send-email-damien.lespiau@intel.com> <1390233152-2913-5-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id ED1AFFA298 for ; Tue, 21 Jan 2014 02:09:37 -0800 (PST) In-Reply-To: <1390233152-2913-5-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Damien Lespiau , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 20 Jan 2014, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau Might be worth a mention this is prep work for something, as alone this looks like a vfunc for the sake of vfunc... Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_dp.c | 10 ++++++---- > drivers/gpu/drm/i915/intel_drv.h | 8 ++++++++ > 2 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index ae9902a..95147ac 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -491,10 +491,10 @@ intel_dp_aux_ch(struct intel_dp *intel_dp, > } > > while ((aux_clock_divider = intel_dp->get_aux_clock_divider(intel_dp, clock++))) { > - u32 send_ctl = i9xx_get_aux_send_ctl(intel_dp, > - has_aux_irq, > - send_bytes, > - aux_clock_divider); > + u32 send_ctl = intel_dp->get_aux_send_ctl(intel_dp, > + has_aux_irq, > + send_bytes, > + aux_clock_divider); > > /* Must try at least 3 times according to DP spec */ > for (try = 0; try < 5; try++) { > @@ -3685,6 +3685,8 @@ intel_dp_init_connector(struct intel_digital_port *intel_dig_port, > else > intel_dp->get_aux_clock_divider = i9xx_get_aux_clock_divider; > > + intel_dp->get_aux_send_ctl = i9xx_get_aux_send_ctl; > + > /* Preserve the current hw state. */ > intel_dp->DP = I915_READ(intel_dp->output_reg); > intel_dp->attached_connector = intel_connector; > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index 6aeb62a..85bda0e 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -494,6 +494,14 @@ struct intel_dp { > struct intel_connector *attached_connector; > > uint32_t (*get_aux_clock_divider)(struct intel_dp *dp, int index); > + /* > + * This function returns the value we have to program the AUX_CTL > + * register with to kick off an AUX transaction. > + */ > + uint32_t (*get_aux_send_ctl)(struct intel_dp *dp, > + bool has_aux_irq, > + int send_bytes, > + uint32_t aux_clock_divider); > }; > > struct intel_digital_port { > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center