Re: [PATCH 04/62] [v6] drm/i915/bdw: Add device IDs

Chris Wilson
2013-11-04T16:04:56Z

On Mon, Nov 04, 2013 at 04:49:54PM +0100, Daniel Vetter wrote:
> On Mon, Nov 04, 2013 at 02:49:21PM +0000, Chris Wilson wrote:
> > On Sun, Nov 03, 2013 at 04:36:58PM -0800, Ben Widawsky wrote:
> > > v2: Squash in "drm/i915/bdw: Add BDW to the HAS_DDI check" as
> > > suggested by Damien.
> > >
> > > v3: Squash in VEBOX enabling from Zhao Yakui <yakui.zhao@intel.com>
> > >
> > > v4: Rebase on top of Jesse's patch to extract all pci ids to
> > > include/drm/i915_pciids.h.
> > >
> > > v4: Replace Halo by its marketing moniker Iris. Requested by Ben.
> > >
> > > v5: Switch from info->has*ring to info->ring_mask.
> > >
> > > v6: Add 0x16X2 variant (which is newer than this patch)
> > > Rename to use new naming scheme (Chris)
> > > Remove Simulator PCI ids. These snuck in during rebase (Chris)
> > >
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > As a paranoid question, are we sure we have all pci-ids reserved?
> >
> > The actual addition of the pci-ids should be the last patch in the
> > series.
>
> Since all of bdw is currently hidden behind the preliminary hw support
> knob the actual order doesn't actually matter. And imo it's fairly natural
> to have the pci ids as one of the first things, since for bringup getting
> the display going is fairly late work usually.

It more that we disable core functionality after this patch. That feels
wrong, even with the prelim knob we shouldn't be expecting this patch to
cause the hw or kernel to explode.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre