public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, jani@freedesktop.org
Subject: Re: [PATCH] drm/i915: add support for per-pipe power sequencing on vlv
Date: Fri, 06 Sep 2013 12:20:46 +0300	[thread overview]
Message-ID: <871u52cnm9.fsf@intel.com> (raw)
In-Reply-To: <20130906085031.GQ27291@phenom.ffwll.local>

On Fri, 06 Sep 2013, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Sep 06, 2013 at 07:40:05AM +0300, Jani Nikula wrote:
>> VLV has per-pipe PP registers. Set up power sequencing on mode set. The
>> connector init time setup is problematic, since we don't have a pipe at
>> that time. Cook up something.
>> 
>> v2:
>>  - use vlv_power_sequencer_pipe() also in _pp_{ctrl,stat}_reg()
>>  - use PANEL_PORT_SELECT_DPC_VLV (Ville)
>> 
>> v3: make checkpatch happier
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Series merged, thanks for patches&review. Although I couldn't resist to
> make this one here completely checkpatch clean, after all you've bothered
> to resend it ;-)

Hah, I didn't bother with the 80-column rule. Nice of you to bring
checkpatch flowers and all... though you cheated with the 'else if'! ;)

Cheers,
Jani.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2013-09-06  9:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 13:44 [PATCH v2 0/4] drm/i915: vlv backlight, per-pipe power sequencing fixes Jani Nikula
2013-09-05 13:44 ` [PATCH v2 1/4] drm/i915: name intel dp hooks per platform Jani Nikula
2013-09-05 14:56   ` Ville Syrjälä
2013-09-06  4:38     ` [PATCH] " Jani Nikula
2013-09-06  7:20       ` Ville Syrjälä
2013-09-05 13:44 ` [PATCH v2 2/4] drm/i915: move backlight enable later in vlv enable sequence Jani Nikula
2013-09-05 13:44 ` [PATCH v2 3/4] drm/i915: clean up power sequencing register port select definitions Jani Nikula
2013-09-05 13:44 ` [PATCH v2 4/4] drm/i915: add support for per-pipe power sequencing on vlv Jani Nikula
2013-09-06  4:40   ` [PATCH] " Jani Nikula
2013-09-06  8:50     ` Daniel Vetter
2013-09-06  9:20       ` Jani Nikula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u52cnm9.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani@freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox