From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 3/9] intel gen4-5: fix GL_VERTEX_PROGRAM_TWO_SIDE selection. Date: Thu, 26 Jul 2012 10:19:41 -0700 Message-ID: <871ujyqw2a.fsf@eliezer.anholt.net> References: <1342728024-15055-1-git-send-email-galibert@pobox.com> <1342728024-15055-4-git-send-email-galibert@pobox.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2067112832==" Return-path: In-Reply-To: <1342728024-15055-4-git-send-email-galibert@pobox.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org, mesa-dev@lists.freedesktop.org Cc: Olivier Galibert List-Id: intel-gfx@lists.freedesktop.org --===============2067112832== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable Olivier Galibert writes: > Previous code only selected two side in pure fixed-function setups. > This version also activates it when needed with shaders programs. > > Signed-off-by: Olivier Galibert > --- > src/mesa/drivers/dri/i965/brw_sf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_sf.c b/src/mesa/drivers/dri/i9= 65/brw_sf.c > index 23a874a..791210f 100644 > --- a/src/mesa/drivers/dri/i965/brw_sf.c > +++ b/src/mesa/drivers/dri/i965/brw_sf.c > @@ -192,7 +192,7 @@ brw_upload_sf_prog(struct brw_context *brw) >=20=20 > /* _NEW_LIGHT */ > key.do_flat_shading =3D (ctx->Light.ShadeModel =3D=3D GL_FLAT); > - key.do_twoside_color =3D (ctx->Light.Enabled && ctx->Light.Model.TwoS= ide); > + key.do_twoside_color =3D ctx->VertexProgram._TwoSideEnabled; ctx->VertexProgram._TwoSideEnabled is also changed when _NEW_PROGRAM is set, so that should be noted in the _NEW_LIGHT comment above and included in brw_sf_prog.dirty.mesa. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlARfC0ACgkQHUdvYGzw6vcx3gCfVJ03y+FR5E+VJnIbw+j1Fgyn ftsAn1zGsCPB6lyi+vLxWSox55yY9AiA =s/EP -----END PGP SIGNATURE----- --=-=-=-- --===============2067112832== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2067112832==--